35 ms·
We lost 54k GitHub stars
- xyst 5y agoSeems a bit too extra for me. You are literally typing in the fully qualified repo name you want to make private: Please type httpie/.github to confirm. vs Please type httpie/httpie to confirm. At some point, we are going to have to stop coddling the users.
- dogdot 5y agoI liked the post. Then I got interested on their upcoming desktop tool. Then I decided to keep up with them but didn’t manage to find a rss of their blog… Is rss dying?
- salmo 5y agoI agree with the UI stuff and soft deletes. It was a lesson I learned about 7 years ago when I had users make some tragic mistakes in a system I made. “Are you sure?” doesn’t do anything more than a hand wave CYA. Showing the consequences does. But then this starts sounding like a guy who went to the same bank for 30 years, knows the tellers, and doesn’t understand why they won’t give him a small business loan. If you started a company, rely on GitHub for core infrastructure, why would you not pay for it? And if you did this, why would you expect them to do support outside of self-service? Open Source doesn’t mean charity-worthy anymore. Most “successful” projects are either spun out of or spearheaded by a business these days. And it’s not like GitHub is rolling in profit. Their enterprise offering is just starting to get traction under MS. I think the complaints would be more valid if they were outside of the norms in this space. GitHub + MS is still 1000x less shady than Sourceforge. I don’t think you’d see different behavior from GitLab et al. To the real politik-like view: this experience won’t make you (or many others) move elsewhere or pay for the service. So it’s ultimately a 0 consequence situation outside of a blog post and some community discussion. I’m general, I don’t love pieces of software or companies. I’ll wear free t-shirts to mow the lawn, not with pride. I don’t love GitHub, but I dislike it less than the alternatives, partly because it’s just the easiest. I think most are in that camp. Oktocat lost his street cred long ago.
- C4stor 5y agoIs focusing on github stars specially meaningful ? Is there any functional difference for the repo between having 6k stars (as of today) and 54k ? I don't think so honestly. Github stars are just not something useful to monitor closely. I had a look at my starred repos on github, 95% of those I have no idea what it is anymore anyway. So yeah, github didn't do any extra effort to restore what's imo essentially a vanity metric. Makes sense to me ?
- floor_ 5y agoI'm imagining this dev 'rm -rf / --no-preserve-root'ing and then blaming Linus.
- NoboruWataya 5y ago> The problem is that the box looks exactly the same for repos with no commits and stars and for repos with a decade-long history and 55k stargazers and watchers. And it says “Warning: this is a potentially destructive action.” It seems a bit much to expect the website to show you a warning of different levels of severity depending on the stars a repos has, particularly when the standard message is pretty severe and explicit. It even makes you type the name of the repo you want to make private before proceeding - I don't see how that wouldn't make anyone snap out of autopilot. I sympathise with the author's misfortune but it is pretty hard to look at that warning dialog and conclude that he was not sufficiently warned of the consequences or given a chance to reflect. I find it disappointing that all of the lessons supposedly learned from this ordeal are lessons for other people, not the author. Surely lesson #1 should have been "check what repo you're in before taking destructive actions".
- yreg 5y agoI found this article interesting, exactly because "typing the name of the repo you want to make private before proceeding" seemed like a good solution to me as well. (Until now.) However, I can absolutely imagine doing the author's mistake and I think their UI improvement suggestion is great. To me the interface design lesson here is valuable. A recommendation to "check what repo you're in before taking destructive actions" has zero value, since everyone knows that already. --- Completely agreed on the second point though, it's weird to blame this mainly on GitHub.
- kolanos 5y agoIt occurs to me that if your users are mindlessly doing repetitive things, no amount of "Are you sure?" or other hoop jumping is guaranteed to snap them out of it. Humans are pattern recognition machines. GitHub may be better off preventing a repo with this size of a following from being made private without a support request or something requiring a second party to confirm.
- kif 5y agoAt my company, we had like 3-4 steps, each with clear wording to cancel a subscription, and they had to type something in the end to confirm. Guess what? We still had tickets asking to restore their subscriptions :)
- kizer 5y agoRestore their stars! Restore their stars!
- edem 5y ago> But it doesn’t include anything specific to break you out of your auto-pilot mode if you’ve confused the address and think you’re looking at an empty house. Destruction is destruction. I think a huge red notice should be enough to stop you from dozing off. I understand your pain, but I don't think that any of this is GitHub's fault. They can't read your mind, and they can't tell if you're feed up with OSS or just irresponsible.
- mattigames 5y agoImagine this in any other profession, oh I put gold in the trash but the trash bin did not inform me that I was pouring such important thing there, or why the disposal vehicle not stopped me after detecting such valuable content?
- IYasha 5y agoGitHub became more a social platform rather than just a code repository and it let you build up a community - I can't argue with that. But it's a large commercial company that doesn't really care about you. Now, when it's microsoft, more so than ever. I'd never trust my data to a company like that. Last time I trusted Google I lost all (decade worth of) email. I worked in a company that WOULD sometimes make devs manually scrap user data from the database when it was our fault or users were somewhat important, but that's more like exception to the rule.
- drewda 5y agoWe use a nice SaaS service for time-tracking and invoicing called Harvest. I'm thinking of it, as when you go to delete an existing invoice, it has a similar prompt to this GitHub prompt. But instead of having you type in the org and repo name, you have to type in "YOLO" (as in, "you only live once" :)
- WesolyKubeczek 5y agoOkay. I just went in and double checked. 600+ comments bashing Github for not having prevented this action. Meanwhile, Github: 1) has this action in the "danger zone", literally the only UI element using RED COLOR; 2) has a warning banner on the dialog box that pops up when you click that button; 3) requires you to type in the name of the repository (which everyone copies and pastes anyway because they don’t get the point of this exercise) So when you have all those things in place and still fly past all the defenses on an autopilot, you're not that bright to begin with and you should only blame yourself. Meanwhile, there are 600 comments bashing Github for not putting in undo, or somesuch. The problem is, though, that this kind of carelessness that led to the repository losing its social stats doesn't stay with computers. It may very well carry over to other aspects of life, because an attitude is something ingrained way deeper than just using one computer program. And then we have Youtube brimming with compilations of how cars don't stand a chance with trains. You would think that: 0) unambiguous warning road signs 1) red blinking lights 2) ringing bells 3) the train itself honking its horn for a couple miles before even approaching the crossing should be enough warning for the driver to move his/her ass off the track, and yet here we are. So, yep, we may need to have better systems here and there, but being careful where it says "danger" should be a part of basic fucking competence at whatever it is you do. There are, shockingly, areas in life where an undo button doesn't exist. No, the fact that the other side didn't put safeguards in is not an excuse.
- a99c43f2d565504 5y agoI'd recommend reading the actual post carefully before claiming to having double checked anything and then going on judging using harsh language. You completely missed the 54k stars question presented and the context in which it was presented to the op.
- WesolyKubeczek 5y agoOh for god’s sake, cry me a river. Boo freaking hoo. You go to the danger zone, you fucking stop and think, and you read the alerts, and make sure you understand what they actually say. Then you proceed, maybe. Like an adult. Next time, what, they’re going to mistake deleting a repository with changing its visibility? If httpie is that good, they should be able to regrow their stars in no time. What a first-world problem to have indeed.
- brian_herman 5y agoI gave them a star to help them out.
- israrkhan 5y agoThis hackernews post and other media coverage is getting the job done. Yesterday I saw they were at 3.2K stars, and right now they are 8.7 stars. I suspect this event will get them more users and will turn out better for them in the long run.
- prmoustache 5y agoThe real lesson I make of it is that we shouldn't use a cloud product or SaaS if vendor do not allow customer to request recovery or prevent the customer to manage its own backups. I know git is decentralized and no code is ever lost but github is so much more than git. Backups aren't mean to recover from outages. They are also, and I would even dare saying mostly, used to recover from human mistakes. If the vendor terms and conditions don't allow this, github is not a production ready solution.
- al2o3cr 5y agoAlternate title: "How I deliberately messed up and why it's definitely everyone else's fault"
- varajelle 5y agoThey already have more than 10k star now. So this mistake sure gave them some publicity.
- vladsanchez 5y agoI just starred HTTPIE again. I feel their pain and while I don't claim to be perfect, this was was self-inflicted as it was clearly stated in Github dialog warning: "You will permanently loose all stars and watchers of this repository" Please don't blame Github for EndUser fault. People are click-happy and don't read. I'm happy they're able to restore their reputation and followers, not because of pity but because their product value and reputation. Congrats HTTPIE!
- polote 5y agoThat's crazy that a manual error by someone, for whatever reason, end up being an article blaming Github for all sort of reasons. And never accepting that the thing that really failed here is the user who performed the action.
- enlyth 5y agoThey do raise a good point about the UI though, explicitly showing "you're about to nuke 55k people, are you sure?" would make the user pause.
- spiderice 5y agoI have no dog in the fight here, and no affiliation to HTTPie, but this definitely seems like a Github issue to me. You can't just give users ways to easily and accidentally shoot themselves in the foot, and then blame the user for shooting themselves in the foot.
- akerl_ 5y agoWho got shot in the foot here? The article keeps talking about killing 55 thousand people. I’m trying to grok why “unstarring the repo” is such an earthshattering thing. It’s annoying if you wanted it starred / wanted notifications, because you have to notice and redo it… but there’s no irreparable harm, no data loss. This reads like somebody was placing way too much personal mental value on “the repo for my project has a large number of stars”
- delaaxe 5y agoHave you been living under a rock? Everyone judges repos by their amount of stars. Why do you think every social media network has the concept of likes?
- munk-a 5y agoCan you just clarify if that statement was sarcastic or not? I've had a very different experience around stars - they're just a bit of fluff and pretty unimportant compared to watches.
- sefrost 5y agoIt does strike me as unfair that GitHub themselves made the exact same mistake but were able to fix it with database backups.
- yreg 5y agoIt would strike me even more unfair if GitHub fixed this mistake only for customers they like.
- rincebrain 5y agoI would observe that even today, the GH desktop repo has only 14k stars, and at the time, archive.org says only 2.6k[1] - so I would not be surprised if the costs associated with the restore were massively different. (Not weighing in on whether they still should have considered it or not, just observing that their claim that it costs an unacceptable amount may not be inconsistent with having restored a much less comparatively "hot" repo.) [1] - https://web.archive.org/web/20201116172809/https://github.com/desktop/desktop https://web.archive.org/web/20201116172809/https://github.co...
- munk-a 5y agoI'm just surprised that after going through that pain themselves they didn't decide to revise how that social linking data is handled. A lot of github content is softly deleted by necessity, you couldn't nuke tickets written by a now non-existent user or unmerge PRs so this isn't really a new concept to the team. I don't think it's surprising they'd do such a thing for themselves and not a customer - I'm more surprised they didn't remove the footgun for future mistakes on their part.
- deleted 5y ago[deleted]
- op00to 5y agoOr simply automate the restoration! They know how to do it! Make it easy!
- 5y ago
- deleted 5y ago[deleted]
- tester756 5y agoWhy do they even delete those stars?
- akerl_ 5y agoWhen the repo goes private, people who can’t see it any more can’t have it in their list of starred repos.
- tester756 5y agowhy not just do not display it and keep stars?
- munk-a 5y agoSo mark the repo as private without their permission to view and have queries for starred repositories ignore repositories you can't view - that's an extremely frequent approach to take with complex permission and social functions. I completely understand that not everyone has time to build everything and software is an evolving process - but soft deletion for social links is my default state of mind (then you overlay it with indexing or caching or whatever your performance flavor is to make sure those soft deleted rows don't exist in the active query space).
- akerl_ 5y agoI mean, they totally could have built it that way. But they didn’t. I was answering why stars were removed. From a data complexity standpoint, it sounds like they decided they didn’t want to have to make calls to the authorization layer when parsing a user’s stars. The downside is the behavior seen when a repo goes private, but my bet is that repositories being made private is far less frequent than calls to get a list of starred repos.
- munk-a 5y agoI totally get that - it's not an insane design decision it's just different from what my default suggestion would be. And to be honest - your source of truth database, on a system of this scale, is likely going to be detached from your pool of active data (possibly with some data shadowing, caching - what have you). The thing that throws me off is that they shot themselves with this footgun - whenever we (munk-a's employer) footgun ourselves we remove the footgun to prevent future footgunnery. They made the original design decision one way, and when they were burned by it they didn't re-examine it.
- paxys 5y ago"It's their fault, they only showed 5 warning banners. A 6th one would have totally stopped me from doing this." If a "type your repository name to confirm" box still doesn't make you double check that you picked the right repository, what else can they even do?
- deleted 5y ago[deleted]
- kemitche 5y agoThere's more nuance there: > I didn’t realize at the moment there’s an inconsistency in the naming of this special repo containing profile READMEs and that it differs for users and organizations: name/name vs. name/.github. It's not unreasonable for the author to have taken the action they did given what they were trying to do. The inconsistent UX for User vs Organization READMEs is a major factor in how the error happened. And given the number of single-repo orgs where the org's main product repo name == the org's name, well, it's not as surprising I'd say.
- farmerstan 5y agoI came in to say precisely this. It’s easy to point fingers after the fact but probably the person wouldn’t have checked regardless of the message in the dialog box. “They warned me but because I didn’t read the dialog box because it was too boring!
- sbarre 5y agoif you RTFA he did actually read the dialog box (which is where he found out that it would delete the stars) he just didn't notice the 1 line in a 30+ line generic modal. He accepts responsibility for what he did, but points out the very real opportunity to improve the UI/UX of a very destructive operation with real contextual data about what is about to be destroyed.
- pharrington 5y agoYou can only confirm the dialog box by typing in that line you're saying he didn't notice.
- catsarebetter 5y agoStarred and watched again, it's a great project, hopefully the whole audience comes back soon
- deleted 5y ago[deleted]
- williamsmj 5y agohttps://rachelbythebay.com/w/2020/10/26/num/ https://rachelbythebay.com/w/2020/10/26/num/ makes a similar point. I don't remember us saying people only have themselves to blame when that article was posted (https://news.ycombinator.com/item?id=24904204 https://news.ycombinator.com/item?id=24904204). Not sure why we're doing it on this post, which makes a number of completely reasonable and specific suggestions for improvement.
- paxys 5y ago"Type a specific thing to confirm" (as suggested by the post you linked) is exactly what Github does for destructive actions. And the author still messed it up because they were on "autopilot". At that point the suggestions go beyond being reasonable.
- sbarre 5y agoYou really think that adding contextual information in a destructive modal (i.e. "You are about to erase 54,000 stars") is "beyond being reasonable" ? It seems like a pretty reasonable suggestion that doesn't feel like a lot of work, but could potentially prevent an irreversible mistake.
- williamsmj 5y agoIt doesn't suggest that you type a any old "specific thing". It specifically suggests that you type something to demonstrate you acknowledge the scale of the destructive operation you are about to perform. The OP's main suggestion is along exactly those lines. It's actually less extreme, in some ways (see OP's "Lesson 1").
- BHSPitMonkey 5y agoThe confusion is justifiably well explained by the article: > What put me on the wrong path was an otherwise completely unrelated action: I had just done the same (i.e., hidden an empty README) on my personal profile by making jakubroztocil/jakubroztocil private. > GitHub’s conceptual model treats users and organizations as very similar entities when it comes to profiles and repos. In this context, and since I just wanted to repeat the same benign action on our organization’s profile, my brain switched to auto-pilot mode. > I didn’t realize at the moment there’s an inconsistency in the naming of this special repo containing profile READMEs and that it differs for users and organizations: name/name vs. name/.github. > That’s why I proceeded to make httpie/httpie private instead of httpie/.github without realizing my mistake.
- ghoomketu 5y agoThat comparison spot the difference pic is really scary. I had to check it 2 times myself before I could spot that the last line is different. Now that you're on the HN's frontpage, hopefully somebody from Github upper management will see this and all will be good soon thanks to gold old HN (especially when they did the same thing themselves and restored it). Wish you the best.
- capableweb 5y ago> That comparison spot the difference pic is really scary. I had to check it 2 times myself before I could spot that the last line is different. That's not the only difference. The other difference is that you also have to type the full repository name, including the organization name. If they wanted to delete the correct repository, they would have to type httpie/.github, but instead they typed httpie/httpie. It's unfortunate what happened, but without GitHub removing the possibility at all to delete repositories/change the visibility, I don't know what else they could have done to try to prevent it. It's really hard as a user to affect the wrong repository, as you are gonna have to mentally and literally pause to write out the organization name + repository (httpie/httpie in this case) and if that doesn't stop you, I don't think anything would.
- dmitriid 5y ago> The other difference is that you also have to type the full repository name, including the organization name. No, you don't have to type it, and I doubt anyone types it. You copy that line and paste it. Often it's done on autopilot, especially when in a rush.
- superasn 5y agoI always just select the text and drag drop it in the text box with mouse. In famous words of Mr. Larry wall, 3 great virtues of every programmer: laziness, impatience, and hubris.
- ivirshup 5y agoI type it. It’s typically short short, and it’s a very destructive action. It’s also very apparent to me why I would want to type it out. That said, someone is going to make a mistake at some point. I’d expect better from github support here.
- throwawayHN378 5y agoUgh that sucks
- pluc 5y agoYou didn't lose anything, you asked for it to be removed by setting your repository private, albeit mistakenly. Something that is public (stars) cannot coexist with something that is private (your repo), otherwise unexpected things start to happen or you need to write a bunch of pointless edge cases. It makes sense. So does this article, but it should be a "lesson learned" and not a "GitHub fucked us" angle cause it pretty clearly tells you what you're about to do.
- williamsmj 5y agoThe article literally has a section "Lessons learned".
- forgotpwd16 5y agoLessons learned... for GitHub to take.
- epidemian 5y agoThis is a similar attitude to blaming users who close an program without saving, telling them it's their fault; the program even asked if they really wanted to close without saving! But, it's also totally possible for a program to store a backup, and let the user restore that the next time they open the program in desperation for not having saved their document in a moment of distraction. > but it should be a "lesson learned" Yes. And as the article notes, the lesson can be that software and UX can be make to accommodate better for possible user mistakes. I personally think it's nice to have Undo actions, or some ways to revert possible mistakes. It makes software way less scary :)
- bearbin 5y agoWhy care? Stars don't mean anything, save for the few people who organise the software they use by starring it. Certainly it's not a community owned by the maintainers. I don't own a connection with the people that upvoted this post, and stars mean exactly the same (effectively nothing).
- terinjokes 5y agoThis change also clears out watchers. I was watching the repo to be notified of new releases (and security updates) and that was wiped out as part of this mistake.
- evouga 5y agoOf course if GitHub were only a service for cloud hosting of Git repositories, it would be totally irrelevant whether or not the repository was marked private for 30 minutes. But GitHub, by design, seeks to be as much of a social network as a repository hosting service and people take the stars very seriously. I’ve seen many CVs that brag about the candidate’s star counts.
- asadawadia 5y ago>GitHub, by design, seeks to be as much of a social network This is so true - not sure why it isn't getting talked about more - they even have a feed now [which is getting better every few days]
- pizza234 5y agoThe post is omitting that the user must type the name of the repository in full; in this case, they typed `httpie/httpie`. If one is in such a deep autopilot state, no amount of warnings will work.
- phphphphp 5y agoDoes anybody actually type those? They were a neat solution 10 years ago but they’re so common now for even inconsequential actions that I always copy and paste, on complete autopilot.
- w-m 5y agoI came across such a prompt maybe three times total in my life, all of them making GitHub repos public or private, or deleting them. Made me stop completely in my track. So it seems to be very much dependent on what you do day to day.
- CuriousCosmic 5y agoThe post addressed this. > What put me on the wrong path was an otherwise completely unrelated action: I had just done the same (i.e., hidden an empty README) on my personal profile by making jakubroztocil/jakubroztocil private. > GitHub’s conceptual model treats users and organizations as very similar entities when it comes to profiles and repos. In this context, and since I just wanted to repeat the same benign action on our organization’s profile, my brain switched to auto-pilot mode. > I didn’t realize at the moment there’s an inconsistency in the naming of this special repo containing profile READMEs and that it differs for users and organizations: name/name vs. name/.github. > That’s why I proceeded to make httpie/httpie private instead of httpie/.github without realizing my mistake. There's a subtle naming difference between profile README repos for users and orgs that was the root cause of this. The user typed the repo name in however because it matched the same format for the previous profile README repo, it didn't register that this was not in fact the profile README repo they were looking for.
- burnished 5y agoThe post did not omit that, it included the very similar thing they typed as context for how they auto-piloted it. In that autopilot state having to type out 54000 would probably have snapped them out of it. I get why you'd think the author is being unreasonable, they seem to imply that this should already have been done, but I think that is mostly them feeling upset about the situation. The actual observations would be thoughtful improvements to the UI.
- jakelazaroff 5y agoGitHub made a cardinal UX design sin here: never use a warning when you mean undo [1]. If they had given even a five minute grace period before starting the irreversible process of removing all the watchers, this wouldn’t have happened. https://alistapart.com/article/neveruseawarning/ https://alistapart.com/article/neveruseawarning/
- capableweb 5y agoWhich comes with its own problems. What if I just published something I wanted to be secret? Then I need to be able to switch it back to private, and it has to be quick, not after five minutes. Distributed systems with eventual consistency already make fixes like that hard, not to mention caches and whatever.
- hnlmorg 5y agoThe GP didn’t mean “wait 5 minutes before making any action”, they meant “stage the change so the user can see the result of their action but they still has a grace period to undo it”.
- ncmncm 5y agoOr, have there be no need to undo anything. Why should ticking the "private" flag have any effect on anything else? If you wanted an effect on something else, a separate button "Nuke all 53,675 star from this repo", with its own protections, would suffice.
- maleldil 5y agoHow would stars and watchers work on a private repo, though?
- jakelazaroff 5y agoJust don't show them. Filter out private repos before showing a user's stars, notifying them of issues, etc.
- dom96 5y agoSurprising amount of people blaming the user here. I agree completely with the author, the UX should be different for clearly "big" repos.
- barrucadu 5y agoHow big is "clearly big"? Whenever someone makes the same mistake with a slightly-less-big repository should the warning thresholds be revised to also show up for those?
- dewey 5y agoIt should just show the amount of stars / watchers for any repository. I don't think a custom strategy based on repo size is needed.
- CreepGin 5y agoMurphy's law strikes again. Really appreciate the writeup. Making the best of the situation is a valuable lesson in itself. Hope you can get the stars back one way or another! =)
- forty 5y agoWhat can you purchase with GitHub stars? More seriously, why do they matter? Is it a prestige thing only or are there practical consequences to losing the stars?
- acid__ 5y ago(Whether it's a good idea or not,) people often use stars as a quick-and-dirty proxy for "is this repo reasonably well trusted?" and "how big is the community for this project?". All else being equal, many people would default to using a repo with 20,000 stars over a repo with 20.
- maxloh 5y agoAs a junior developer, GitHub star was one of the most important metric when I am choosing library/software.
- wpietri 5y agoStarring a repo is a way of tracking it. So now there are 55k people who were trying to keep an eye on the project who have silently lost that. It's also an important indicator of community size and authenticity, important factors in the decision to use the code.
- layer8 5y ago> silently I’d argue that GitHub should send them a notification that the repo they starred has been made private.
- ncmncm 5y agoAnd another that it was made public again. Or neither, and just not delete shit that there was no need to delete.
- layer8 5y agoMy point is that IF they delete everything, they should send a notification to the affected users. When the repository is made public again, then since they deleted the star relation it’s not possible to send another notification.
- deleted 5y ago[deleted]
- tomphoolery 5y agoThis happened to me as well. It's sad that GitHub doesn't retain that data.
- mekster 5y agoThey apparently do. Even if they did hard delete they still should have backups. They just got lazy fixing it after several similar incidents and this one was expected and yet all they do is a tweet saying "good luck building up the community again". My faith in their tech department is falling when they can't fix such a small issue.
- RangerScience 5y agoHeavily reminds me of this RubyConf talk: https://rc-temp000-videos.s3.us-west-1.amazonaws.com/Laura-Maguire.mp4 https://rc-temp000-videos.s3.us-west-1.amazonaws.com/Laura-M... One of the core bits of the talk is about the sort of messages our automated systems give us, and whether they're sufficient, or woefully lacking - which is what the linked article is also talking about, when it talks about how the "warning: about to burn down a house" doesn't tell if anyone's in that house.
- vaishnavsm 5y agoI really like this post. While the author clearly feels bad about the fact that they've lost his community and that GitHub didn't restore it (which is honestly what any of us would've felt under similar circumstances), they're also focusing towards the future and using their personal experience as a parable all of us can learn from. Lesson 1 on UI design I think is really important. I often think scary popup boxes are enough to get people to think about what they're doing, but this example clearly demonstrates that what's important is to use design not to scare (alone?), but to convey the information which makes a dangerous action dangerous as well. I also really like the fact that when the action isn't dangerous, the distractions ("Type this repo's name", etc) just go away. It's super intuitive, and (for a newbie designer like me) really helps build an intuition for various design principles put in action. Lesson 2, which was to use soft deletes, is something I have more thoughts about. I assume that the cascading done on GitHub would be done on a FK constraint, but I'm not really sure how you'd do a "cascading soft delete" without making some kind of manual cascading logic? If anyone's aware of a standard way to accomplish this, please do let me know. Of course, the best way may just be to simplify the model so they aren't needed at all haha. As designers and developers we've been given a chance to sharpen our toolkit. Thanks, HTTPie! You've gained a new star :) Edit: Changed GitHub couldn't restore to GitHub didn't restore, as pointed out by @ncmncm (https://news.ycombinator.com/item?id=31033758#31034195 https://news.ycombinator.com/item?id=31033758#31034195)
- harg 5y agoRegarding cascading logic with soft deletes; I think the answer is that you don't cascade anything. You basically need to have `deleted_at IS NULL` conditions in your queries to exclude them.
- SkyBelow 5y ago>I often think scary popup boxes are enough to get people to think about what they're doing This would entirely depend upon how often it shows up. The more often it shows up when the scare isn't relevant, the less people will pay attention to it. >the distractions ("Type this repo's name", etc) just go away I think it shows that what one types needs to be relevant information. In this case, due to the similarity between when the author would've been asked if they did what they were intending to do and what they typed to do what they actually did, we can judge the prompt isn't enough. If this also asked you to type in the number of git stars you were about to lose, that would've been enough to make author recheck exactly what they were doing.
- HL33tibCe7 5y agoI notice there are a lot of people in this comment section who either haven’t read the article at all, or haven’t read it in full. Worth reading the full post before commenting
- ncr100 5y agoI read it. I think there should be a follow-on discussion here about programming paradigm that empowers a "do what I mean not what I say" mentality. Atlassian's recent fiasco https://www.atlassian.com/engineering/april-2022-outage-update https://www.atlassian.com/engineering/april-2022-outage-upda... is another motivating example for such a paradigm. The author of the blog touches on this paradigm as a UI element. Software engineers should have pushed that as a "gotcha" up through Product Management to expose controls for such a risky scenario.
- bsuvc 5y agoSure, the author should be responsible. Yes, GitHub should have a better UX around this action. But... There is another thing to consider: Is it really necessary that a repo that is accidentally made private and then made public should lose its stars anyway? Is that really what the repo owner or the people who starred the repo even want to happen?
- GnomeSaiyan 5y agoAgreed. This just screams bad UX on a corner case.
- JadoJodo 5y agoI don’t know for certain but I feel like this could allow something like 1. Takeover/inherit public repo with lots of stars 2. Take repo private (retaining stars) 3. Replace repo code with some malicious/offensive code. 4. Take repo public again 5. Inherit the trust/prestige of the old repo.
- sam0x17 5y agoYeah but it's not like stars are seen as some amazing endorsement on the part of the individual starring. It's more like a favorites list if anything
- freedomben 5y agostars absolutely are seen as an endorsement. I'm guilty of that for sure, and I've been in a ton of conversations about adopting some thing and the "number of stars" is often a consideration unless it's a project like React or Vue, etc. Would you really not look at two repos that do the same thing, with similar ages and recent commits but one has zero stars and the other has hundreds, and not at least initially trust the latter more?
- ninkendo 5y agoYou can do that without the “making it private and public again” part anyway.
- wilg 5y agoDo people use GitHub stars for something? Sometimes I star things but I have no idea what it does or why I do it.
- mattgreenrocks 5y agoIn the absence of metrics to use for ranking, it is hilarious how people co-opt whatever weak metrics they find and then retcon a deeper meaning into them. “They’re not stars, they’re a community!” What percentage of your community actively contributes bugfixes?
- layer8 5y agoIt’s basically just a bookmark for yourself. And GitHub shows how many users have “bookmarked” a particular repository.
- OJFord 5y agoOof. Nice write-up, and it'll probably work. I.e. I'd wager that 'no we won't do for you (even in exchange for cash) what we previously did for ourselves' decision is going to get reversed.
- jrockway 5y agoI think there are two types of destructive actions; destructive actions you do as a part of completing some other task, and destructive actions you do for compliance reasons. I think the problem arises when product designers aren't sure which case their data deletion function is for. If you dumped a bunch of social security numbers in your non-confidential data history and batch job system, you'd want to be able to permanently delete it as part of the incident response, to reduce the number of people that are exposed to data they shouldn't have access to. But if you delete some lines of code from your text editor, they can just pop back into existence with the press of a key because you were probably just moving them around, or trying some buggy function without a piece of code you thought might be unnecessary to isolating the defect, etc. Editors clearly understand that you don't kill text out of an Emacs buffer to solve a compliance issue, so they keep it around even though you technically asked for it to be deleted. (Imagine how crazy it would be if deleting text in your editor deleted it from memory, the clipboard, version control, and your upstream VC server!) In the case of this Github issue, there was clearly a fundamental misunderstanding. Github probably imagined the feature as a compliance type thing; get this stuff off the Internet as fast as possible at any cost necessary. Delete the list of people that even knew this thing existed! I could see why someone might want that. But what the user thought was that this was something they needed to do along the way to some other goal. I have a feeling that people pick the compliance route more often than the "experimentation" route more often than not, not because they expect users to have actual compliance-type issues, but simply because it's easier. The net result is that users are trained to fear computers and fear experimentation, and that's a bad state we've put society in. This article is yet another victim of "if they said they were sure they wanted to delete it, we can just delete it". But it's actually pretty rare that people are sure.
- capdeck 5y agoWell, it is at the top of Hacker News. If everyone just goes to https://github.com/httpie/httpie https://github.com/httpie/httpie and stars it again - we'll fix it in a jiffy!
- ncmncm 5y agoAs the article noted, that absolutely would not fix the underlying problem at all.
- yowlingcat 5y agoWhat an astonishingly poor design decision by GitHub. The intelligent design decision to making a repository private is to have private be a flag, and to have that privacy setting propagate down to the watcher level. Then, when a repository is made public again, all the watchers etc return. Want to give users a way to remove all watchers? Great, make that /a separate action/ -- in no world and in no other application is it an intuitive UI/UX pattern to have make something private mean it gets deleted. That's absurd. Make private means "hidden for the indefinite future, but available to be made unhidden when I as a user see fit." That is the only reasonable definition I have ever seen (Instagram for example). Whether you want to show a user that they watched a repository which is no longer public or simply have it disappear is up to the user, but I cannot understand why anyone thought that the straightforward solution was to /simply delete the data/. Between this and the now common downtime, I'm increasingly worried that GitHub is simply asleep at the wheel.
- jamesmishra 5y agoThis is a well-written blog post describing a real issue with GitHub's privacy mechanism. But it is also a little silly for the blog post to show graphs extrapolating the hypothetical number of GitHub stars several years into the future. Their graphs' X-axis goes up to 2028.
- lexx 5y agoOn the plus side. 54k know and use this project not because they have it starred. So it will regain the stars rapidly, and it will again hit all the trending metrics, so new people will discover it also. No biggie
- wly_cdgr 5y agoThe author shows admirable restraint in characterizing Microsoft's response
- wly_cdgr 5y agoSounds like Microsoft recruits from the same pool as Atlassian for its Customer Success team :)
- caymanjim 5y agoOn the bright side, I had no idea this existed, and now I'm going to use it quite a bit. And evangelize it to coworkers, who probably also don't know it exists, or one of them would have used it during a pairing session. I doubt they'll get back to 54k stars (and really, who cares about stars?), but this will probably lead to a lot more new users.
- DryLabRebel 5y agoSame!
- lmc 5y agoSorry but losing stars by going from public to private is a small price to pay compared to going from private to public - what would you suggest be the guiding hand to prevent that kind of situation?
- nosefrog 5y agoAdditional context: a GitHub employee addresses why they didn't do a backup restore in this tweet: > Yup, all watchers go when you go private and a bunch of notification settings etc. We've tried re-staring projects in the past etc but that ends up breaking lots of peoples notification settings. It's something we should make more reversible but hard for reasons <waveshand> > It's the reason we display this when you try to do it. But a better fix would be for us to make it more easily reversible in the future. https://twitter.com/martinwoodward/status/1493336490251894784 https://twitter.com/martinwoodward/status/149333649025189478...
- mekster 5y agoThat's one of the exact phrases you don't want to hear from a tech department. They make tech excuses which were ultimately their own design and tell that's not possible to be fixed.
- johnwheeler 5y agorm -rf / gives no such warnings, and maybe it should, or maybe people should be _very_ careful when typing rm -rf in front of anything.
- alecbz 5y agoIt’s both, but mostly the first one. rm’s default behavior is terrible design. Just because UNIX does something doesn’t make it good.
- mjyut 5y ago> GNU rm normally declines to operate on any directory that resolves to /. https://www.gnu.org/software/coreutils/manual/html_node/Treating-_002f-specially.html https://www.gnu.org/software/coreutils/manual/html_node/Trea...
- mekster 5y agoThis is laziness on GitHub. If your client asks you for work and you get lazy because it needs some internal modification that could take a day instead of an hour, you just respond it's impossible. Generally that's quite unacceptable especially when they already know about the situation from previous incidents and obviously human errors could happen again and the fact they did restore for their own project doesn't make it look any better.
- hcks 5y agoThe author is not a client but a user. He doesn't pay GitHub, and is certainly not entitled to having a day of internal engineering workforce (costing in the tens of thousands of $) fixing his mistakes.
- pm90 5y agoThis kind of shit (accidentally doing something that in retrospect feels dumb and stupid but made sense if you were in a certain brain space) happens all the time and it’s nice the author wrote about it. I could easily see myself doing this. It should be possible for GitHub to restore. If not now, then in the future.
- HellsMaddy 5y agoIn America, we blame individuals when systems fail. We don't have to, we can actually design systems to be better. Design isn't just about making things look pretty. Good design reduces entropy. https://www.youtube.com/watch?v=Ra_0DgnJ1uQ https://www.youtube.com/watch?v=Ra_0DgnJ1uQ https://en.wikipedia.org/wiki/Human_factors_and_ergonomics https://en.wikipedia.org/wiki/Human_factors_and_ergonomics
- _moof 5y agoThankfully there are exceptions to this, notably aviation. Having all accidents investigated by an independent board with a systems approach has proven to be an extremely successful model. It's a shame it isn't replicated elsewhere.
- ncmncm 5y agoA disgrace. It's not like it is any easier in aviation than anywhere else. Civilian oversight of police departments could be instituted, too, investigating killings and maimings by police. It could be federally supervised, instead of relying on every state, county, and Podunk town to institute it.
- izacus 5y agoIn aviation, a pilot who would ignore so many warning elements of UI (red button, dialog, retyping things) on "autopilot" would have their license revoked and possibly criminal charges pressed.
- actually_a_dog 5y agoMeta: why is the word "how" omitted from the title? I've seen this a couple of times recently and I don't understand why people are omitting words like "how" and "why." The only thing I see in the guidelines is about omitting "gratuitous" numbers and adjectives, neither of which "how" and "why" are.
- hollerith 5y agoThe server automatically removes "how" and "why" at the start of a title. Numbers or at least 10 are also autoremoved.
- WhyNotHugo 5y agoThis sounds like a great opportunity to move onto an open source platform to host this very popular open source tool. Their current hosts have even just proved that they don't care about them much -- only first party projects get special treatment.
- alecbz 5y agoOpen source doesn’t mean direct access to the underlying data/databases. Self-hosted could work, but creates new problems like “are you sure your backups are working?”
- pmarreck 5y agoI like the tool, somehow I'd never heard of it until now
- hitovst 5y agoYikes. Can this be turned into a multi-sig 2fa, or 1 hour waiting period before confirmation?
- a-dub 5y agoeh, github kinda sucks. they should fix this, or at least pull username lists for stars/follows and give them to the user for followup. if the user self hosted, they'd pull from their own backups. instead they trusted a third party and helped contribute to that third party's success. now it's that very success that the user contributed to that stands in the way of help resolving the user's problem. shrugging and saying sorry is kinda pathetic.
- michaelterryio 5y agoGitHub should restore it and they should do it to cause themselves pain so they address the the improvement they can make to the Uc.
- jzer0cool 5y agoI sympathize with you. I think it is best policy they do not give you back the stars, because I can see a wave of potential misuse which could also open up vulnerabilities exploiting this practice. Does anyone use "stars" as some form of credibility to the project in terms of security? Given your reputation, I find you will get back your stars again and maybe even higher than before. Or, at least, it shouldn't be that hard :). With that said, I am glad to have come across this site. Sure seems to beat postman :)
- kelnos 5y agoI agree that it would be more clear if the visibility-change dialog included some stats about the repo so you can confirm at a glance that it's the right one, but... it asks you to type the full name of the repo before it will allow you to proceed. If you do a copy-paste of what it tells you to type, that's on you. The entire point of that box is to get you to think about what you are doing, and explicitly type out the name of the thing you want to change. Perhaps I've interacted with GitHub's UX enough to be familiar, but when OP put up a side-by-side screenshot and asked, "A 54k-star question: Which one of these two dialogs is safe to confirm and which one deletes a 10-year-old community?" ... I looked at the two boxes, saw the repo it was asking to modify in both cases, and immediately knew the correct answer! I get that the ideal is that every person who takes any kind of action knows what they are doing and never makes a mistake. I don't know if it's realistic to expect that outcome, but certainly that's the ideal. But how far should UX designers bend over backwards to cater to people who perform destructive actions without paying attention to what they're doing?
- anm89 5y agoJust went and starred the repo. Looks like they are back up to around 5% of their original star count. Not good but probably not a catastrophe for the project. It seems the loss of watchers is still an issue though.
- soorya3 5y agoThis is definitely a lesson for you as a customer and github service provider. As customer if you are getting something for free you have to assume all risks. Here would be nice if public repos are also paid for open source projects so that you can pay for basic backup and recovery. As a service provider github think about the product - "how do I design a more reliable system?" Deleting data immediately is never a best practice better alternative is to delay the destruction.
- werdnapk 5y agoThis reminds me of an app of mine that was a top 20 paid app 8+ years ago in the Apple app store. To try and gain more users, I decided I'd try a little test and make the app free for a short amount of time. What I did not realize was that changing the app from paid to free would completely remove my app from the top 20 charts and the free app ended up at the bottom of the free charts. The app gained positions pretty fast in the free charts, but it never got close to what it was before. Biggest mistake I could have made in hindsight and there was nothing I could do about it. This was my first app in the app store, so I hand no experience with how things worked.
- NorwegianDude 5y ago"the biggest accidental community loss in open source history" This was very much drama for very little. Sure, some might follow the project to know about updates, but if people care that much if they are using the latest version of a CLI tool then they will certainly check it out again later. Very very few people of those who followed the project cares, and close to nobody cares what percentile the project ranks as by number of stars on github. Heck, even the author cares so little that he let himself mess around mindlessly while ignoring warnings and forgetting what the project was called. Github warned about the action, and even required written confirmation to make sure it was the correct repo. The author also makes a point about naming being different for orgs and private, but if the github repo had any meaning then the author must have been very aware of what the name of it was. Sure, github can add even more roadblocks and confirmations for those who are very careless despite all the warnings, but I don't want that personally. It's a tradeoff, and I think github has the right balance. But sure, the situation is mildly annoying for those few who actually care. But the dumbest part: The complaint about github not using time to restore backups to correct the mistakes of the author. Sure, they probably could, but how will they decide if a user should get special treatment? If they start bringing out backups for some users then there will be a lot of others expecting and asking for the same thing, and more. Some might say that it won't be a problem, but considering that the author is already expecting github to restore their backups for him because github restored their own backups only proves the problem.
- chikipowpow 5y agoWow, the tone alone leaves much to be desired. You must have a very unempathetic culture where you live. Best of luck to you dude, all the warmth and kindness and good vibes!
- alecbz 5y agoWow, you must be a miserable, wretched, shell of a person to possibly write something like this. It’s really sad no one ever taught you manners. Hopefully one day you learn to be happy and a better person like me. ^ this is not much better tone-wise
- maxpert 5y agoGoes to show how "red buttons" won't make a difference when it comes down to screwing up.
- thayne 5y agoThis isn't the only case where Github deletes more than one would hope. If you require 2fa for an organization, instead of simply locking out users that don't have 2fa enabled until they enable it, it removes them from the organization, and you have to re-invite them to add them back. Fortunately, it does seem to remember the groups and permissions they had when you add them back ... sometimes.
- steve_adams_86 5y agoApart from it being clear that the UI and the user using it could have been better, I don’t agree with criticism like “GitHub should obviously do x” or “this would be easily resolved if the action didn’t caused cascading deletes” and so on. GitHub is a large and complex set of applications, and making changes like that is probably not trivial. It’s probably not a high priority either. This is the first time I’ve heard of this in the existence of GitHub, and while that doesn’t mean it has only happened once, I suspect it’s rarely a meaningful issue. Solving problems like this at GitHub’s scale is often hard both due to the need to do things that matter more, and due to how entrenched database schemas and application architectures tend to be. I’m sure their migrations are plenty scary to manage, and doing it to alter behaviour when toggling privacy on a repository understandably wouldn’t be high on their list of reasons to perform one. Aside from those concerns, I bet there are a lot of lines of code which assume stars exist for specific reasons. Once they can exist for another reason, you have to rewrite logic around that, rewrite tests for that logic, etc. It could easily be way more work than it seems at a glance.
- njsubedi 5y agoBut.. one of their developers also made the same mistake as the OP. The OP learned a lesson but seemingly anyone at GitHub didn’t think, “we should fix this confirmation dialog so this doesn’t happen again”.
- steve_adams_86 5y agoIt’s also possible that they did consider it, but upon investigation it entailed more work than they could justify. I do think including more context about what will be destroyed by the action would be great, and probably pragmatic, but… If typing out the name of the repository isn’t enough, providing context might not be either. The more I think about it, the more it seems like one of those “Whatever, we’ve got a million other things to do” situations. It might get a handful of inquiries about it per year while a dozen other features get hammered with attention and requests from paying customers. Again, not saying they can’t improve it. Just giving them the benefit of the doubt here and proposing that it’s possible that it isn’t better for legitimate reasons.
- bawolff 5y agoGithub stars are such a weird metric/thing. There are a lot of reasons i write open source code, but randoms on the internet who might not have even have used your project "liking" it, is not one of them. That's not to say recognition isn't a motivator, it is. Github stars just seem like a really poor proxy for recognition.
- jdorfman 5y agoDevRel 101. If a project had 54k stars and they obviously made a mistake why take the chance of them writing a blog post and having it hit the front page on HN? If Nat was still CEO this wouldn't have been a thing.
- julianlam 5y agoI sometimes wish those developers who have a lapse in sanity (left-pad, faker.js, etc.) would just do this to their most popular repos instead of poisoning the software supply chain.
- mc4ndr3 5y agoWhat are some of the benefits of HTTPie over classic wget and cURL? Does HTTPie support WebSockets?
- whoisthemachine 5y agoI agree with the author on most of their points, but I wonder if this is an argument for self-hosting your repository(ies) once your project reaches a critical-mass?
- yellowapple 5y ago30 minutes seems like a weirdly long time to delete 54,000 rows; doing something in SQLite like CREATE TABLE stars (id INTEGER PRIMARY KEY, user TEXT, repo TEXT); INSERT INTO stars SELECT value AS id, 'User ' || value AS user, 'foo' AS repo FROM generate_series(0,53999); SELECT * FROM stars; DELETE FROM stars WHERE repo = 'foo'; is just about instantaneous. I'm sure GitHub's schema is more complicated than that, but it can't be that much more complicated, right? Are there a bunch of tables referencing the actual GitHub stars themselves as foreign key constraints or something? Or a bunch of triggers on update/delete? It also seems weird that it would be necessary to delete those rows at all; yeah, having stars for private repos is kinda pointless, but other than taking up space it doesn't seem like it'd do much harm, either. If the space taken up is really that much of a concern, then a periodic cleanup job along the lines of DELETE stars FROM stars JOIN repos ON stars.repo_id = repos.id WHERE repos.visibility = 'private'; seems more sensible than just immediately deleting everything (and insisting on that deletion having finished before allowing another visibility change).
- anonfunction 5y agoGitHub doesn't use foreign keys[1], and there's likely many tables related to all the users, notifications, permissions, etc... that would need to be cleaned up. Without foreign keys they likely have some system process that does this instead of a simple `DELETE FROM` which cascades. 1. https://github.com/github/gh-ost/issues/331#issuecomment-266027731 https://github.com/github/gh-ost/issues/331#issuecomment-266...
- pingsl 5y agoThis is horrible -_-!!! But I wonder what would happen to GitHub Discussions in this situation? I now 100% feel necessary to build a Discord channel for OSS projects.
- agluszak 5y agoPlease don't use discord, use gitter or something else which itself is open source
- adenozine 5y agoAre y’all out here really stressing over GitHub stars? What in the world… Write some unit tests, put a benchmark together, show me example commands to get started, ANYTHING substantial will mean much more to potential new users than seeing how many GitHub stars you have. Just my two cents, I think this is WAY off the mark.
- danielyaa5 5y agoIt resets watchers also and people subscribed to issues. That negatively impacts the project
- adenozine 5y agoAh, I didn’t know that. Well! I’m the fool, it seems. That actually sounds terrible and rather substantial. You’d think there’d be an Undo for that.
- redocecin 5y agoGood lessons learned, thanks for sharing!
- throwaway0x7E6 5y ago>There’s a confirmation box. It’s designed to stop users in a situation like mine from doing something stupid. It tells you that “You will permanently lose all stars and watchers of this repository.” That’s pretty scary. >The problem is that the box looks exactly the same for repos with no commits and stars and for repos with a decade-long history and 55k stargazers and watchers. And it says “Warning: this is a potentially destructive action.” >To paraphrase, the box tells you “You’re about to demolish a house. If there are any people inside, they will all die”. >But it doesn’t include anything specific to break you out of your auto-pilot mode if you’ve confused the address and think you’re looking at an empty house. just admit that you fucked up and don't look for someone else to blame. people would respect you more for it
- 8note 5y agoAdmiring that you screwed up is one thing, but action items coming out of it should prevent somebody else from screwing up in a similar way. One typical way is to add a confusing confirmation box, where saying yes leaves things as is, but "I want to demolish the house" is in a different location that the typical yes/no buttons
- chociej 5y agoThey admitted exactly what they did. This experience is still really bad UX IMO.
- aerovistae 5y agoThey did admit they fucked up. Then they tried to make the best of it by looking for possible ways of preventing other people from repeating their mistake. What did you want? A blog post that says "I suck, I'm a failure, thanks for reading"? Why is this your response to someone trying to be contructive while post-morteming a failure?
- throwaway0x7E6 5y agothe guy with 10+ experience of using github went to the "danger zone", pressed the red button, saw the very, very, very explicit warning about the consequences of pressing it and confirmed the action by explicitly typing the exact name of the repository. yes, that blog post would've been apt. as constructive as it gets. >Why is this your response because I don't want to send a notarized request every time I need to delete a folder, format a disk or submit a SQL query
- krick 5y ago> The tone of our decade-long mutually-beneficial relationship is set by GitHub’s Terms of Service. Thinking there was more to it was naive. I really want to support that kind of sentiment. In fact, I want to support it every time I get a chance. That's just how I am. I enjoy people hating on Microsoft and such. I may even provoke it when it's not entirely justified. But to be fair, making a twitter post about "some random project we host fucked up a bit, let's help them to get followers back" does seem to qualify as something "more to it". I'm pretty sure they weren't legally obliged to do that as well. And I'm pretty sure ads on github's official twitter aren't cheap either. (But I do find that "not legally obliged" tone extremely insulting in any kind of relationships too. I myself also tend to get all "oh, so that's how you want to talk?" over that. I guess, I hate lawyers as much as I hate Microsoft. After all, they are essentially the same thing.)
- bilkow 5y agoI find it ironic that some people are blaming the author so bad given that Github has made the same mistake in the past and had to restore it from the backup, making it clear that the UX could be better. I get it, we should all be very cautious when doing destructive actions, but it's also specially easy to be confused by github's repository naming conventions and you're not seeing the actual repository you're making private, just it's name.
- lfnoise 5y agoI find it ironic that you can't reverse a mistake on a site dedicated to a software that is all about reversing mistakes.
- jfmc 5y agoIn a few years you'll be able to buy GitHub stars as NFT.
- mihaifm 5y ago> We even offered GitHub financial compensation for any resources required What? Can anyone explain this? Are people so desperate about github stars these days that they’re willing to pay Microsoft for them?
- brentis 5y agoCame here to hopefully see GitHub came to the rescue through a friend of a friend on HN.. Unfortunately....not
- mproud 5y agoI dunno. You made a mistake, that’s on you. It’s so easy to say you want more hand-holding, and sure, maybe that’s not a bad idea in a sense, but you still made the mistake. I do appreciate they aren’t yelling and complaining about it, however.
- kgeist 5y agoReminds me of our own quest to stop users from deleting their entire projects by accident in our product. 1st iteration: delete button with a confirmation box (standard stuff). Users click through the box in autopilot mode and still delete their entire projects. 2nd iteration: someone came up with an idea: confirmation box + an additional checkbox (if it isn't checked, the delete button is disabled). Users still manage to delete projects by accident. When we asked them how that happened (we've set up so many hurdles!), the user says, just like in the article, that they thought they were deleting a different (test) project. 3rd iteration: I suggested showing the number of objects in the project (just like suggested in the article) so that the user knew they aren't deleting a test project. I moved on to a different project since, but the saga probably continues.
- langsoul-com 5y agoDamn, would be interesting to know what the effects of the third iteration is. Would validate/invalidate the authors ui suggestions.
- WA 5y agoSame here. I finally brought accidentally deleting stuff down to zero by having them type the number they get to lose: "You have 55,231 GitHub stars. Please type 55231 if you want to delete them all." But I guess, if you delete repos often enough, this will also become muscle memory. Edit: Just saw the other comment here suggesting the same: https://news.ycombinator.com/item?id=31033996 https://news.ycombinator.com/item?id=31033996
- spixy 5y agoalmost all of my projects have < 5 stars, typing "0" half the time is more dangerous than typing my_name/my_repo.
- manmal 5y agoSo, for projects with 100+ stars, add a wait period of 60 seconds until the delete button can be clicked _after_ the number is typed in. That should allow most users on autopilot to snap out of it, or make drunk users switch to a different tab and forget about it.
- HeavyStorm 5y agoDid I just read a pages-long whining, blaming the tool for the mistake? Sure, github could help Httpie, but that would be unexpected. More than killing your repo because you're not paying attention.
- sorokod 5y agoNone of the "Lessons learned" are of personal nature - unbelievable.
- terrymunro 5y agoI know, I'm seething at how many people are supporting this person. I would be on his side too if he started with accepting his part in this and took responsibility but he clearly blames GitHub for everything and learned nothing from this. Such arrogance, let's see if HTTPie will have a nice warning every time you try to do a http delete command. I've done something similar to this and took responsibility. I accidentally deleted an Azure Resource Group with the CLI tool. It just says "Are you sure you want to do this? Y/n" Doesn't even tell you what you're deleting. Oh whoops all the resources within that resource group are now irreversibly gone now. My lessons learned was, when doing something potentially dangerous no matter how unimportant you think it is, slow down and take your time. Things such as making a repo private or deleting things are relatively infrequent. It doesn't hurt to take a few minutes to carefully check all the variables before doing anything. You aren't losing much time in the grand scheme of things. Now he's definitely lost more time. Was it worth the few seconds you would have saved if you were on the right thing?
- sorokod 5y agoYour comment about HTTPie DELETE (or any other verb that changes the system state) points at the exact problem: what is the right balance between giving the user the power and preventing the user from shooting themselves in the foot. For example, should "my brain switched to auto-pilot mode" be seriously considered as a risk to be mitigated?
- bradgessler 5y agoI see a lot of folks talking about better warnings, etc. Something else to consider for situations like this (or maybe for your apps) is to use the element of time to prevent mistakes. For example, when a user wants to permanently delete an account or do any action that’s destructive, irreversible, or catastrophic… queue up a job for 10 minutes, an hour, or maybe a day, that gives the user time to cancel it if they made a mistake. Out-of-band could be another way to prevent mistakes. “Want to delete your account? We’ll send you a link for you to continue via email”. This would also be cancelable. There’s a lot of ways to deal with potentially irreversible actions outside of “better error messages” or checking the equiv of an “are you sure?” Checkbox.
- roxaaaane 5y agoI really like this post. It shows how we gamify everything including open-source.
- ev0xmusic 5y agoSame story happened to us last December :/ https://www.qovery.com/blog/we-lost-3800-stars-on-github-in-1-click https://www.qovery.com/blog/we-lost-3800-stars-on-github-in-...
- mlatu 5y agoi mean, if they hadnt taken their repo private on accident, i probably wouldnt ever have heard of them.. i never really was interested in what the most watched or starred repos were, but something better than curl? yes please, may i have another?
- jonenst 5y agoI would have had more sympathy for the author if they explained why they care so much about github stars. It's just internet points after all. At the very end, they say "What started as a side project has recently become a company" so if it's all about business, maybe they could have made that more prominent. EDIT: sorry, not meant to be harsh. Hopefully you get what you want and thank you for writing open source software
- lixtra 5y agoThere are also notifications and more. It’s about loosing the community enabled by the social features of github.
- einpoklum 5y agoSomething which annoys me with GitHub is that I don't have the option of setting up a mailing list which people viewing my repository page can opt into, as easily as they can star or opt-in to notifications. I often want to ask my users things, and I simply have no mechanism of doing that. (doesn't have to be a mailing list, that's just the simplest feedback-request mechanism I can think of.)
- auggierose 5y agoThe real problem is: Why are GitHub stars so important if httpie is so great? Because people cannot judge for themselves if something is great or not, they always need proxies. It would be cool if we could somehow fix THAT.
- ranguna 5y agoAny recommendations?
- system2 5y agoHe said "somehow". I think he also believes there isn't an alternative.
- auggierose 5y agoNot really. Money seems to be a universal proxy. I guess we need to acknowledge that 54k GitHub stars has some sort of monetary value (Web3 anyone?), and then it would be obvious that you couldn't just delete it, because who would want to just delete money?
- HigherPlain 5y agoI think people here are underestimating how difficult it is to implement is_deleted in a production system. Literally EVERY query has to be rewritten to reflect the new database schema. If it's not been implemented from the start then you have a considerable re-write, and usually this type of project will not be revenue generating.
- akie 5y agoNot necessarily. In some ORMs you can have scopes that can be used to append common sub-queries or conditions, such as "WHERE is_deleted=0", and some allow you to specify default scopes that should be appended to every database query (unless explicitly switched off). I'm just saying: It doesn't need to be a considerable rewrite, it really depends on how your ORM or data layer is implemented.
- kelahcim 5y agoI feel your pain. I have dropped from 250 to zero for exact same reason ;) The order of magnitude is for sure different, but still, hitting the ground without any warning was a surprise. A workaround here is to: - leave the repo public - move it somewhere else (to private repo) - reinit original repo with empty content - once ready, bring back the old repo to previous remote This way your stars are preserved.
- nonameking2026 5y agoGithub should really just do the right thing.
- pbhjpbhj 5y ago>"The same goes for stars. If you’re one of those 54K people who’ve starred the repo any time in the past decade, the repo is no longer among your starred projects." // This seems like bad design from a UX perspective. Projects I star are a characteristic of my account. If a project is made private, I still want to have the star in my account list; it feels almost like gaslighting to just remove a star.
- hk__2 5y ago> If a project is made private, I still want to have the star in my account list You can’t star a private project, so by definition you can’t "keep" a star on a project that went from public to private. That’s not bad design, that’s a logical behavior.
- pbhjpbhj 5y ago>so by definition you can’t "keep" a star on a project // That doesn't seem to follow. It's not intrinsic, it's a design choice, surely.
- forgotpwd16 5y ago>Projects I star are a characteristic of my account. What about deleted repos? Should those be maintained as well?
- pbhjpbhj 5y agoI wasn't thinking the repo would be maintained beyond the title (and short description, maybe whole readme?) being in a list of starred repos, and maybe having something like "[now private]" or "[removed]" added. If I know I starred a repo and then go back to it and it's no longer accessible, I want to see that I'm not going mad and have some information about why the repo is no longer accessible.
- forgotpwd16 5y agoI've a feeling the author blames GitHub for this. It makes sense to be angry about it but don't see how it's GitHub's problem that you autopilot destructive actions. Although agree that the UI could be improved.
- GettoiBoise 5y agoThis is giving me a really great idea for a tool that saves past states and allows for clean reversals of said mistakes.
- yu-carm-kror 5y agoI’ll admit I didn’t read the whole thing but this sound like hyperbole > And GitHub cascade-deleted our community that took 10 years to build. How does losing stars equate to losing the community? Won’t actual fans be right back using and contributing? If you remove a contributor of a private github repo it deletes their remote fork and all of their remote branches. To me that’s real loss.
- Cthulhu_ 5y ago> Won’t actual fans be right back using and contributing? Yes, but if "actual" fans are <1% of your existing user base then your reach and ranking is still far below what it used to be. I'm sure most people on GH don't even remember what repos they've starred, and httpie may be one of just thousands, of which many will disappear from their starred repos overnight without them even noticing.
- barrucadu 5y agoIf a user didn't care enough about the project to even remember that they starred it, why is that star being lost a problem? It was already the case that nobody was getting any value out of it.
- davedx 5y agoContrarian opinion here. While things can always be better the Github UX is good enough here. I am reminded of an old phrase: “A bad workman always blames his tools.” At some point you just need to accept responsibility for your actions and stop blaming others.
- hutzlibu 5y ago“A bad workman always blames his tools.” It is a workman, who builds a very succesful tool for others. Not a bad workman by my definition. And his suggestions of improving the UI sound very solid. Also I am not sure, if you got the part, where he pointed out, that Github themself made the same misstake for one if their repos. Sure, sure, all bad workman.
- matsemann 5y ago> “A bad workman always blames his tools.” That's a meaningless statement, though, as it can always be used against anyone complaining about something. I mean, you yourself wrote this the other day: > I had to work with SAP Hybris a year or two ago. My IDE was not smart enough. Well actually I spent a good number of days trying to configure my IDE to be able to work properly with Hybris. I failed. What a mess Are you a bad workman blaming your tools? Or do some tools just genuinely have faults?
- FeepingCreature 5y agoGood workmen also blame their tools. Because sometimes tools are bad, and that's how they get improved.
- lucideer 5y agoThere's so much focus on the UX here to alert you to a destructive action, but I haven't seen anyone mention this: why does Github even delete stars, and why on earth is it permanent? It seems like a temporary UX hack put in place because some tricky implementation detail handling stars on private repos. Like they said "we'll fix that later" and then the warning message stayed. In a well designed system, making a repo public/private would be a switch where full state is retained back and forth. I mean, it's kinda hypothetical but stars aren't even completely useless in a private repo (for a sufficiently large set of users with access). I'd go further and say that even the UX around the destructive act of deleting a repo shouldn't be necessary: that seems undo-able. Overwriting would still need a warning (creating a repo in a namespace that previously contained data) as would anything involving losing access (deleting an org, freeing it up to the community at large), but not needing it for repo deletion-a relatively common action-would go a long way toward reducing "autopilot".
- prtkgpt 5y agoI would love to help rebuild the community.
- mcs_ 5y agoHi team, You got my star back. Good luck.