6 ms·
Microsoft WinObjC: Restore original licenses
- mikeash 11y agoThere's been a brewing controversy on Twitter and GitHub today about missing/changed licenses on some of the code that Microsoft incorporated into their WinObjC release from yesterday. This GitHub issue seems to be the best summary of what's going on so far. The quick summary of the summary is that there are a bunch of files released under BSD/MIT-style licenses where Microsoft removed attribution, some files which are GPLd or even more restrictive, and at least one file which is not under an open source license at all. Full disclosure: some of my code is in there, so I'm not an unbiased source.
- mmastrac 11y agoThis is pretty common in proprietary corporate code, but surprising to see in a project that seemed destined to be open-sourced. For code that doesn't see the light of day other than in binary form, I've seen people cut-and-paste whatever they can find into a source base and then move on without a second thought. I would expect better of Microsoft -- especially from a company that supported Oracle when suing Google over Android's copying of an API (which included an incidentally small number of actually-copied source). [1] [1] http://www.infoworld.com/article/2613305/patents/microsoft--emc--netapp-join-oracle-s-legal-fight-against-google-on-java.html http://www.infoworld.com/article/2613305/patents/microsoft--...
- emn13 11y agoReading the thread, there seems to have been an automated translator involved that looks like it did not retain comments.
- teacup50 11y agoThe scrubbed copyrights are bad enough, but can be fixed. The incompatible licenses mean that this code is actually unusable. I have no idea how MS is going to rectify this.
- AlexeyBrin 11y agoFor the incompatible licenses, Microsoft can: 1. Buy the rights from the original owners (if you are the owner, you can re - license your code under a different license). 2. MS can reimplement from scratch the problematic pieces of code. 3. MS can hire someone to write these missing pieces for them.
- Klathmon 11y agoHow does relicensing work? If I'm the writer of a GPL'd piece of software can I just decide to make it MIT one day? What happens if I die tomorrow, could that code still be relicensed eventually? What happens when there is no clear owner?
- 0x0 11y agoI think the general consensus is that if you authored 100% of the code yourself, you could always change the license (but people could fork the latest version under the old license and keep going, as happened with X.org), but it you ever took any patches/pull requests/contributions without also receiving a copyright assignment, you need to hunt down every single contributor to agree to a license change. I think that happened with Mozilla and VLC, whilst for Linux it would appear that several core contributors have explicitly refused to re-license (for example to change from GPL2only to GPL2+). Other examples include MySQL, which was dual-licensed GPL and commercial, and KDE/Qt which also had a dual-licensing (and then a re-licensing). If all contributors also accept to transfer copyright/ownership up-front, re-licensing is easier. I'm guessing re-licensing after death would require waiting whatever period (70+ years?) for copyright to expire.
- mikeash 11y agoYes, as long as you retain the copyright of the code you wrote (i.e. didn't explicitly assign it to someone else, or write it as a work for hire) then you can relicense it under whatever you wish at any time. You could make it available under GPL, CDDL, MIT, and the Beerware license all at once. This stuff is relatively simple at its core. Copyright says, "You may not redistribute this work without permission from the copyright holder." An open source license says, "I grant you permission to redistribute this work, as long as you follow these conditions." Relicensing is just a matter of making another statement like that with different conditions. If you die tomorrow, then the copyright transfers to your heirs, who could then do all the stuff you used to be able to do. If there's no clear owner, then life becomes interesting. If there once was a clear owner who released the stuff with a license, that license is still valid, but relicensing isn't possible unless someone can demonstrate that they're the owner. If there was never a clear owner then you can't really use the stuff, although if you're brave you could proceed under the theory that if nobody claims ownership there is nobody to sue you.
- scott_karana 11y agoThis seems like a reasonable response: s5msft commented 3 hours ago @cjwl We're on it and definitely want to make this right. As a bit of background, (some of) our source code was originally C++ based (marked up to act like Objective-C). We then ran that source through a tool to generate "real" Objective-C code. In any case, we're going through Foundation right now and will absolutely make this right. They seem pretty serious about me, and honestly, their acknowledged mistake is pretty understandable. They also have loads of money that people could sue them for, so I'm sure they don't want to risk themselves either.
- teacup50 11y agoIt's just not that simple: the source attribution for the entire code base is in question. Of the licensing that is known, the licenses are known incompatible and the result is non-distributable. They also got the copyright headers wrong when trying to fix Cocotron's stripped copyrights: https://github.com/Microsoft/WinObjC/issues/35#issuecomment-128802309 https://github.com/Microsoft/WinObjC/issues/35#issuecomment-...
- ecobiker 11y ago>> Someone at Microsoft needs to go back to the first commit and track down every bit of code that was taken, and investigate the origin of the code, and properly restore the copyright notices. It is specifically to avoid these issues that most companies don't go through the trouble of open-sourcing their code. Not at all saying it's wrong to enforce licenses I'm just pointing out the obvious that companies that don't want to get into legal trouble avoid the issue altogether and discourage open source. A well known company I used to work for requires legal to sign-off anything that has to be open-sourced. A startup I currently work-off had to be audited for license compliance before a round of funding. One primary reason I see is that most engineers don't understand licensing very well. They don't understand when it's safe to use GPL and when it's not.
- bargl 11y agoEven though Microsoft has had some issues like this, I'm glad they are open sourcing their code. It's a huge risk for a company like them, but I'd take a poorly open sourced codebase, where they can fix the problems over closed source. Hopefully they'll learn and get better at it as they go along. I really hope they don't get deterred from open sourcing their code and stop the current trend.
- smackfu 11y agoAnd license auditing is usually just a matter of grepping for license blocks or LICENSE files. Basic due diligence. It will not catch a case where someone takes one file and strips off the license header.
- WalterBright 11y agoAt D one huge reason we use github is to establish an audit trail of where code that gets incorporated comes from, which: 1. discourages people from committing code that isn't theirs 2. if there is bad code committed, we can determine the extent of it and so take corrective action 3. it's a great defense against false claims of bad code
- JoshTriplett 11y agoA similar requirement would apply to misappropriated third-party proprietary code. If you're copying code from elsewhere, document where you got it from, and preserve all licenses. Don't delete copyright notices and license headers, ever. That's neither ridiculously complicated nor burdensome. Complying with other license conditions is another matter, and that's why many companies have people or groups whose primary job is to understand and deal with those kinds of issues. But basic due diligence about copyright and license headers needs to be fundamental 101-level understanding.
- DannyBee 11y agoSpeaking as someone whose job it is to make sure these issues don't happen at a similar large company: No org can be 100% perfect all of the time, no matter what processes they put in place. This looks like just a regular process failure. I don't know what MS's are specifically, but we do everything from training new employees to verifying headers on outgoing releases (much to the annoyance of plenty of engineers who just want to release shit). I suspect they do the same. Replacing headers with a standard header is pretty common. However, we require code segregation to prevent the issue that happened here (IE all third party codes goes in third party directories with an associating LICENSE file describing the license/notices). That makes it easy to tell that someone screwed up when replacing headers. Doing that is uncommon for most companies in practice (at least, when i surveyed my counterparts, most want to be doing it, but it doesn't really happen in practice with a > 50% rate due to not being closely involved enough with engineering and development practices to make it easy). Most of them are happy to mix up third party code with their own code, or really bad at enforcing, and then when you go to release it, you don't notice things like what happened here. Then again, we also tell new employees that we care about getting the notices and credits right not because we are worried about legal repercussions, but because of the golden rule (you'd be pissed if you ask for one small thing to use you code, and they can't be bothered to do it, and we don't want other people to feel that way about us). I suspect that is pretty different too :) But this seems like an object lesson in proving that. The people whose headers were changed feel aggrieved regardless of the fact that it was probably a simple process screwup / whatever. They don't care about that. They care that somebody decided they really wanted to use it, and that it saved them time/energy/helped/whatever, but despite that, when they made the choice to use it, they didn't seem to bother to put the one small thing the author asked of them on "the list of things to do before release" (Regardless of whether this is actually the case).
- randomfool 11y agoWhen I had to go through this at Microsoft 5 years ago or so, the process was incredibly rigorous. Not only did we have to attest that all of our code was actually ours, but any duly integrated third-party code had to be vetted by a separate group to check that the third-party code contained no IP issues of it's own. The process was incredibly cumbersome and I'm somewhat glad they've scaled back a bit, but this is much too far.
- geofft 11y agoI like the dude who thinks that the GPL hasn't been proven valid in a US court and that migueldeicaza has trouble getting a job in the industry.
- cannam 11y agoit's quite irrelevant, but I was about to post the same -- the idea of Miguel "becoming unemployable" as a result of this is just delightful.
- geofft 11y agoYeah. Ironically, what would actually make me hesitate to hire someone is seeing them post on a public issue tracker that they believe the GPL is unenforceable and that blatantly violating it is a good idea. Leaving aside their critical thinking abilities, soft skills, etc. it's a serious risk of legal liability to have such a person write code for my company.
- mikeash 11y agoIndeed. They seem eager for Microsoft to intentionally violate the GPL in order to create a court case which they believe would result in invalidating the GPL. Who's to say they wouldn't see an opportunity for causing this to happen by incorporating GPL into whatever project they're working on at their job?
- CHY872 11y agoI hope that some day I may join him too at 'Unemployable Island'
- cannam 11y agoyou wish! they don't hire just anyone, at 'Unemployable Island'
- MTWomg 11y agoThe idea of Miguel getting a job outside of the open sores bubble is also delightful. Maybe mopping floors?
- cmarschner 11y agoMicrosoft is very serious about OS licenses, and I'm sure the team is currently sweating to get this right. Before Nadella, it was very difficult to get a permit to use OSS at all; With the new culture, openness (giving and taking) is encouraged, but some teams might have taken it too lightly. It's a learning process.
- fithisux 11y agoI hope they make it compilable with clang + mingw headers.
- deleted 11y ago[deleted]
- cannam 11y agoI think the problem is that it takes additional work to figure out what needs to be fixed (especially since the company that has reused your code might be trying to obscure the fact). It's not reasonable to expect the original author to do that work, on behalf of a party that appears to be infringing on their licence. Even if you want MS to get this fixed and make a success of it (as I very much do) it's clearly their responsibility to figure out the correct licensing.
- deleted 11y ago[deleted]
- cannam 11y agoThe author has done enough to show that something was copied. They could just point to that, and insist that redistribution stops now. Instead they are giving MS the opportunity to fix it, but it's not in any way the original author's responsibility to do it for them.
- corysama 11y agoWhat is proper procedure for open-source mashups? Setting aside GPL, if I have a project that lifts a single function each from separate projects that are individually zlib, mit, bsd, apache, mozilla, eclipse and boost. What do I do? Put a license url annotation on each function? What license can my project as a whole be?
- JoshTriplett 11y agoDocument the licenses for each, and include all the copyright notices and license headers, exactly as they appeared at the top of the files you took those functions from. The resulting file is under the conjunction of all of those licenses, requiring anyone who uses it to comply with all of them simultaneously. That's theoretically possible when the licenses don't conflict.
- finishingmove 11y agoOh no. First time I see something like this. Why can't Microsoft be like the good-guy companies, like Google (and Apple)?
- merb 11y agoI Love open source, but I find its really disturbing that some code can't live together when licensed under different open source licenses. Under my Java Code I mostly avoid unnecessary Libraries altogether. That's the reason why I mostly Build my stuff with akka and undertow and postgresql jdbc only (and the jdbc stuff gets replaced as soon as my library async postgres driver does what I need) so that I only have Apache 2 Code (and some parts BSD which will be replaced). Everything else is just too odd. And if I or any other people below me pulls a library in that isn't APL2 i will refuse the PR. It just sucks how aweful it is to write programs with awesome licenses that are incompatible. But you just want to use existing things, which you can't do cause people are dumb and doesn't write licenses which are happy together. I mean why can't I write GPLv3 Code and pull other Open Source licensed things, too? It's still Open. And that's the problem the Open in Open Source mostly isn't open. I see the source, but I can't do anything with it.