4 ms·
> it produces some extremely crappy code that would've NEVER passed a code review 1 year ago The 10x speed up comes from the fact that we have all given up on
by serial_dev 2mo ago
> it produces some extremely crappy code that would've NEVER passed a code review 1 year ago
The 10x speed up comes from the fact that we have all given up on properly reviewing each others code and we just say “meh, it will be fine, lgtm”
- QwenGlazer9000 2mo agoThis. The bar has never been lower.
- altern8 2mo agoYes, exactly my point. BUT, to me if we hadn't lowered the bar MASSIVELY, it would NOT be fine. I've seen people at my work that will push or even deploy features that don't do what their main purpose is and they just dismiss the issue saying it's a bug. As an example, a button that's supposed to open a modal window if you click on it. If you go test it and the modal doesn't open, they'll say "oh, there's a bug". You developed or even deployed something that is wrong and completely useless. Just one year ago, this would be unheard of and you would've gotten a really hard time for it. Now it's just a bug and part of how we're doing things. Like I said, I just do what I'm told at work but to me this is just wild. There's no way it won't come back to bite us.
- dools 2mo agoCode review has always been pointless
- metalspot 2mo ago[dead]
- zhoujianfu 2mo agoI’m glad somebody said it!
- SkyPuncher 2mo agoI realize this like a decade ago. Security is basically the only thing I care about in code review. I’ve come to realize that I don’t actually care what your code looks like. I’m going to need to learn it from scratch every time I use it. It’s going to look weird and foreign to me no matter what. It’s not worth my time nit-picking things that simply do not matter.