3 ms·
This is bizarre over engineering: https://github.com/goldmansachs/gs-quant/blob/51a7ff1afb722cff5dc8b3122d50b0bb6ef06cc8/gs_quant/timeseries/algebra.py#L330 ht
by conformist 2y ago
This is bizarre over engineering:
https://github.com/goldmansachs/gs-quant/blob/51a7ff1afb722cff5dc8b3122d50b0bb6ef06cc8/gs_quant/timeseries/algebra.py#L330 https://github.com/goldmansachs/gs-quant/blob/51a7ff1afb722c...
- heyoni 2y agoThe pointless act of "encapsulating" nothing? I see that a lot unfortunately =[
- IshKebab 2y agoPresumably @plot_function does something. Also there are lots of other functions in the same API that are more than one line. I suspect he wouldn't have thought it was over engineering if it didn't have such a long comment for one line of code... Which is silly.
- sonthonax 2y ago[flagged]
- conformist 2y agoI’m a trader
- sonthonax 2y agoSurely you've worked with other traders who get confused by import statements. Whole point of this file is to provide a common interface for common math operations that might be exposed by either plain python or pandas/numpy functions. You're obviously not the target market if you're able to review good and bad code.
- whiplash451 2y agoThat was unnecessarily mean. What did you mean?
- nixpulvis 2y agoWhat about the @plot_function bit? Also, wrapping dependency calls for a more consistent interface isn’t necessarily a bad thing.
- sk11001 2y agoDoes someone have LOC as a performance indicator?
- ng12 2y agoUnironically probably. The only place I've ever worked that used LoC as a performance indicator was a hedge fund.
- deleted 2y ago[deleted]
- wepple 2y agoIt’s so bizarre my first reaction was that surely it must be so an LLM can make some kind of sense of it, otherwise what on earth are they doing?