3 ms·

> Instead, adjust the asserts such that they lock down the current (wrong) behavior, and add a clear // TODO: comment explaining what would be the correct resul

by Aeolun 3y ago

> Instead, adjust the asserts such that they lock down the current (wrong) behavior, and add a clear // TODO: comment explaining what would be the correct result. This prevents such tests from rotting and also catches cases where the behavior is fixed by an unrelated change. Yuck! Tests asserting wrong behavior?! Then you might as well not have the thing. Just remove it entirely.

IshKebab 3y ago
Not a good idea. He explained why in the bit you quoted.
- Aeolun 3y ago
  Yeah, but I disagree with his reasoning. Tests should either confirm correct behavior, or not exist at all. Confirming bad behavior is just a way to give everyone ‘make work’.