3 ms·
I'm a nobody, but surprises me that the revert (and so the original feature) didn't include any tests. I always imagined that a project like curl (no deadlines?
by danwee 4y ago
I'm a nobody, but surprises me that the revert (and so the original feature) didn't include any tests. I always imagined that a project like curl (no deadlines? no pressure? no bosses?) would lead to people to work on it at their own pace (so more tests maybe? Maybe not, I don't know)
- shawabawa3 4y agoIt was a performance optimisation, so I suppose it should be covered by existing tests as there should be no change in behaviour
- danwee 4y agoAh, good point!
- withinboredom 4y agoThis looks like an integration point, which are pointless to test.
- e12e 4y agoIt did in-fact have test coverage, from tfa: > Apart form the little bug that caused it to crash in several test cases. (...) > Exactly why this was not discovered in our tests and CI jobs before the release we have yet to figure out, but it is certainly more than just a little disturbing.