9 ms·
VS Code was lost on shutdown with pending update (2018)
- stevehawk 7y agoMaybe it's an A/B deployment where they want to see if we're more productive without VS Code? ;-)
- zelphirkalt 7y agoOr a new form of telemetry, where they want to collect life signs of people, who need to redownload or post a comment in the issue.
- illuminated 7y agoSchrödinger's editor: it is there and it isn't.
- godzillabrennus 7y agoI consider it a win when my IDE only deletes itself and doesn’t format my hard drive in the process.
- klysm 7y agoDid this happen?
- ht85 7y agohttps://github.com/ValveSoftware/steam-for-linux/issues/3671 https://github.com/ValveSoftware/steam-for-linux/issues/3671
- AbraKdabra 7y agoI'd instantly sue the fuck out of the company to bankruptcy if that happens to me.
- gpm 7y agoIf this bug would cause you any significant damages whatsoever, you're doing it wrong. Hard disks fail all the time. This bug is quite analogous to a harddisk failing. Backup everything that matters. Even if you did somehow manage to lose enough money that the damages could bankrupt Valve (or even pay for your lawyer), I doubt you would win. Basically all software these days disclaims all warranties. This wasn't malicious or particularly out of the ordinary for this industry.
- klohto 7y agoOn what grounds exactly?
- pjc50 7y agoUnfortunately, they'd point to the EULA and you'd lose.
- pjc50 7y agoThere have been a couple of incidents of self-destructing installers, yes. "rm -rf /${VARIABLE}" where the variable isn't set, that kind of thing.
- zouhair 7y agoI am against the death penalty, but I'll make an exception for anyone who write that code.
- skohan 7y agoWasn't it something similar with a chrome auto-update which bricked a bunch of $10k+ mac pro workstations in hollywood?
- CodesInChaos 7y agoThat one doesn't work on systems which disallow deleting `/` unless you pass `--no-preserve-root`. But `rm -rf `${VARIABLE}/*` still does, and that's what steam did.
- klysm 7y agoSeems like --no-preserve-root is poorly implemented if that is allowed.
- oefrha 7y agoAt least 20% of my grief while using Windows stems from not being able to remove or replace open files.
- Kye 7y agoSometimes Windows will release a stuck file if you kill explorer and restart it from task manager. I found it mostly happens while working with files in a program while the folder is open in explorer.
- SketchySeaBeast 7y agoAs a native windows user I don't really understand this grief - if the file is open we're kind of assuming we need it, aren't we? What happens if the system tries to read the file on disc and it's been replaced or removed? Why shouldn't that end in an earth-shattering kaboom? Isn't the problem actually not being able to effectively close it to then replace it?
- kevin_thibedeau 7y agoThis was solved in Unix land 50 years ago. Unlinked handles remain usable until the process releases them but the filesystem isn't held hostage. Doesn't require hunt the process to find out who has a file open. The OS can update itself live without a reboot.
- pjc50 7y agoThere are three kinds of semantics for non-collaborating programs that people want from files that are completely incompatible: - update immediately(ish) seen by other users of the file (e.g. database); the default UNIX semantics, even for executables - update seen by other users at the next point they open the file (what you want for update-without reboot, can be achieved on UNIX because deleted inodes hang around) - it's completely impossible for other users to write, rename etc the file (Windows default)
- SketchySeaBeast 7y agoThanks! I guess each come with their own tradeoffs - immediate updates have a good chance of blowing away the current users work as well as continually searching for file updates, and a versioning system then needs to figure out what to do when the user saves a stale file.
- nn3 7y agoWish more software would do that. Often we don't need it after all.
- dschuetz 7y agoYou're using VS Code instead of Open Source IDEs? No sympathy whatsoever. None.
- BMorearty 7y agoWhat a rude thing to say.
- darrenkopp 7y agoVS Code is an open source IDE
- AndriyKunitsyn 7y agoVS Codium is an open source IDE. Binaries of VS Code, distributed by Microsoft, contain additions with telemetry and god knows what else, so for all intents and purposes, they should not be considered open source.
- efdee 7y ago[citation needed] Telemetry is plainly visible in the VS Code source: https://github.com/microsoft/vscode/tree/8ffcb49f4fbeb2504050726990452c1bb5b129fd/src/vs/platform/telemetry https://github.com/microsoft/vscode/tree/8ffcb49f4fbeb250405...
- darrenkopp 7y agoThat's a good point, additional items could be included, though the installer code seems to be included in the source code: https://github.com/microsoft/vscode/blob/master/build/win32/code.iss https://github.com/microsoft/vscode/blob/master/build/win32/...
- darrenkopp 7y agoLooks like gpm commented with more context on this and your comment is likely still more correct than my response: https://news.ycombinator.com/item?id=23019121 https://news.ycombinator.com/item?id=23019121
- skohan 7y agoThis is one of my biggest gripes with VSCode: it's always doing things for me. Like I don't need automatic updates, and I don't need suggestions popping up in the corner about which extensions to install. Clippy didn't die, MS just moved him into the background.
- userbinator 7y agoit's always doing things for me Sadly, the same can be said for a lot of other software these days.
- jtbayly 7y agoAlso, sadly, the same can't be said for a lot of other software these days.
- skohan 7y agoI don't know - I think in 90% of cases I don't need software to be "smart", I want it to do exactly what I tell it and nothing else. After using Linux more as a daily driver lately, all that "convenience" you get with macOS and Windows - the form of automatic updates and notifications - is incredibly distracting.
- jtbayly 7y agoUgh. It was a joke about how often software just doesn't work (do things for you). :|
- solarkraft 7y agoI know this isn't popular on here and it doesn't always apply, but ... ... I actually like it most of the time. Not the annoying update message, but when I open a .rs file I actually do want the plugin for syntax highlighting. VSC makes getting such stuff wonderfully easy.
- 7y ago
- darrenkopp 7y agoWhen I first read this issue, I was assuming the user was losing unsaved code in their editor, which seemed like user error and I thought they had resolved that issue long ago. After reading the comments and reading the summary again, I'm pretty sure that this is actually the background updater has downloaded, detects that code is closed and starts to update automatically, but since the computer is rebooting, it gets killed. The first comment about just checking if shutdown is in progress should work.
- userbinator 7y agoI'd be very curious to know why this would happen now, since VS Code has been around for a while and this would not be the first time people have installed an update for it. The functionality to move/delete files upon reboot has been around for much longer in Windows, and unless there is a bug in that (highly unlikely, but maybe less so these days[1]), I'm perplexed at this failure. [1] https://news.ycombinator.com/item?id=18189139 https://news.ycombinator.com/item?id=18189139
- darrenkopp 7y agoI think it's shutdown of the computer, not shutdown of VS code. The updater starts executing during the shutdown and I'm guessing the system is terminating the install process and it's not rolling back appropriately (or it is rolling back but only after the uninstall has executed)
- jaywalk 7y agoThe GitHub issue was created almost two years ago.
- skohan 7y agoI was always amazed by windows losing my preferences on update. As a software engineer who's worked on front end before I feel like I would have to hand in my union card if I shipped software which did that.
- hprotagonist 7y agoCould be worse: https://github.com/microsoft/vscode/issues/32405 https://github.com/microsoft/vscode/issues/32405 the famous “we changed the names of common git operations, oh boy was that a bad idea” bug.
- krthr 7y ago:( that was so sad
- LeoNatan25 7y agoWeb garbage software with web garbage update antics behaves like a web garbage. Unsurprising, really.
- jsilence 7y agoIf only there were an emacs mode to do that!
- alexeiz 7y agoThis issue has been unfixed for two years, and it's still in the backlog? Wow. Looks like Microsoft prioritization process is really broken.