4 ms·

Can it be helped with a good linter? JavaScript had similar problems as there were more bad things about it than good, but with ESLint and a good config (Airbnb

Can it be helped with a good linter? JavaScript had similar problems as there were more bad things about it than good, but with ESLint and a good config (Airbnb's or other) community evolved and most of the new stuff adheres to best practices by default.

BiteCode_dev 6y ago
But the stack in JS is a terrible burden in itself, and people only accept it because we have no realistic alternative to JS on the most popular plateform in the world: the web browser. PHP doesn't have this accidental monopoly: you can use a language that doesn't require discipline and tooling to make something decent. Bottom line, PHP is better than it used to be. But the technical debt remains, and it's easy to avoid if you can, so we do. I started with PHP, but I have no reason to go back to it. It has no benefit and is worth it only if you have already a massive PHP code base, or a pool of PHP devs you need to employ.
- pavel_lishin 6y ago
  If you know a magical language that can result in excellent code without discipline, I'm all ears.
  - bitexploder 6y ago
    I think the spirit of their argument is that there are plenty of languages with more benefits from an engineering standpoint and fewer downsides. Static typing, cleanser language construction, etc.
  - jerf 6y ago
    I don't know of a magical language that can result in excellent code without discipline. But languages do vary significantly in how hard it is to take non-excellent code written without discipline and safely make it better code. The dynamic scripting languages are on the bottom of that list; all the freedom they enable also simultaneously make that harder. This is probably the best way to understand the increasing push towards static types lately. It isn't so much necessarily the experience of writing the code the first time, where static types may at least sometimes indeed be a bit harder to work with. It's that it's a relatively easy to work with code that takes a list of OrderIDs and CustomerIDs and returns a map of CustomerID -> Order, and calls a function that takes an OrderID and yields an Order, a method that takes an Order and yields a Customer structure, and a method that takes a Customer and yields a CustomerID, and finally constructs exactly the promised structure. You can change it and feel pretty good about what's going on and what's going to happen both to the code it calls and the code that call it. On the other hand, working with code that takes a something and a something and returns a something, calling a function that takes as something and yields a something, another function that yields a something and a something, and a method on one of those somethings that takes a something and yields and something, and then returns something, is harder to work with, before we even talk about the fact that these somethings may have no literal source code existence because there were dynamically assembled, and after the somethings were dynamically assembled, other somethings may have come along and turned those somethings into something else. Obviously, the first case still isn't heavenly and the second case isn't as bad as I make it sound in this brief summary, but there's still a real difference.
marcosdumay 6y ago
There's no linter for hiring candidates. When you announce a PHP position, you are acknowledging that you'll get someone that doesn't care about maintainability, security, and whatever. Candidates will react accordingly. And yes, Javascript has similar problems, but much less severe.
- umanwizard 6y ago
  Facebook has almost certainly the world's largest codebase in any PHP-family language (Hack, which is essentially PHP + gradual typing + a better standard library, but still very much PHP-flavored). The code is fine. Part of the reason is the improvements of Hack over PHP, part of the reason is very aggressive linting (to, e.g., enforce the use of types), and part of it is probably that Facebook doesn't hire for "PHP positions", but for generalist software engineers.
  - eeZah7Ux 6y ago
    Facebook indeed does not have the same hiring bar as "$company php (sweat)shop". However, all the other companies align themselves to the level of the average candidate they can hire. The quality of the library ecosystem in both js and php is a good measure of that level - sadly.
- boarnoah 6y ago
  Anecdotal, but I was involved in technical interviews for a full stack developer position within a team last year. Our stack at the time was transitioning to .NET Core, but the HR posting was some generic one (I believe for a "full-stack dev" with PHP experience). Got a bizarre range of candidates who had got past the inital filtering, all except one whose PHP amounted to wordpress only experience (some who were not able to clearly differentiate between serverside and clientside state or logic). Don't want to tar folks with the same brush, but that experience led me to believe the folks who got filtered through for possessing PHP experience, in this case, were extremely bottom of the barrel.
  - pavel_lishin 6y ago
pavel_lishin 6y ago
> Can it be helped with a good linter? No. But it can be helped with a tech lead/team lead who can kindly but ruthlessly enforce good coding practices. I was lucky to have one of those when I was learning Java, and a lot of the habits they've taught me ended up being pretty universal, and I owe them a great deal of gratitude.
winrid 6y ago
I would not classify Airbnb's linting rules as good in ANY metric for server side code. It has rules designed for frontend, and then people go and use those settings for NodeJS...
- pavel_lishin 6y ago
  Can you expand on this? Why would linting rules, which are almost always strictly about formatting, impact server vs. frontend performance?
  - winrid 6y ago
    One example is they disallow for of loops because they are hard to transpile to es5, but that makes no sense for NodeJS.
dzonga 6y ago
people can laugh at php, all they want. I personally, don't use php, but admire the community. because they, python n ruby dev's are good at shipping software frequently. look at laravel ecosystem. people getting shit done. n contributing i.e tailwind css | ui | alpine.js

BiteCode_dev 6y ago

But the stack in JS is a terrible burden in itself, and people only accept it because we have no realistic alternative to JS on the most popular plateform in the world: the web browser. PHP doesn't have this accidental monopoly: you can use a language that doesn't require discipline and tooling to make something decent. Bottom line, PHP is better than it used to be. But the technical debt remains, and it's easy to avoid if you can, so we do. I started with PHP, but I have no reason to go back to it. It has no benefit and is worth it only if you have already a massive PHP code base, or a pool of PHP devs you need to employ.

pavel_lishin 6y ago
If you know a magical language that can result in excellent code without discipline, I'm all ears.
- bitexploder 6y ago
  I think the spirit of their argument is that there are plenty of languages with more benefits from an engineering standpoint and fewer downsides. Static typing, cleanser language construction, etc.
- jerf 6y ago
  I don't know of a magical language that can result in excellent code without discipline. But languages do vary significantly in how hard it is to take non-excellent code written without discipline and safely make it better code. The dynamic scripting languages are on the bottom of that list; all the freedom they enable also simultaneously make that harder. This is probably the best way to understand the increasing push towards static types lately. It isn't so much necessarily the experience of writing the code the first time, where static types may at least sometimes indeed be a bit harder to work with. It's that it's a relatively easy to work with code that takes a list of OrderIDs and CustomerIDs and returns a map of CustomerID -> Order, and calls a function that takes an OrderID and yields an Order, a method that takes an Order and yields a Customer structure, and a method that takes a Customer and yields a CustomerID, and finally constructs exactly the promised structure. You can change it and feel pretty good about what's going on and what's going to happen both to the code it calls and the code that call it. On the other hand, working with code that takes a something and a something and returns a something, calling a function that takes as something and yields a something, another function that yields a something and a something, and a method on one of those somethings that takes a something and yields and something, and then returns something, is harder to work with, before we even talk about the fact that these somethings may have no literal source code existence because there were dynamically assembled, and after the somethings were dynamically assembled, other somethings may have come along and turned those somethings into something else. Obviously, the first case still isn't heavenly and the second case isn't as bad as I make it sound in this brief summary, but there's still a real difference.

marcosdumay 6y ago

There's no linter for hiring candidates. When you announce a PHP position, you are acknowledging that you'll get someone that doesn't care about maintainability, security, and whatever. Candidates will react accordingly. And yes, Javascript has similar problems, but much less severe.

umanwizard 6y ago
Facebook has almost certainly the world's largest codebase in any PHP-family language (Hack, which is essentially PHP + gradual typing + a better standard library, but still very much PHP-flavored). The code is fine. Part of the reason is the improvements of Hack over PHP, part of the reason is very aggressive linting (to, e.g., enforce the use of types), and part of it is probably that Facebook doesn't hire for "PHP positions", but for generalist software engineers.
- eeZah7Ux 6y ago
  Facebook indeed does not have the same hiring bar as "$company php (sweat)shop". However, all the other companies align themselves to the level of the average candidate they can hire. The quality of the library ecosystem in both js and php is a good measure of that level - sadly.
boarnoah 6y ago
Anecdotal, but I was involved in technical interviews for a full stack developer position within a team last year. Our stack at the time was transitioning to .NET Core, but the HR posting was some generic one (I believe for a "full-stack dev" with PHP experience). Got a bizarre range of candidates who had got past the inital filtering, all except one whose PHP amounted to wordpress only experience (some who were not able to clearly differentiate between serverside and clientside state or logic). Don't want to tar folks with the same brush, but that experience led me to believe the folks who got filtered through for possessing PHP experience, in this case, were extremely bottom of the barrel.
- pavel_lishin 6y ago

pavel_lishin 6y ago

> Can it be helped with a good linter? No. But it can be helped with a tech lead/team lead who can kindly but ruthlessly enforce good coding practices. I was lucky to have one of those when I was learning Java, and a lot of the habits they've taught me ended up being pretty universal, and I owe them a great deal of gratitude.

winrid 6y ago

I would not classify Airbnb's linting rules as good in ANY metric for server side code. It has rules designed for frontend, and then people go and use those settings for NodeJS...

pavel_lishin 6y ago
Can you expand on this? Why would linting rules, which are almost always strictly about formatting, impact server vs. frontend performance?
- winrid 6y ago
  One example is they disallow for of loops because they are hard to transpile to es5, but that makes no sense for NodeJS.

dzonga 6y ago

people can laugh at php, all they want. I personally, don't use php, but admire the community. because they, python n ruby dev's are good at shipping software frequently. look at laravel ecosystem. people getting shit done. n contributing i.e tailwind css | ui | alpine.js