12 ms·
Libc on macOS invokes Perl as a subprocess for string processing (2017)
- josteink 8y agoThat's obviously wrong. It should use Emacs instead.
- protomyth 8y agoI’m actually surprised there isn’t a library called libemacs. It would fulfill the mythos and be really useful for a lot of tools.
- olliej 8y agoBut then companies could use it to assault rms’s Freedom ;)
- coldacid 8y agoAll it would (need to) be is just a ELisp interpreter.
- greggyb 8y agoGuile's VM already supports this.
- gnulinux 8y agoEmacs doesn't do anything in C other than running lisp, emacs really is just a lisp implementation with GUI and text editing focus. libemacs would be just like lua or cpython.
- kazinator 8y agoEmacs has over a quarter million lines of C, which must be there for a reason.
- senozhatsky 8y agoShall somebody send a pull request [0] - /* XXX this is _not_ designed to be fast */ + /* XXX this is _not_ designed to be safe */ [0] https://github.com/Apple-FOSS-Mirror/Libc/blob/2ca2ae74647714acfc18674c3114b1a5d3325d7d/gen/wordexp.c#L192 https://github.com/Apple-FOSS-Mirror/Libc/blob/2ca2ae7464771...
- acura 8y agoIsn't the line bellow that line enough? /* wordexp is also rife with security "challenges",
- senozhatsky 8y agoMy assumption was that those security "challenges" were related to expansion (wordexp()) per se; not to the way wordexp() was implemented in this particular case.
- api 8y ago/* This function computes the expansion rate of spacetime. This version contains an additional factor that causes it to accelerate to allow for rapid testing of other aspects of the physics engine. This MUST be removed before the production release or spacetime will accelerate forever and experience heat death instead of reaching steady state. -God */
- fouronnes3 8y agoPerl doesn't depend on libc?
- detaro 8y agoIt does, but that's "not a problem" as long as it doesn't use this function to implement something that's executed during this function.
- acura 8y agoNot good looking at all but, latest commit to that repo is Updated on Oct 11, 2012. So how well does it reflect reality?
- raimue 8y agoThe official sources are published by Apple on https://opensource.apple.com https://opensource.apple.com This repository is just a snapshot that somebody else prepared and uploaded to GitHub, but apparently it is not maintained.
- fit2rule 8y agoI find it hard to believe that there's any software out there that doesn't, eventually, invoke Perl as a subprocess .. I mean, its Perl.
- leejo 8y agoThat's essentially what the OG tweet is saying: Pinnacle of software development: you can solve the problem with three lines of Perl, but you don’t, because of a non-argument against Perl. Since there didn't used to be that many arguments against perl/Perl it worked its way into a lot of systems even if it wasn't actually implementing the system. Of course Perl, having fallen out of vogue, probably wouldn't be used today but it used to be everywhere so its footprint is still pretty large. Also - I can't help but see the irony in shelling out to perl given experienced Perl developers always tell the less experienced ones to avoid shelling out from Perl if possible and to only do that as a last resort if there isn't an existing library to solve the problem.
- virgilp 8y ago> experienced Perl developers always tell the less experienced ones to avoid shelling out from Perl if possible The reason for that is obvious, right? By induction, shelling out from Perl would only result in the called process shelling back to Perl. So it's much better to just call that Perl code directly.
- rurban 8y agoOnly loud-mouthed inexperienced middle managers tell their juniors to follow NIH and do everything in pure perl. It's pure fear to be broken by changed dependencies. More experienced managers tell their devs to shell out to standard tools like sh, wget, curl, dig, mysqlclient and not use the builtin pure-perl libs. The tools are much better, the code is 10x smaller and faster, and you are getting updates for free (e.g. ssl). Even in C I very often call system("wget http://..." http://...") and avoid libcurl.
- leejo 8y agoOnly loud-mouthed inexperienced middle managers tell their juniors to follow NIH and do everything in pure perl. It's pure fear to be broken by changed dependencies. It's not NIH if you're advocating using CPAN modules or existing libraries. Sure, use the right tool - but don't advocate to juniors a method that can lead to OS command injection because they're not experienced enough to know to, or how to, sanitise their inputs.
- MichaelMoser123 8y agoNow I see why you can't change /usr/bin on macos. actually there is both perl5 and python2.7 in /usr/bin, libc does have a choice (that is if the tweet is true)... https://en.wikipedia.org/wiki/System_Integrity_Protection https://en.wikipedia.org/wiki/System_Integrity_Protection
- olliej 8y agoYou can’t change use/bin because that’s a common malware attack vector. It also has the nice effect of forcing user installed utilities to install in the /local/ variants (which user build projects should be doing on Linux iirc), so an OS update doesn’t overwrite user data.
- tinus_hn 8y agoAlso if it bothers you, you can just turn it off. It's just difficult enough people can't simply put some screenshots on a webpage to work around it because they are too lazy to code properly.
- self_awareness 8y agoSeems it's very old code. New Libc doesn't do this. This is Libc from Mojave: http://xr.anadoxin.org/source/xref/macos-10.14-mojave/Libc-1272.200.26/gen/FreeBSD/wordexp.c#105 http://xr.anadoxin.org/source/xref/macos-10.14-mojave/Libc-1... The 'perl' code was a part of Libc v825.24, which seems to be included between 10.7 (Lion) and 10.8 (Mountain Lion). Of course I still find it hilarious that even the old code did that!
- opencl 8y agoThe current version replaces the perl subprocess with an sh subprocess. Doesn't seem like much of an improvement.
- anyfoo 8y agoWell, wordexp's purpose is literally to "perform shell-style word expansions", as quoted from the man page. It even supports command substitution if you don't pass WRDE_CMDSUB. So really, the entire premise of that POSIX function is horrible[1]. Just like system(), which also explicitly executes the given command line using the shell. These functions are not safe to use with untrusted input (e.g. remotely), ever. EDIT: [1] But arguably only as horrible as calling out to the shell is in general. If you e.g. use it as part of a shell utility that assumes full POSIX-permissioned access to your user anyway, it's not unreasonable because there isn't any privilege escalation at all. Though I'd argue that in the case of system() it's probably more clear to the developer that a shell callout is happening. And also, that the "shell-style" expansion performed here is kinda muddily defined.
- AHTERIX5000 8y agoOTOH the standard itself mentions implementing the function using shell in a subprocess [1]. POSIX is full of nastiness such as this, hopefully not too many maintained & used software actually needs wordexp. [1] https://pubs.opengroup.org/onlinepubs/9699919799/functions/wordexp.html https://pubs.opengroup.org/onlinepubs/9699919799/functions/w...
- panic 8y agoDiscussed in 2015 (the code was out of date even then): https://news.ycombinator.com/item?id=9025572 https://news.ycombinator.com/item?id=9025572
- deleted 8y ago[deleted]
- coldtea 8y agoWell, FreeBSD does it by calling a sh builtin: /* * We are the child; make /bin/sh expand `words'. */ (void)__libc_sigprocmask(SIG_SETMASK, &oldsigblock, NULL); if ((pdes[1] != STDOUT_FILENO ? _dup2(pdes[1], STDOUT_FILENO) : _fcntl(pdes[1], F_SETFD, 0)) < 0) _exit(1); if (_fcntl(pdesw[0], F_SETFD, 0) < 0) _exit(1); execl(_PATH_BSHELL, "sh", flags & WRDE_UNDEF ? "-u" : "+u", "-c", "IFS=$1;eval \"$2\";" "freebsd_wordexp -f \"$3\" ${4:+\"$4\"}", "", ifs != NULL ? ifs : " \t\n", flags & WRDE_SHOWERR ? "" : "exec 2>/dev/null", wfdstr, flags & WRDE_NOCMD ? "-p" : "", (char *)NULL); _exit(1); }
- MichaelMoser123 8y agofunny that glob doesn't do that http://xr.anadoxin.org/source/xref/macos-10.14-mojave/Libc-1272.200.26/gen/FreeBSD/glob.c http://xr.anadoxin.org/source/xref/macos-10.14-mojave/Libc-1... however wordexp does.
- self_awareness 8y agoSeems Linux version also depends on forking to the shell: https://code.woboq.org/userspace/glibc/posix/wordexp.c.html https://code.woboq.org/userspace/glibc/posix/wordexp.c.html
- leni536 8y agoFor the sake of completeness musl libc also does this. https://git.musl-libc.org/cgit/musl/tree/src/misc/wordexp.c#n111 https://git.musl-libc.org/cgit/musl/tree/src/misc/wordexp.c#...
- the_mitsuhiko 8y agoNot exactly related to the link but apparently the author of that tweet blocked me. I don’t recall having ever had any interactions with them. Is there a way to contact that person and figure out why? I have no idea what I did and I’m quite puzzled.
- stonogo 8y agoYou find out someone has blocked you, and your instinct is to communicate with them? The specific thing they have explicitly disallowed? I'd reconsider this, and just move on.
- the_mitsuhiko 8y agoIs that how you are supposed to deal with that? How is one supposed to improve as a human if one does not know where their mistakes are? If I did something wrong I would like to know. I did not contact that person anyways and I doubt there is a way. But at least knowing when I was blocked could help me deduce what might be the reason. Honestly I do find this quite upsetting.
- philwelch 8y agoIt could just be irrational intolerance on the part of the other person.
- Shish2k 8y ago> Is that how you are supposed to deal with that? I believe the commonly accepted answer is "Yes, it's not my job to give you the necessary information to improve yourself". The same people who say that also often ask "Why aren't the people around me improving themselves?" :P (Personally, I would prefer it if people pointed out my mistakes, and I do the same for others as a courtesy, not an obligation. I do understand if they don't have the energy to do that, but I think if they don't, then they forfeit the right to complain about a lack of improvement)
- 8y ago
- jslabovitz 8y agoTurns out this is actually documented in the manpage for wordexp()! (And refers to the mentioned fact that it now calls 'sh' directly.) > BUGS > Do not pass untrusted user data to wordexp(), regardless of whether the WRDE_NOCMD flag is set. The wordexp() function attempts to detect input that would cause commands to be executed before passing it to the shell but it does not use the same parser so it may be fooled. > The current wordexp() implementation does not recognize multibyte characters, since the shell (which it invokes to perform expansions) does not.
- deleted 8y ago[deleted]