7 ms·
Linus on trivial patches: https://lkml.org/lkml/2004/12/20/255 https://lkml.org/lkml/2004/12/20/255 [ Linux-kernel added back into the cc, because I actually
by gowld 8y ago
Linus on trivial patches:
https://lkml.org/lkml/2004/12/20/255 https://lkml.org/lkml/2004/12/20/255
[ Linux-kernel added back into the cc, because I actually think this is
important. ]
On Tue, 21 Dec 2004, Jesper Juhl wrote:
> Should I just stop attemting to make these trivial cleanups/fixes/whatever
patches? are they more noice than gain? am I being a pain to more skilled
people on lkml or can you all live with my, sometimes quite ignorant,
patches?
I do try to learn from the feedback I get, and I like to think that my
patches are gradually getting a bit better, but if I'm more of a bother
than a help I might as well stop.
To me, the biggest thing with small patches is not necessarily the patch
itself. I think that much more important than the patch is the fact that
people get used to the notion that they can change the kernel - not just
on an intellectual level ("I understand that the GPL means that I have the
right to change my kernel"), but on a more practical level ("Hey, I did
that small change").
And whether it ends up being the right thing or not, that's how everybody
starts out. It's simply not possible to "get into" the kernel without
starting out small, and making mistakes. So I very much encourage it...
So please don't stop. Yes, those trivial patches _are_ a bother. Damn,
they are _horrible_. But at the same time, the devil is in the detail, and
they are needed in the long run. Both the patches themselves, and the
people that grew up on them.
- golergka 8y agoI really hope that next time when somebody tries to paint Linus as an asshole and a toxic force for the community because of his rants, someone remembers to link this email too.
- hyperman1 8y agoIt demonstrates how Linus is not only a good programmer, but also a good leader. I get the same idea as with the first Gordon Ramsey Kitchen-fixing programmes. Apparently, people said it was insane how he dared to swear on TV. But basically, he notices things are very wrong, makes sure he gets to the bottom of the mess, and hammers the ugly message very publicly into some owner who lost any connection with reality. If the cost is some swearing, that's the least of the problem. The failing businesses get fixed at least as much on a sociological level as on a cooking level. Linus does the same. A big software project's problems are more sociological than technical in nature. Sometimes, the ugly message has to get trough, an another famous rant is born. But most of the time, work gets done, probably with a reasonable amount of smiles.
- robin_reala 8y agoThe US Kitchen Nightmares are completely faked up drama for US audiences. Watch some of the original UK ones and you’ll see how he tries to coach the chefs with comparatively minimal swearing and anger.
- hyperman1 8y agoI am indeed mostly talking about the UK versions. The US versions had much more drama and much less cooking, but underlying it had the same theme.
- Andrex 8y agoUnrelated to the article, but the early British seasons of Kitchen Nightmares were so good. I still enjoy watching the Fox version (and his new show, 24 Hours), but I appreciate those original seasons much more.
- yesenadam 8y agoMitchell & Webb's take on Kitchen Nightmares, more criticism than comedy https://www.youtube.com/watch?v=i1NfWIaYed8 https://www.youtube.com/watch?v=i1NfWIaYed8
- danharaj 8y agoYou don't have to be an asshole all the time to be an asshole.
- dx87 8y agoI also like this email where he explained to a CS student the difference between spinlocks and semaphores. https://yarchive.net/comp/linux/semaphores.html https://yarchive.net/comp/linux/semaphores.html
- PhasmaFelis 8y agoSomeone can be an asshole and a great leader, at the same or different times. Linus himself, to his credit, recently admitted that he's been unreasonably abusive and is trying to learn better.[0] People are complicated. He needn't be either a saint or a demon. [0] https://lkml.org/lkml/2018/9/16/167 https://lkml.org/lkml/2018/9/16/167
- HarryHirsch 8y agothat he's been unreasonably abusive I have not heard of Linus taking credit for other people's work, or him getting into a fistfight at a conference or feeling up women's asses.
- kbutler 8y agoAnd apples are not oranges, but they are both fruit.
- PhasmaFelis 8y agoGood thing no one implied any of that, then!
- golergka 8y agoThe thing is, all Linus rants that I've seen are entirely reasonable. Yes, calling someone stupid is rude, but rude things should be used in extreme circumstances. And when a single developer can negatively affect millions - wait, actually, billions - of people around the world with a stupid patch, that's exactly the case where being rude and aggressive is entirely reasonable.
- chrisseaton 8y agoBeing rude and aggressive would be reasonable if there was some imminent danger, but there isn't - he can calmly explain things and doesn't have to merge anything until he's ready.
- core-questions 8y ago> all Linus rants that I've seen are entirely reasonable Spot on. I'd hate to be on the receiving side, but look at what we've all gotten from this effort - in a Machiavellian sense it really has been the correct choice.
- Latty 8y agoLinus admitted himself that his behavior was sometimes out of line. That doesn't mean he was always "an asshole", just that sometimes he was. He has accepted that and worked to change it. Stop trying to paint progress as a bad thing.
- eridius 8y agoJust because someone is frequently an asshole doesn't mean they're an asshole 100% of the time.
- yesenadam 8y agoWell, serial killers don't kill almost all the time also. Reminds me of that Monty Python sketch where the army guy tries to reassure the interviewer by saying there's "almost no cannibalism in the British Army."
- mxstbr 8y agoThis is such a great comment and very true. Looking at the speed and attitude that maintainers handle trivial PRs with can act as an indicator of the project health and will definitely make it more inviting for new contributors!
- hermitdev 8y agoIn my experience, you can read a (large) code base all you want, but until you get in there and start making (breaking) changes, you're not truly going to understand it. I think Linus's quote largely reflects my opinion/experience. A new comer's changes won't always be good or right, but get in there and try things out!
- abhishekjha 8y agoI have been trying to get into that with not much success. It looks like I end up trying to understand the whole thing at once. I don't know how to look at the source code which solves a specific small problem. Is there proper guide by earlier contributors about how to get used to the source and start breaking/fixing things?
- nojvek 8y agoI remember my first few commits to big projects were documentation ones. Like —inspect documentation in nodejs, and node —help. It gives you exposure to code, the dev loop, general idea of how things work. Then one can take on bigger and bigger challenges. We all gotta start somewhere.
- Iv 8y agoI am a bit sad that Linus is more known for his occasional frank outbursts than for his consistent encouragement and supportive tone.
- derangedHorse 8y agoNgl, that's what I know him for the most.
- antirez 8y agoI agree on the general concept of your post, however I cannot observe, at least for the things I maintain, that there is this pattern of "people starting small". At least not small in the sense of trivial changes. They maybe start submitting a small PR but that is most of the times already at the level of the contribution that they'll make in the future. So people that will become core contributors will send a small PR with a core change, showing already that they can understand the core of the system. However the open source movement cannot only optimize for the raw code output. The "I changed this" feeling is also great for users to realize that there is space for everybody.
- canadaduane 8y agoPerhaps there is a community-wide phenomenon of progression, but not observable within single projects? I wonder if this may be similar to the "won't hire jr. developers" tragedy of the commons that many companies are party to: the economy as a whole would benefit from investing in jr. developers (by providing an environment in which they can advance to sr. developers), but for each company individually, there is risk in training someone up in a year or two only to have them leave and become a "mid-level developer" at another company.
- steveklabnik 8y agoHere's my first PR to Rust: https://github.com/rust-lang/rust/pull/4305 https://github.com/rust-lang/rust/pull/4305 Note that it was rejected because I sent it into the wrong branch (we do use master these days) and so I even had to resubmit it https://github.com/rust-lang/rust/pull/4308 https://github.com/rust-lang/rust/pull/4308 I'm about to send in my 972nd PR now. The Rust book is 520 pages; that was the second version, the first of which was ~300 pages. Quite a big difference from +34/-2. I'm at +142,087/-166,524 lines to the main repo now, and #12 overall contributor. Yes, not everyone who sends in a small patch will become a core contributor. But some will. It's a numbers game.
- antirez 8y agoThis is a great real world example. However I would rate your first PR as very good... Documentation improvement, with examples, is something which is very hard to get. Btw in general, I totally agree with the basic idea of trying to merge trivial patches. I go a step forward and I merge "just typos" PRs even if they have the bad effect of breaking other very important PRs sometimes, because a trivial break will be a trivial rebase anyway and typos cannot stay there forever. From this POV btw Github does a terrible job not telling maintainers: "merging this PR will result in the following PRs being no longer mergeable". Most of the times the list would be empty, making the merging of small PRs a lot more a non brainer.
- rdiddly 8y agoCan't stop laughing evilly at the thought of him instead tearing into a 4-year-old like Christ, Maisa, your reasoning is weak as hell, and then you come up with THIS shit. Heck no. In fact, not a fucking way in hell. Look yourself in the mirror, Maisa. This patch is ugly, and then you have the gall to quote the "the last s is sad" thing in commit... compared to the diseased abortion you just posted... EDIT: Shoot I keep having to edit to add more virtue signalling. This is wrong, do not do this to children. Hopefully you didn't need to be told that. Also, Linus is trying harder now. But this is a joke. Someone will make it. It's funny because it's wrong. (Nothing is less funny than when exactly what's supposed to happen, happens.) But Linus did totally say this to someone; I just changed the name.
- HarryHirsch 8y agoCan someone explain what's funny here?
- intertextuality 8y agoNothing. The person above does not realize that Linus doesn't yell like this at newbie committers. His rants are directed at people who -should- know better. I'm not justifying them, but there is quite a difference.
- rdiddly 8y agoSee my sibling comment to yours. The outrageousness and unlikeliness of yelling at a 4-year-old (the noobiest of noobs) is exactly why I found it funny in the first place.
- rdiddly 8y agoApparently I'm the only one who thinks it is, so I'll volunteer that I found it funny because it's unexpected and shocking, yet almost plausible enough to be believed, given Linus Torvalds' track record as a sometime verbal abuser of adults. Speaking of which, I just realized it also includes an unintentional satirical subtext that highlights the difference between how Linus most likely treats children (probably not like this) and how he demonstrably has treated adults (exactly like this). Which isn't "funny" per se, but there's your explanation. Explanations are rarely funny either, nor do they generally result in suddenly getting the joke and laughing. But I suspect that wasn't your aim anyway.
- sytelus 8y agoLinus says: > I think the trivial patches are among the most important ones - exactly because they are the "entry" patches for every new developer. I have been running a fairly successful open source project and this is not exactly my experience. I guess about 70% of pull request I get is simple spell, grammar, white spaces and the likes. Some time folks send this in wholesale because they want their personal favorite verbiage. It takes enormous amount of time to go through each line and each file to make sure something else is not sipping in. However, more importantly, rarely I have seen these text fixers to send any real code fixes. Vast majority of them are just one offs. My thesis is that there are lots of folks out there just trying to brag to be "contributor" for popular open source projects and they just move on from one project to next rarely taking time to settle down in any individual project. This might be not be the case for Linux kernel but might be the case for other smaller projects.
- canadaduane 8y agoA more generous interpretation (and the one that I think explains my very short stints as a contributor in just the way you describe) is that I really appreciate the project, want to help somehow, but won't/can't commit to deep work on the project. I also see many projects that practically beg for help "even if it's just documentation" and believe small contributions to be similar to adding a dollar to the tip jar.
- A2017U1 8y ago> takes enormous amount of time to go through each line and each file >My thesis is that there are lots of folks out there just trying to brag to be "contributor" for popular open source projects Do you have an example of this? All I could find in your top 3 repos was one pull request updating the readme and its only 8 lines. https://github.com/sytelus/CryptoJS/pull/3/files https://github.com/sytelus/CryptoJS/pull/3/files
- bowersbros 8y agoTo be fair, he works for Microsoft, its entirely possible he maintains one of their OS repos.