18 ms·
You know how HTTP GET requests are meant to be idempotent?
- mchahn 9y agoThis garage door opening story reminds me of something that happened in the 50's. The first powerful comm satellites happened to use a frequency that garage doors used (no id codes then). Garage doors opened and closed by themselves. My grandmother had it happen to her.
- baddox 9y agoThe first time I clicked the link, Twitter said I was rate limited. I thought that was the joke.
- tlrobinson 9y agoI saw “GET request” “idempotent” and “WiFi control garage doors” and immediately inferred the punchline. At least it was his own devices and not Googlebot or something, I guess.
- baddox 9y agoI’m more surprised that the Safari new tab window makes GET requests to every “favorite” URL, which I gather is what was happening.
- jedberg 9y agoIt's updating the thumbnail screenshots. This only happens if you have the Safari "blank page" be your favorites instead of either your "home page" or a truly blank page.
- josteink 9y ago> if you have the Safari "blank page" be your favorites instead of either your "home page" or a truly blank page. Yay for modern user friendly applications making simple words like blank completely meaningless and ambiguous.
- Senderman 9y agoThe commenter may have called it a "blank page", but Safari doesn't; it just labels the setting as "New tabs open with...", with "Empty page" being one of the choices.
- ascagnel_ 9y agoThat's on the poster -- Safari calls it "Top Sites", with explicit options for "Empty Page", "Home Page", etc.
- Senderman 9y agoIf I recall, Safari's default is to show your "favourites" screen in a new tab, which routinely refetches to update icons/previews. I'm skeptical that it's "every time" but I do remember it doing it way more than I thought was needed.
- mozumder 9y agoNow I wonder if Safari (& other browsers) has distinct headers for their favorites lookups, to tell these lookups apart from real users and discard these accesses from site analytics..
- kalleboo 9y agoThey do, "X-Purpose: preview"
- wpearse 9y agoHey! I've been thinking about this all day. I thought it was a GET to fetch the title of the page, but it might only be an OPTIONS or HEAD request? I'm not sure. Either way, my code activates the garage door on that endpoint no matter the HTTP verb.
- jholman 9y agoLiterally the reason HTTP verbs are a thing is so that User Agents like Safari can do exactly this. If this weren't a by-design property of the HTTP protocol, we wouldn't even have methods. Read the spec!
- diminoten 9y agoThis is a little bit (not a lot though) like the /reset.htm endpoint on some Arris Surfboard modems. https://news.softpedia.com/news/csrf-bug-in-over-135-million-arris-modems-lets-anyone-factory-reset-the-devices-502672.shtml https://news.softpedia.com/news/csrf-bug-in-over-135-million...
- guelo 9y agoIs idempotency part of HTTP or just part of loose REST conventions?
- detaro 9y agoHTTP: https://tools.ietf.org/html/rfc7231#section-4.2 https://tools.ietf.org/html/rfc7231#section-4.2
- phamilton 9y ago> loose REST conventions REST is HTTP. "loose REST conventions" is when someone chose to ignore big chunks of the HTTP spec. In other words, you can build whatever you want (like SOAP) on top of HTTP and ignore the spec that describes content negotiation, HTTP methods, Caching policies, etc. It's still technically HTTP. But if you were to read the HTTP spec and follow it to a tee, you'd build a REST application.
- peteretep 9y ago> REST is HTTP This is untrue. I hate to quote from Wikipedia, but it sums it up quite nicely: "REST is not a standard in itself, but RESTful implementations make use of standards, such as HTTP, URI, JSON, and XML" More colloquially: REST is what happens when people mix up transport layers in their head.
- daenz 9y agoThese kinds of chaotic accidents are just going to get more frequent as everything moves towards IoT
- groestl 9y agoIdempotency might be necessary for GET calls, but it's not sufficient. Imagine he had two separate GET calls (opened/closed): the author would still have the same problem. Browsers assume GET to be safe (non-mutating), and safety implies idempotency.
- onion2k 9y agoExactly. A 'toggle' should really be implemented as a PATCH request, or maybe a PUT if there's no data other than the door state.
- hardwaresofton 9y agoAt the risk of being overly pedantic/piling on -- this is what bad REST-ful API design looks like in practice. When you talk to your teammates about the semantics of these verbs and someone just says "oh a GET is fine" and the team agrees but you don't and you can't say it so you don't become "that guy" it's time to find a new engineering org to be a part of. On the topic of PATCH, check out JSON merge patches (application/merge-patch+json): https://tools.ietf.org/html/rfc7386 https://tools.ietf.org/html/rfc7386
- groestl 9y agoJust be the guy who says "oh a POST is fine" first
- aptwebapps 9y agoYeah, full REST is nice, but you can do worse than just using GET and POST as long as GET doesn't change state.
- icc97 9y agoLayers of REST that people get to: 1. GET is good for everything 2. Perhaps we should use POST too 3. Let's use all the verbs 4. Someone mentions HATEOAS 5. Some old guy says that you've got to use XML because that defines links and JSON doesn't 6. Someone else counters with JSON-LD and sends a link to the W3 spec That's as far as I got. Mostly this conversation happens in my head.
- beejiu 9y agoWhen I recently added 'click to unsubscribe' functionality to my emails, the URL got wrote out into some logs. Those logs got written to a Slack channel and Slack loves to click any link it sees. Oh, and it doesn't respect robots.txt. But all I saw was every member of my list clicking 'unsubscribe'. It took a good hour to figure out exactly what was going on. Idempotence is not the problem here, by the way. That just means calling the method twice has the same effect. But GET should have no side-effect, in an ideal world. Of course, in the case of unsubscribe links, it needs to have a side-effect to comply with the law.
- javajosh 9y agoIt would be sufficient to GET a resource that uses a script to POST the side-effect. Slack's user-agent probably isn't sophisticated enough to mess this up (although heaven help us when they implement their preview with something like headless chrome).
- poizan42 9y agoWhat would the problem be in just showing a button that says "Confirm unsubscribe" that sends a POST request? A lot of sites does something like that for their newsletter unsubscription.
- beobab 9y agoThat would comply with GDPR, and is a valid solution.
- SoulMan 9y agoIt is at least better than asking the email or something even to login to unsubscribe ("update communication preference")
- astura 9y agoI believe asking to login violates the CAN-SPAM Act. That being said, there might be two links, one for "update commication preference" on top and "unsubscribe" in small text at the bottom. I always ignore the first and seek the latter.
- wpearse 9y agoHello! Long-time lurker, and guilty dev behind the garage door. You can see the (broken) code I wrote here: https://github.com/wpearse/wemos-d1-garage-door-wifi https://github.com/wpearse/wemos-d1-garage-door-wifi I'll get around to fixing it later this week. Also, an apology: I should have used "side-effect-free" instead of "idempotent" in my tweets.
- wpearse 9y agoFixed now: https://github.com/wpearse/wemos-d1-garage-door-wifi/commit/fa6d1881857f32bb64b43a0192fcc435fa683afe https://github.com/wpearse/wemos-d1-garage-door-wifi/commit/... I think. edit: updated link because left creds in the commit :-/
- xbenjii 9y agoI hope that's not your real password!
- speps 9y agoEDIT: it's actually his address, I thought it was just a coincidence but you can the house on Street View... I removed the actual name as doxxing isn't great, sorry.
- wpearse 9y agoThanks. Not the address with the WiFi garage thankfully. I was actually thinking "better not commit that" ... before, y'know, I committed it :/
- dogma1138 9y agoWell looks like a nice neighborhood at least.
- jimktrains2 9y agogit add -p It will let you approve each hunk in a file to commit or not. git commit -e -v Will force you to edit the commit message and in the editor show you the diff of the commit against HEAD.
- cottsak 9y agoThe intersection of full-stack web devs from the commercial line-of-business world; and hardware/embedded hackers brings a lot of room for accidents IMO. I'm not saying any one of these groups are bad or inept. I'm in the former and completely accept that I'm new to embedded programming. It seems kool and I wanna learn about it. But I can also see the flip side where a hardware hacker sees query strings for toggling an output as a perfectly reasonable interface. Do we expect the embedded guys to grok HTTP/REST? The web-dev would be like "no, no, that has to be POST or PUT". But these things are going to happen. We don't yet have a large pool of experts across both fields. It's no surprise the level of compromise and breach when you intersect what were pretty distinct skillsets and dump them in the mixing bowl together. That's what this IoT thing is like - it's a bunch of household and industrial chemicals all poured into the one container. It's not going to be very safe.
- JimDabell 9y ago> Do we expect the embedded guys to grok HTTP/REST? REST is irrelevant to this; HTTP alone covers the reason why this is bad. So ultimately, the question is: "Do we expect somebody designing an HTTP API to understand HTTP?" I think that's a reasonable expectation. If your embedded guys don't understand HTTP, then get somebody who does understand HTTP to design the API. They don't need embedded experience to do so, they aren't implementing it, just designing it. This isn't a difficult cross-functional intersection, you just don't assign tasks to people who aren't qualified to carry them out.
- tudorconstantin 9y agoAlso, having your garage door opened with unauthorized requests seems like looking for trouble
- wpearse 9y agoYeah, did wonder about that. My thinking at the time was that the device was on the local WiFi network, not exposed to the internet, and there would be easier ways of getting into the garage if you really wanted to.
- chrisweekly 9y agowar-driving -- now with parking included!
- latchkey 9y agoI have a small (golang) agent that runs on over a thousand raspberry pi class machines (not on the open internet). The agent has a GET /reboot api because it is really convenient to be able to just hit that url in a browser window when we need to. Adding all the no-cache headers to the response seems to have worked well enough to prevent browsers from randomly hitting the url. I just added a check for the x-purpose header as well, thanks for the suggestion.
- XorNot 9y agoThis still seems like really bad idea when the POST request is right there. Serve a page with a button saying "are you sure"?
- latchkey 9y agoA reboot of the machine isn't the end of the world and far less risky than a garage door randomly opening. It probably needed it anyway as they tend to degrade over time. This is a very specific usecase. If it becomes an issue, I can always push out an update of the software that switches things to POST (thanks to using the golang library, overseer).
- JimDabell 9y agoIt still seems a bit odd to do it this way when it's so easy to do it right. I hope the hostnames / IP addresses aren't predictable, because all it would take to cause trouble is to send an HTML email containing something like <img src="http://192.168.0.1/reboot"> http://192.168.0.1/reboot"> to your staff and then you'd trigger a bunch of reboots whenever anybody opened their email. Or just send a link to a page that does the same thing. Or text a link to them and wait for iMessage or whatever to preload the page to get the preview. There's so many different ways to trigger an automatic GET precisely because GET is defined to be safe.
- latchkey 9y agoI feel like the 'do it right' comment is a bit speculative or entitled. It does create a usability barrier that I was trying to avoid. Even the extra button click is a pain in the ass when you're rebooting dozens of machines (sometimes daily). Your second paragraph is spot on. Very good point and kind of why I posted here in the first place. Two minds are always better than one. I forgot about the image attack. I've seen this used in the past to 'win' contests by sending in votes over GET. Luckily my IP's are pretty hard to guess, not a standard range, but you're right... that is a totally valid 'attack' vector. I'll make the change asap.
- wwweston 9y agoPerhaps we need a specific nomenclature for this sort of case: oddempotent! After all, you get the same state if you do it 3,5,7,9,etc times as if you do it once, right? ;)
- hashmush 9y agoThat would be an involution! https://en.wikipedia.org/wiki/Involution_(mathematics) https://en.wikipedia.org/wiki/Involution_(mathematics)
- deleted 9y ago[deleted]
- MrMid 9y agoWell, a while ago I saw this code (on my own project!): window.open("?controller=users&action=changePassword&name=" + user_name + "&password=" + password) I was horrified, glad it isn't live yet, and I fixed it immediately. But I'm still wondering whether I was so sleep-deprived or drunk when I wrote this. It's over SSL, so it should not be that big deal, but still, GET shouldn't be used for such things.
- dogma1138 9y agoWell you don’t seem to validate the existing password prior to authorizing the change. Good CSRF protection on GET requests is also near impossible to implement as GET is intended to be a “safe” request as in a request that does not modify a state but this isn’t something that is actually practiced.
- MrMid 9y agoActually, I do. This is not a form for user to change his own password, rather a administrators form to change another user's form. And for such actions the administrators identity and privileges are checked. But I understand your reasoning and thank you for pointing it out. And yeah, I try to use GET only for safe requests, but I should be more careful.
- jimktrains2 9y agoAnother big deal is that it'll get stored in server logs too.
- dharmab 9y agoIt's a big deal since it will be visible in access logs in plaintext, so if the logs are compromised your users would be too.
- joesb 9y ago> "I threw the code together in minutes and was too lazy to spend another couple minutes figuring out POST." So it's not the vendor's problem then. They provide you with two ways to make a request. You have a choice to do it right, you didn't.
- Kiro 9y agoWho says it was the vendor's problem?
- acdha 9y agoThe device should not support GET at all for this. It opens up a number of attacks and there’s no good reason to support it.
- scrollaway 9y agoWhat's your point? Nobody said it was the vendor's problem except you.
- inopinatus 9y agoSee also: email-based click-to-confirm produces many false positives.
- DCoder 9y agoMany years ago, I was asked to look at why all the content had vanished from a site (not built by me). After digging in a bit, I found that: 1) the original developer's idea of handling an unauthorized /admin request was just to set a redirect header and continue processing the current request . 2) the /admin page had a grid of all the content on the site, with handy 'Delete' links that ran over GET without confirmation. You can probably guess where this is going – some search bot hit the overview page, ignored the redirect header, saw the content, and dutifully crawled every single link on it…
- acdha 9y agoThere were at least two browser extensions which also discovered that poor design was widespread and to disable prefetching for similar reasons: http://fasterfox.mozdev.org/index.html http://fasterfox.mozdev.org/index.html https://signalvnoise.com/archives2/google_web_accelerator_hey_not_so_fast_an_alert_for_web_app_designers.php https://signalvnoise.com/archives2/google_web_accelerator_he... I think the state of the web has improved slightly over the last decade but this is a great example of why browser vendors are so conservative. You can do this now but only opt-in.
- greglindahl 9y agoWas it blekko? We had a website owner email us about that issue when blekko's ScoutJet crawler was new... although I don't recall the bit about ignored redirect headers.
- saalweachter 9y agoI'm pretty sure everyone with a crawler has hit this sort of problem before. The first startup I was at did with someone's wiki that had "delete" links everywhere with no auth.
- greglindahl 9y agoNow that I've hit it once, I watch out for websites with this problem. I was surprised to notice that a Fortune50 tech company's internal employee-personal-webpages-maker-thingie had that issue. And then a week later they asked me if I could crawl their internal web. Uh, no, who knows what other internal systems had that problem?
- reza_n 9y agoTo me this sounds like a CSRF problem. There's no token or session associated with these calls, so a browser was able to inadvertently CSRF the calls. Changing this call to POST or PUT would still leave this API vulnerable.
- chrisseaton 9y agoIt's not about access control, it's about the fact that browsers are free to make speculative GET requests whenever they like, and they actively do to pre-fetch pages. His GET end-point was pre-fetched by his browser, activating the door. This would still happen even if there was a token or session associated.
- jimktrains2 9y agoNot just browsers, but any service.
- reza_n 9y ago> This would still happen even if there was a token or session associated. This is exactly the scenario a CSRF token is support to prevent. But I understand your point.
- shocks 9y agoMy desk height is set with a GET. I was going to fix it, but considering how hilarious this is I might not.
- andai 9y agoYour desk runs a web server? I need to step up my game...
- shocks 9y agoYeah, it's a sit/stand Linak desk. I hooked up an ESP32, 2 channel relay (up/down control), and distance sensor (to detect height). Pushes height to graphite and position is settable remotely. :)
- neilsimp1 9y agoI get that it's cool, but I'm missing the why? Would you ever need to change your desk height when you're not already at your desk? Wouldn't manually changing the height be easier than hitting an HTTP endpoint on your PC to adjust it? Maybe I'm missing something, and like I said, I'll give oyu that it's cool and that alone is sometimes reason enough.
- shocks 9y ago> I get that it's cool, but I'm missing the why? I'm a hacker, I did it because it's cool and I wanted to learn.
- matte_black 9y agoThis kind of thing shouldn’t even be a REST call. Use JSON RPC.
- olavk 9y agoWhy is that better?
- matte_black 9y agoFirst of all “/toggle” is not a proper REST endpoint. In fact, that is exactly what an RPC endpoint might look like. I can’t believe so many “developers” miss this. With JSON RPC, he would POST a JSON object to a /toggle endpoint which runs a procedure to open or close his garage door. If you want to be cute and conform to REST as much as possible, you would have to treat your garage door like a resource, and then use PUT to send the entire new state of the garage door to your API or PATCH to send the instructions for how to change the existing state (or use the +json media type for patch if you want to be lazy and just send a JSON object with updated key values). Your URL would probably be in the form of “/garage-doors/garage-door-id”. Except, his garage door is probably NOT a resource and has no ID or even a serialized representation of it’s physical state. It’s just a physical door. And it should be driven remote procedures. Maybe you don’t need any of this. Maybe you are happy with just using GET and pushing everything into REST and basically doing the wrong things. But that’s how you end up with the problems in the article, by not respecting standards, by choosing to be close enough to correct instead of technically correct. And frankly, if there’s any people who should strive for technical precision it should be engineers. I personally would not hire a single software engineer who chose to approach this problem in the RESTful way without clear and deliberate reasoning for doing so.
- olavk 9y agoYeah obviously he is doing it wrong, that is the point of the story. GET methods should not have side effects. But wouldn't you have the same problem if you sent a JSON RPC request using GET? Clearly this is not a REST architecture, they are just using raw HTTP requests as RPC's. I just don't see how the JSON RPC standard would help anything, it just seem like an additional wrapper.
- AnIdiotOnTheNet 9y agoTwo thoughts: 1) Twitter is a terrible medium for anything, let alone posts longer than a sentence. 2) The level of over-engineering tech people readily engage in without a second thought is truly mind boggling.
- slig 9y agoAdding Wi-Fi control to your garage door using a WeMos is not over-engineering. It's just a fun little weekend hack.
- TheCapn 9y agoOver-engineering is what I did... - Raspberry pi - Open/close sensors on the garage door as well as the side-entry door - Camera pointed at the side entry door taking photos while it is left open - Push alerts to my phone if either door is opened between specific hours of the night (Break-ins to detached garages were huge in my neighborhood) - Voice controls from my fucking phone to open the door I sold the house otherwise it'd probably be an even larger monstrosity today
- slig 9y agoThat sounds really cool. One of the advantages of owning your house.
- a13n 9y ago1) Market disagrees with you strongly, hence hundreds of millions of people using it regularly. 2) He's just having fun, working on a side project that's useful to him, and learning. Nothing wrong with any of that. Why so negative?
- AnIdiotOnTheNet 9y ago1) Popularity is rarely an indicator of quality. 2) That doesn't mean it isn't over-engineering.
- astura 9y agoThis is pretty much the classic newbie web developer mistake, heard many stories about people making it when they first start. I've also seen people fuck up in the opposite way, using POST when they should use GET and having unexpected behavior. Though not usually as "funny" as the classic "using GET instead of POST" errors are. This concept of HTTP request methods really should be explained to new developers in a more accessible way, with examples of mistakes. It might not be intuitive at first or they might not think it's important as it is. "Idempotence" isn't really the problem here, nor "should" GET requests be idempotent, think kittenwar.com or stumbleupon, the problem here is GET is reserved for retrieving (getting!) data, it shouldn't modify data. (Other than access information.)
- phab 9y agoGET requests are specified[0] to be idempotent: > Methods can also have the property of "idempotence" in that (aside from > error or expiration issues) the side-effects of N > 0 identical > requests is the same as for a single request. The methods GET, HEAD, > PUT and DELETE share this property. [0] https://tools.ietf.org/html/rfc2616#section-9.1.2 https://tools.ietf.org/html/rfc2616#section-9.1.2 edit: formatting
- astura 9y agoLooks like the RFC talks about idempotence from a "side effect" perspective where I was talking about it from an "output" perspective (the generated HTML). I agree with the RFC and I mistook what the person meant
- hatsunearu 9y agoWhat are some of these unexpected behaviors associated with using POST when you're meant to use GET?
- zzbzq 9y agoThe real problem here, as usual, is web browsers, the worst class of software ever written. We constantly come across these CSRF-style bugs that are only made possible by how stupid the browser and HTTP are, but instead of blaming the culprit and trying to deal with the source, we blame ourselves for not being accommodating enough. Fool me once, shame on me, fool me 5,000 times, shame on me. Oh, and occasionally invent hackneyed fixes like CORS.
- bogomipz 9y ago>"The real problem here, as usual, is web browsers, the worst class of software ever written." Can you elaborate? What class of software is this specifically? And why is it the worst?
- olavk 9y agoI don't see why the browser or HTTP is to blame here? GET is supposed to be safe, so what the browser is doing seem perfectly fine to me.
- draw_down 9y agoNay. TFA correctly identifies the problem.
- noonespecial 9y agoPostel's law: "an implementation should be conservative in its sending behavior, and liberal in its receiving behavior" Hope for the best but expect the worst.
- Ajedi32 9y agoCORS is to _allow_ cross-origin requests, not to restrict them. Most such requests are restricted by default.
- ascagnel_ 9y agoI'm not seeing how this is an issue with the browser as much as the server handling the request. Safari provides a feature that shows thumbnails of frequently visited sites; these thumbnails are loaded with a header specifying its for a preview. It's on the server to understand that a GET request _by definition_ should not have side effects (like toggling the open/closed state of a door), and optionally to perform special handling when seeing the preview header.
- PotionSeller 9y ago>idempotent what does this mean
- emddudley 9y agoIt's an important term in computer science. There is a good explanation on StackOverflow which I found by searching for "define: idempotent": https://stackoverflow.com/a/1077421/111327 https://stackoverflow.com/a/1077421/111327 > In computing, an idempotent operation is one that has no additional effect if it is called more than once with the same input parameters. For example, removing an item from a set can be considered an idempotent operation on the set.
- bawana 9y agoforgive my density, but why would you make a web page trigger a toggle when it is loaded? shouldnt there be a button or some other user interaction to initiate the state change? Is it like loading a web page for the weather- so that when the page is loaded it goes and 'GETS' the latest weather info? Is it for convenience? So that all you have to do is go to a webpage and have it do stuff?
- nwsm 9y agoI think there was a homepage with a "toggle" button, the toggle button redirected to /toggle. site.com/toggle then got added to his favorites by safari. So it wasn't loading the site with the button, but the site that the button redirects to.
- wpearse 9y agoCorrect. Site now has a form and a button. /toggle now responds only to POSTs, and redirects back to /.
- bawana 9y agoi must zsound so obtuse. How does redirection happen? If there is a web page with a button, then what is /toggle? Is it another web page on his site? Isnt a button some code in html on the index.html page?
- billfruit 9y agoI know this is quite unrelated, and based on hazy memory of things from almost 10 years ago, DML statements in databases especially 'insert into' statements are not idempotent as I remember; ie if you try to select a few rows from a table table1 and insert them into table2 with same schema, if there were any identical rows already in table2, then whole insert will fail. My thinking at that time was that if these insert operations were idempotent, then there would be no need to explicitly check for duplicates before the insert.
- lathiat 9y agoAt least in MySQL you can use “ON DUPLICATE KEY” to either ignore such things or optionally execute an update statement to change something about the matching row. There is also REPLACE INTO Assuming you have a relevant unique key setup of course.
- dragonwriter 9y ago> DML statements in databases especially 'insert into' statements are not idempotent as I remember; GET is actually supposed to be safe which is stronger than idempotent; the SQL command that most naturally corresponds to GET—SELECT—is normally safe, but DML inherently is not. But, sure, that INSERT isn't safe increases the amount of code needed to implement idempotent PUTs.
- myth_buster 9y agoReadable format. https://threadreaderapp.com/thread/990684453734203392.html https://threadreaderapp.com/thread/990684453734203392.html
- sbussard 9y agoToo funny!
- jason_s 9y agoSee "Important Programming Concepts (Even on Embedded Systems) Part I: Idempotence" https://www.embeddedrelated.com/showarticle/629.php https://www.embeddedrelated.com/showarticle/629.php
- jackpeterfletch 9y agoOr dont your doors to the internet.
- tialaramex 9y agoThis stuff is also why you should be afraid of any libraries/ frameworks/ tooling that says it's going to automatically offer TLS 1.3's "Zero round trip" (0RTT) feature for code as opposed to trivial stuff like resource downloads. Normally, TLS ensures you can't replay somebody else's conversations. So even if I know Barry, who is authorised to toggle the door, just sent a "toggle the door" command, if I try playing it back that won't work, the setup will be different each connection and I can't respond. But for 0RTT there is no setup - there can't be, no time to do it, and so if I replay Barry's "toggle the door" it would work. The specification is very clear that the right thing here will be to never allow 0RTT for such features. But the moment that's hidden behind some library API you can bet _somebody_ is going to screw up badly. Alas our industry doesn't exactly have a "safety first" mentality.
- mrdiesel 9y agoThis guy is stupid.
- wpearse 9y agoYou're stupid.
- NewEntryHN 9y agoGET requests aren't supposed to be idempotent. They're not supposed to change state in a first place.
- dragonwriter 9y ago> GET requests aren't supposed to be idempotent. RFC 7231 disagrees. > They're not supposed to change state in a first place. Well, yeah, GET is supposed to be safe, but all safe methods are also idempotent.
- CoolAndComposed 9y agoJust because a server announces HTTP/1.1 doesn't mean it conforms to that specific RFC.
- dragonwriter 9y agoThat non-RFC-compliant implementations of HTTP exist irrelevant to what properties HTTP methods are supposed to have, which is the issue under discussion.
- CoolAndComposed 9y agoIt is compliant to an RFC, just not a specific RFC. That's part of the issue, that's simply taken for granted because of ideology.
- micimize 9y agoThis comment thread has really put me in a good mood. These stories have so much pedagogical value: • The grammars we engineer have important semantic value • understanding and adhering to them is important, and hard • relying on others to adhere to them is dangerous, and hard to avoid • "experts" make mistakes in both areas constantly I genuinely love seeing this kind of lively discussion, because these seemingly "trivial details" matter, a lot. The Three Mile Island accident was more or less caused by "message sent" being conflated with "state changed" at the UI level, directly leading to a nuclear meltdown. They basically had a system with the equivalent design of GET /open and /close that assumed success for both https://en.wikipedia.org/wiki/Three_Mile_Island_accident#Confusion_over_valve_status https://en.wikipedia.org/wiki/Three_Mile_Island_accident#Con...
- didibus 9y agoPrimary effect - An effect on the input arguments, who's effect is captured in the output. Side effect - An effect on state that was not passed in as input arguments, who's effect may or may not be captured on the output. Side effect free - Also known as pure, means the function only has a primary effect. Thus it only effects the input in a way that the output captures. Idempotent - Applying a function to itself results in the same effects. Applies to both primary and side effects. Where things get weird, is that there's also the following: - An effect on implicit input state, which did not come from input arguments, who's effect is captured on the output. This would be like a HTTP GET. Or any query on a DB where the DB is an implicit input. - An effect who's effect is captured on implicit output state, either by having its effect captured on an input (like a modification to a pointed object), or captured on output not returned by the function (like print to screen). This would be like a HTTP POST. And now if you look at all these, there's an easy permutations of them. So you can build a table like so: Input | Output | Idempotent Arguments | Return Value | Yes Arguments | Return Value | No Arguments | Outside State | Yes Arguments | Outside State | No Arguments | Arguments | Yes Arguments | Arguments | No Outside State | Return Value | Yes Outside State | Return Value | No Outside State | Arguments | Yes Outside State | Arguments | No Outside State | Outside State | Yes Outside State | Outside State | No All these combinations are possible. That's why it can be really tricky.
- PersistentCough 9y ago> You know how HTTP GET requests are meant to be idempotent? No, they aren't. They aren't meant to be anything specific. They can be idempotent, but generally these philosophical arguments are the net gain of this kind of condescension.
- downer68 9y agoThis, kids, is why GET requests should be idempotent. Or, like, you know, how about a browser only sends a request when I'm actually fucking asking for something, and doesn't try to fetch everything I've ever thought about, with my every slightest accidental finger twitch against its touch screen? What happened to deterministic user interaction?
- scottmf 9y agoDarn kids and their prefetching, GET off my lawn!
- fenwick67 9y agoGET is meant to get, not set. Since 1.0. https://www.w3.org/Protocols/HTTP/1.0/spec.html#GET https://www.w3.org/Protocols/HTTP/1.0/spec.html#GET > The GET method means retrieve whatever information (in the form of an entity) is identified by the Request-URI
- downer68 9y agoSo what? If I never intended for the GET to be GOT, then the browser is just as much at fault for such unintended consequences.
- scottmf 9y agoThat’s the whole point of HTTP request methods: it isn’t. GET should never cause such side effects. The entire web is built with these principles in mind precisely so that problems like this don’t happen. If you want a slower browsing experience feel free to disable prefetching in your browser, but this isn’t a hill worth dying on.
- boomlinde 9y agoWell, ideally you'd have both. When I "GET" I assume that it's GET as opposed to any of the other standard HTTP methods, not "GET" as in Indiana Jones getting the golden idol from the pedestal. This is not only a problem with browsers preemptively requesting URLs, but also when it comes to caching. What happens when the URL I'm GETing is cached? Absolutely nothing, as far as the original server is concerned. The current situation with browsers doing smart things to make slow websites appear fast is a bit like compiler writers doing smart things with UB in C, though. Speed a lot of things up by utilizing every undefined nook and cranny of the spec, breaking tons of legacy software that make pretty sound assumptions about how things actually work. I use a bunch of poorly designed legacy systems where GET often has intentional side effects. They break because the browser starts issuing HTTP requests long before I have finished typing an address. Let slow sites be slow and leave the speed problem to the people that should be dealing with it instead.
- blklivesmatter 9y agoI only terrified how twitter is stealing my privacy data
- twothamendment 9y agoI recently soldered a wire to my garage door opener on the wall and ran it to a relay and then to the pins on a raspberry pi. Knowing the state of the door is key because the opener is just a toggle. I also have my alarm system hooked up to the pi, so it checks the state before and after any request. Repeatedly asking it to open will open it, or return success of it already is. Same with close. It took a bit of testing before I trusted it would all work the way I thought it would, but now I user it and don't even think about it, it just works and is handy to have.