mkr-plse

5 ms·

1.
by mkr-plse 6y ago
Can you elaborate further? It will be interesting to see other use cases for code cleanup.
2.
by mkr-plse 6y ago
Do you already know the code that is not executed? If not, dynamic program analyses can help with identify the regions of code that are untouched (e.g., take a look at javaagent for Java programs). Subsequently, you can use some form of rea
3.
by mkr-plse 6y ago
For Piranha: a) Code related to stale flags is deleted b) Determination of staleness is based on status of the feature. c) Patch is created automatically and in a majority of the cases, compiles and passes tests. Based on my understanding
4.
by mkr-plse 6y ago
Piranha author here -- Will you be willing to contribute it to Piranha?
5.
by mkr-plse 6y ago
Interesting. We don't have tooling for this yet but extending the Piranha static analysis may help detect the issue.
6.
by mkr-plse 6y ago
The flag management system has information on activity pertaining to various flags. After prolonged inactivity, a flag is considered stale and a diff is generated. This is a heuristic (in the absence of expiry date for a flag) and the final
7.
by mkr-plse 6y ago
BTW, we also have a tech publication at https://github.com/uber/piranha/blob/master/report.pdf where we discuss some of the design tradeoffs pertaining to the stale flag cleanup problem. Can you elaborat
8.
by mkr-plse 6y ago
Manual code review and CI only. In our experience of deleting more than 2.5K flags, testing would have helped in one case but then the code was not tested well when the flag was introduced.