ghroos

3 ms·

1. 1.▲
   by ghroos 9y ago

   Sure. https://github.com/home-assistant/home-assistant/pull/9272 Closed with prejudice as a “hack.” I actually spent some time to make this feature request implementation consistent with other code as another
2. 2.▲
   by ghroos 9y ago

   Which is sad considering an issue I was attempting to contribute was a bug fix rather than new feature work. Clearly a lot of the earlier code suffers from lack of design. As I mentioned later I have had PRs accepted but overall I find main
3. 3.▲
   by ghroos 9y ago

   Probably. I had a couple prs accepted by another maintainer fwiw. The code standards were not the issue, nor were unit tests. Not my first rodeo. The later interactions were not pleasant and did not engender much interest in further contrib
4. 4.▲
   by ghroos 9y ago

   Having contributed to a number of projects via github, this is not true at all. I have had prs closed within minutes with curt replies. That is not how you “help newer devs through a PR process.” In another case this happened for a very cle