cfer43432t

3 ms·

1. 1.▲
   by cfer43432t 5y ago

   The biggest mis-conception about code reviews that it is for catching mistakes and improve quality. Well, you know what improves quality? QUALITY ASSURANCE. If you never heard about it, THAT is the issue, and your group/section/co
2. 2.▲
   by cfer43432t 5y ago

   That's what YOU think. But in practice they produce sub-par solutions and worse quality in my experience. Code reviews are basically a virtual piss-contest where people argue endlessly, everyone trying to show-off their intellectual su
3. 3.▲
   by cfer43432t 5y ago

   I think the issue is not that people make drive-by issues, the problem is that people argue about things endlessly which does not bring any value neither to the customers nor the company, that is only for the vanity of the reviewer, and man
4. 4.▲
   by cfer43432t 5y ago

   > otherwise it's not that important and doesn't need to be done Except that this decision is often not up to the code author, because the tooling rejects for example committing changes until all discussions are resolved (see Gi