captbaritone

8 ms·

31.
by captbaritone 3y ago
Interesting. I see what you're saying, and I don't know if I would characterize that as no-op code. All of that code will run. What I see there is redundant assignments, which I agree can act as a great form of code comment. Often
32.
by captbaritone 3y ago
Exactly right. And no-constant-expression is configurable to allow trivial constant expressions for exactly the reason the parent commenter raised.
33.
by captbaritone 3y ago
I think you’re technically correct. But if you are someone who is writing 100% branch coverage code this rule could still be useful. It will quickly point out parts of your code base that are going be impossible to test with 100% coverage.
34.
by captbaritone 3y ago
I love that framing. I’m the author of the rule/post and I see writing rules like this as an opportunity to mentor at scale. Incredibly rewarding to think that, in a sense, I can be in so many engineer’s editors helpfully pointing out
35.
by captbaritone 3y ago
Post author here. That’s a great framing! That means that, in theory, an enforced 100% code coverage would catch these issues as well, which I’m inclined to believe!
36.
by captbaritone 3y ago
Rule author here. Would love to see some examples! I think the closest I’ve (knowingly) done to this is to add an empty else clause that contains a comment.
37.
by captbaritone 3y ago
This is correct. The post is from 2022. New default rules are a breaking change and version 9, the first major relates since it was added, is coming soon and will include it by default.
38.
by captbaritone 3y ago
This is the approach I take as well. But it's not necessarily best of both worlds. Removing (or not inserting) technically useless parens can obscure bugs if you are not perfectly fluent in the precedence rules of the language. Their d
39.
by captbaritone 3y ago
Author of the post/rule here. I'd be very curious to see this rule ported/translated to Python! While the gotcha's would probably be different, I suspect it would uncover real bugs. One interesting challenge with JavaScr
40.
by captbaritone 3y ago
Author or the rule and post here. ESLint version 9, which is going to enable this rule as part of the set of "recommended" rules, is also removing all of the formatting rules. I'm pleased to see that. In the era of pretty pri
41.
by captbaritone 3y ago
Hey, author of the rule/post here. I'd encourage you to click through to the actual examples linked from the post. Seeing the issues in context, as opposed to the minimal example, can help show how quickly these issues can get los
42.
by captbaritone 3y ago
Author of the rule and post here. I reread the post this morning, and I agree that I should have been less definitive in that sentence. But I stand by the broader point: Useless code is generally not something developers intend to write. Wh
43.
by captbaritone 3y ago
Author of the rule and blog post here. I agree that, for me, I appreciate the extra clarity of explicit parens. This lead me to explore a VSCode plugin which visually show the implicit parens even if they are not present in the code: https
44.
by captbaritone 3y ago
Author of the rule/post here. It's planned to be included in the set of recommend rules in version 9. https://eslint.org/blog/2023/11/whats-coming-in-eslint-9.0.0...
45.
by captbaritone 4y ago
User defined themes place a meaningful restriction on how the UI can evolve. My theory is that as software has moved to the web, and thus a more iterative/continuous deployment model, this restriction has felt relatively more expensive
46.
by captbaritone 4y ago
Other discussion of this elsewhere in the thread: https://news.ycombinator.com/item?id=32865926
47.
by captbaritone 4y ago
This is a custom UI I built to showcase the collection we started on the Internet Archive as part of that collaboration. The collection has grown considerably since that time, but it’s the same set of files. My writeup of the Winamp Skin Mu
48.
by captbaritone 4y ago
The main challenge is CORS. For EQ/Balance/Visualization, Webamp needs access to the actual byte-stream which requires special permissions be granted in the HTTP headers by whoever is running the stream.
49.
by captbaritone 4y ago
The Milkdrop Visualizer does use Wasm, but it's a custom in-browser compiler. You can read more here: https://jordaneldredge.com/blog/speeding-up-winamps-music-vi...
50.
by captbaritone 4y ago
Drag and drop also works.
51.
by captbaritone 4y ago
Blog post from when we did the integration: https://blog.archive.org/2018/10/02/dont-click-on-the-llama/
52.
by captbaritone 4y ago
And classic skins! Just drag them in.
53.
by captbaritone 4y ago
Hey! Author of the project here (not op). Happy to answer any questions. The code, and instructions for using it on your own site, can be found here on GitHub: https://github.com/captbaritone/webamp
54.
by captbaritone 4y ago
We do have Dropbox support, but it’s currently disabled while we sort out some theoretical security concerns. Specifically, we let you load Milkdrop visualizer plugins via a query param, but that involves arbitrary js execution. We have a s
55.
by captbaritone 4y ago
Looks similar to Mermaid-js's Gantt chart support: https://mermaid-js.github.io/mermaid/#/gantt Once nice thing about Mermaid is it's built into [GitHub's markdown]( https://github.blog&#x
56.
Defaulting to Empty String Is a Code Smell(jordaneldredge.com)
1 points by captbaritone 4y ago|0 comments
57.
by captbaritone 4y ago
The web audio api code is mostly in this directory: https://github.com/captbaritone/webamp/tree/master/packages/...
58.
by captbaritone 4y ago
Webamp has been used to do something like this: https://winampify.io/ (Required paid Spotify account)
59.
by captbaritone 4y ago
Me too!
60.
by captbaritone 4y ago
Extracted config files are also useful for quickly testing/validating the various parsers that I had to write as part of the Webamp project.

More ›