_jg

3 ms·

1. 1.▲
   by _jg 7y ago

   Should be: 'John@Gıthub.com'.toUpperCase() === 'John@Github.com'.toUpperCase()
2. 2.▲
   by _jg 7y ago

   Our team at Wisdom has done the exact same. It's been confusing at times, but much better once we got going.
3. 3.▲
   by _jg 7y ago

   This was a very real and demonstrated vulnerability. Perhaps I've misunderstood your comment.
4. 4.▲
   by _jg 7y ago

   Unfortunately convention has normalised user expectations that email addresses are now case-insensitive. It's now a standard business requirement. Too bad few devs fully handle Unicode.
5. 5.▲
   by _jg 7y ago

   Yes! Add in a toLowerCase() in there as well. An apparently small deviation with surprisingly large repercussions.
6. 6.▲
   Hacking GitHub's Auth with Unicode's Turkish Dotless 'I'(eng.getwisdom.io)

   370 points by _jg 7y ago|228 comments
7. 7.▲
   JS Console Logs: Putting Up the Christmas “Decorators".(js.getwisdom.io)

   1 points by _jg 7y ago|0 comments