3 ms·
The grammar in this is a bit off. I'll probably submit a pull request with some edits, if that's something people do? I'm not sure about the etiquette surroundi
by M00n_Sl47r 11y ago
The grammar in this is a bit off. I'll probably submit a pull request with some edits, if that's something people do? I'm not sure about the etiquette surrounding grammar mistakes in a github repo.
- creichert 11y agoI think it's a nice gesture as long as you are polite about it. I would be happy that someone read the content and wanted to help improve it.
- jonreem 11y agoPersonally I am always thrilled to get grammar/typo fix pull requests to my projects. It means someone cared enough about the project to go through the effort of making a PR just to alleviate a small aesthetic problem!
- bontoJR 11y agoDefinitely a good habit, I think more than the 50% of Github users are not English as mother tongues, so it's good to polish documentations, or like in this case, long texts. I always accept pull-requests for grammar improvements.
- codezero 11y agoSince I can't code for shit, I submit pull requests to fix grammar and spelling a lot. The reactions are overwhelmingly positive. Just make sure to leave a nice comment.