3 ms·
Maybe I'm weird, but I think whether it works should be #1 concern over design/quality. I agree design/quality is a close #2 though. Also, perhaps you need mor
by howeyc 12y ago
Maybe I'm weird, but I think whether it works should be #1 concern over design/quality. I agree design/quality is a close #2 though.
Also, perhaps you need more practice reading code. So you are not so reliant on a "TEST PASS" output from a tool to know if a particular section of code is likely working.
- jader201 12y agoI certainly agree that whether it meets the requirements is important (debatable whether it's more important than design/quality). I'm just saying it's not the concern of a code review.
- collyw 12y agoAm I the only person who works in a place with very half arsed requirements? I have to take a guess a lot of the time as to what management actually want form what they say. Code quality matters 6 moths later when they say it isn't working (as expected) and I have to check what the code actually is doing.
- deleted 12y ago[deleted]
- matwood 12y agoI would consider works and design/quality to be 1a and 1b, and see them as linked concepts. If the design/quality is poor, it is much harder to prove it works in all cases. Second, generally[1] code is read and edited many more times than it is written. Poorly designed, but working code today is setup to be broken when the first edit comes around. [1] Some code is clearly 1 off and throwaway. This is not the code I'm talking about.