4 ms·
Exactly, don't use subtraction for comparison in C.... when the difference might exceed 2^31. For many data types, like time, that will normally never happen,
by CamperBob2 12y ago
Exactly, don't use subtraction for comparison in C.... when the difference might exceed 2^31.
For many data types, like time, that will normally never happen, making subtraction the safest no-brainpower-needed approach. If in doubt, use the next larger integer type.
- tptacek 12y agoIf you ever want to make a vulnerability researcher drool visibly, have a C programmer say, "that will normally never happen, making ${XXX} the safest no-brainpower-needed approach".
- CamperBob2 12y agoYou know what causes bugs in C (besides memory leaks)? Complex or clever expressions that don't reveal their semantics at first glance. As an example from elsewhere in the thread: return (x > y) - (x < y); Quick. What's that do? What will the next person who looks at the code think it does?
- marvy 12y agoIf it's in a function called "cmp", I think they will guess.
- CamperBob2 12y ago"I think they will guess." I think tptacek must be ready to have his bib changed, with all the drooling he must be doing.
- nitrogen 12y agoA C programmer should know that comparisons evaluate to 1 for true and 0 for false.
- pbsd 12y agoC programmers should also be familiar with carry propagation; I see no reason they shouldn't be expected to work out the correctness of int cmp(int x, int y) { const unsigned a = x; const unsigned b = y; const unsigned s = sizeof x * 8 - 1; return ((b^((b^(b-a))&(a^(b-a))))>>s)&~-((a^((a^(a-b))&(b^(a-b))))>>s)^-((a^((a^(a-b))&(b^(a-b))))>>s)&~-((b^((b^(b-a))&(a^(b-a))))>>s); }
- bluecalm 12y agoThe difference is that: return (x > y) - (x < y); Is a common expression which is very efficient (why else would you write anything in C if you don't care about code being fast/efficient?) and what you proposed is neither.
- CamperBob2 12y agoI write (and read) about 20,000 lines of C(++) a year, and have for the last 20 years. I've never seen that done.
- SamReidHughes 12y agoThat doesn't mean the expression is unreadable. It is still extremely straightforward in what it does.
- dllthomas 12y agoThe real difference is that it's simple. There are only 11 symbols in the expression, only two things that can vary, and only three interesting cases. As opposed to 129 symbols and some large number of interesting cases.
- SamReidHughes 12y agoIt returns 1 - 0 if x > y, 0 - 1 if x < y, and 0 - 0 if x == y. Duh.
- arielby 12y agoActually, with time, the sign of (iXX)((uXX)x-(uXX)y) is the "odometer comparison" of x and y, which handles overflow more gracefully than the typical < comparison.