4 ms·
I think Linus is right in that there is a priori no reason to not accept the code. However, I think he'll change his mind once he actually sees it. If any of
by scscsc 17y ago
I think Linus is right in that there is a priori no reason to not accept the code. However, I think he'll change his mind once he actually sees it.
If any of you had actually looked at the code, you would have seen that it's crap. Even though they removed the weird Win32 coding conventions with lots of CAPS LOCK, UINT32 #define's and stuff, the functions are large and they are simply poorly written. If you look at "native" code, it is much more clean and written in an organized fashion. The MS code looks to be written in a haste, without properly thinking about the problem being solved (in this case, the writing of a driver).
That isn't to say that the code will not be useful, it could be rewritten to be obviously correct instead of it having no obvious bugs.
- jpierce420 17y agoHave you ever seen 'organized and cleanly written' driver code? Have you seen all the crazy #defines in the kernel itself, all the optimized bit hacks and so forth? Its running on the hardware, its low level..it has no choice but to be dirty..its the nitty gritty :P
- rbanffy 17y agoIs there somewhere I can download the code to take a peek into it? I also remember that coding in C++ for Windows CE was not a pleasant experience. Beauty is good and writing beautiful Windows code is next to impossible. C++ code is pretty. C++ code that runs in Windows is, most definitely, not.