4 ms·
Seems not: https://github.com/joyent/libuv/commit/804d40ee14dc0f82c482dcc8d1c41c14333fcb48 https://github.com/joyent/libuv/commit/804d40ee14dc0f82c482d... Ulti
by GrinningFool 13y ago
Seems not: https://github.com/joyent/libuv/commit/804d40ee14dc0f82c482dcc8d1c41c14333fcb48 https://github.com/joyent/libuv/commit/804d40ee14dc0f82c482d...
Ultimately, it looks like Ben was fairly impartial about the whole thing - he didn't accept it because it wasn't a significant enough change to merit accepting. He tried to revert the acceptance because the acceptance had been done without approval.
- Lazare 13y agoTechnically, he was in the right. Politically, reverting Isaac's commit (and especially doing so with a passive aggressive "Isaac, consider yourself chided." commit message) was clearly a mistake.
- GrinningFool 13y agoA mistake, but only in context of the larger issue. In the context of a reverted commit, it was a fairly laid-back way of saying "you shouldn't have done this direct merge and you probably knew better".