4 ms·

Has it been verified that the bug is fixed as in no further database corruption? I'm confused what you mean by this "sample" you got from Gavin.

• MBCook 13y ago
  I assume he meant one of the log/database files that contains the corruption.
  • Aqueous 13y ago
    That's what I initially thought, but then I missed the part where they've confirmed that this fixes the bug. Has this been tested?
    • asdfaoeu 13y ago
      People were reporting it only happens on some installs and takes up to five days to present itself. Considering that this was only released today it seems too premature to confirm that.
      • Aqueous 13y ago
        Whenever I fix a bug I wait for confirmation that the bug has actually been fixed before I submit the patch. Sometimes, especially when fixing race conditions that occur unpredictably, it takes a while to confirm that the bug has been fixed. Not that I'm skeptical - it seems like they're pretty confident that they've fixed it.
• rescrv 13y ago
  Gavin posted a link to some corrupt LevelDB instances here: https://github.com/bitcoin/bitcoin/issues/2770 https://github.com/bitcoin/bitcoin/issues/2770 He also sent the same link to me via email. I took a look at them, and figured out what in the write path could have gone wrong to create the bad behavior. It turned out to be in db/log_writer.cc and deps. I cannot promise there are no other bugs within Bitcoin or LevelDB, but this resolves one issue. I'm interested in seeing it tested in the wide area, just to make sure. Of course, if there are other bugs, I'm just as happy to debug and squash them.