7 ms·
Don't use this for anything you view as important. I just checked and there is no collision detection for usernames. You can signup for an account using any n
by slg 13y ago
Don't use this for anything you view as important. I just checked and there is no collision detection for usernames. You can signup for an account using any name and your account will seemingly just replace the previous created account. That is a big enough and obvious enough flaw that it also makes we wonder if this is just a phishing expedition or a way to mine email addresses.
- colbyaley 13y agoToo good to be true, you ask?
- deleted 13y ago[deleted]
- ErikAugust 13y agoI'm logged in as "www" right now.
- arkitaip 13y agoSorry, I probably overwrote your stuff :/
- slg 13y agoFunny enough, that is exactly how I found the problem. I created a www account (I am almost ashamed to say that was my first instinct, try to break the system before you decide the system is worthy of your use). I ended up logging out and I couldn't log back in with the same password. In hindsight, someone must have created another www account after I did and before I tried to login again. I then tried creating another www account and it worked. I then logged out and tried registering with a different username twice just in case www was a special case. The same thing happened, the second account just replaced the first account.
- the1 13y agohaha I created www account, too.
- sneak 13y ago> I am almost ashamed to say that was my first instinct, try to break the system before you decide the system is worthy of your use I am proud to say that's always my first impulse when thrust into security-related circumstances. http://www.schneier.com/blog/archives/2008/03/the_security_mi_1.html http://www.schneier.com/blog/archives/2008/03/the_security_m...
- zetx 13y agoAh, that explains why my password stopped working ;)
- daviddoran 13y agoI thought david.neocities.org should have been taken, now that you point it out.
- deleted 13y ago[deleted]
- ErikAugust 13y agoIt appears now people have caught on quick - and are replacing sites that people actually worked on with "SITE HACKED" messages. That is pretty frigging mean to exploit such an obvious problem!
- peterwwillis 13y agoCheck out his tweet that started this: https://twitter.com/kyledrake/statuses/337706291801763841 https://twitter.com/kyledrake/statuses/337706291801763841 He started a month ago. The 'Just Ship It' mantra basically declares that crappy bugs like this are A-OK. I don't know why you're surprised.
- krapp 13y agoI'd like to suggest a new mantra: 'Make Sure It Works First Then Ship It'
- kyledrake 13y agoI just fixed it. It was a change I did last night to fix a save bug. My apologies about that, it wasn't a good bug, but hopefully it's the last security-related one. Probably goes without saying, but this is definitely a beta project. I'm doing a lot of other things to protect this kind of attack (filename scrubbing, bcrypt passwords), so I'm pretty red in the face about how dumb this one was. If you find any other bad bugs, please let me know (@kyledrake on Twitter) instead of, you know, trashing other people's work. I'm finding the duplicate sites right now and taking care of it. Thanks, and again my apologies. This is not an email phishing expedition. I don't even require you to enter your email address to make a site.
- clauretano 13y agoNot only does this trigger GeoCities nostalgia, it calls back to the days when betas were really betas.
- bound008 13y agoslg: just make sure you back up your site to multiple floppies and you'll be fine.
- slg 13y agoYou are right, I should have reached out to you directly with this issue. I took the easy route and didn't put in any effort to track you down, for that I am sorry. However, I take exception to you categorizing my post as "trashing other people's work." I feel that I also have a responsibility to publicize such a glaring security hole in your site. This is the number 1 link on HN at the moment. Thousands of people are going to be signing up. I think they have the right to know that a bug like this exists. Like I said in my initial post, a bug this big seemed to be a sign of a bigger problems. I had suspicions the site was malicious and at that point my priority was to point out those suspicions to the HN community.
- revelation 13y agoBack then, this wasn't called collision detection, but proper database design. I can not even begin to fathom how you can inadvertently introduce this by fixing a save bug.
- MarkHarmon 13y agoProper database design does not mean the problem couldn't happen. Consider this scenario. The database has a unique constraint on the name but the code ignores the result and overwrites the directory anyways. It wouldn't cause this exact problem but it is similar.
- deleted 13y ago[deleted]
- hnriot 13y agoClearly you are inexperienced in database design. There are plenty of explanations which if you had a clue would spring to mind.
- asax 13y agoOut of curiosity, can you give an example?
- davidbanham 13y agoThis is not for anything important. It is for blink tags and under construction graphics.
- sneak 13y agoDon't use this for anything you view as important. Hosting that doesn't use a domain name that you control means that when the donation bucket is empty and the service goes under, your traffic and pagerank and brand is now lost forever.