4 ms·
In my view, thread_local is a bit of a code/design red flag. I didn't read the entire code in this case to see whether the thread_local use is warranted or not,
by nnevatie 5mo ago
In my view, thread_local is a bit of a code/design red flag. I didn't read the entire code in this case to see whether the thread_local use is warranted or not, though.
- gpderetta 5mo agoa thread_local is just a global variable. Mutable global variables are of course bad, but in this case the threadindex is immutable once created, so it is perfectly fine.
- nnevatie 5mo agoYes, technically it is of course fine, just as a design I find use of thread_local is more of an afterthought than something I'd prefer.