5 ms·
I think there’s a few of us who appreciate you being up front. I’d question the intent and why it was a mistake, especially when the commit[0] message reverting
by jamesbfb 5mo ago
I think there’s a few of us who appreciate you being up front. I’d question the intent and why it was a mistake, especially when the commit[0] message reverting said functionality states “widespread criticism” citing this very HN article makes it look seemingly like the revert is due to negative PR opposed to a mistake.
[0]https://github.com/microsoft/vscode/pull/313725/commits/1e70c1a7d11c4a43a6b3d4fbaa18b8d64ef62982 https://github.com/microsoft/vscode/pull/313725/commits/1e70...
- l2dy 5mo agoAuthor of that PR doesn't seem to be a Microsoft employee. Keep in mind that anyone on GitHub can create PRs against VSCode.
- lightdot 5mo agoEven if that would be so, the person who approved it certainly is.
- asdfasgasdgasdg 5mo agoThe PR linked to in https://news.ycombinator.com/item?id=47992431 https://news.ycombinator.com/item?id=47992431 is not yet approved as of May 3 4:08 GMT.
- beardbandit 5mo agoAuthor is absolutely from Microsoft https://github.com/microsoft/vscode/pull/310226 https://github.com/microsoft/vscode/pull/310226 https://github.com/cwebster-99 https://github.com/cwebster-99
- kllrnohj 5mo agoThe linked revert PR is not from Microsoft (and also isn't merged)
- politelemon 5mo agoIt is merged
- PinkSheep 5mo agodmitriv recreated in a separate PR and merged that. The linked revert PR by a user was closed.
- ncr100 5mo agoYep - Says he's got a Microsoft.com email address: > "feel free to reach me directly (my alias @microsoft.com) or"
- dmitriv 5mo agoI am reverting it because there are bug in the feature and it obviously does not work as expected. Any feedback is important, HN or not.
- deleted 5mo ago[deleted]
- liendolucas 5mo agoSo, you're reverting because of "bugs", not because you had massive backfire? Do you understand that no one wants this, right?
- deleted 5mo ago[deleted]