4 ms·
The PR type approach comes from the Linux kernel where there is essentially a hierarchy of gatekeepers with increasing trust and responsibility. It is a very in
by osigurdson 1y ago
The PR type approach comes from the Linux kernel where there is essentially a hierarchy of gatekeepers with increasing trust and responsibility. It is a very individualistic type approach (i.e. if you merged it into your branch, it's on you and speed is a non-goal for the most part). This is often different from many software projects as it is like a collective where often, no one really has individual responsibility for anything (it is more like collective responsibility), speed is everything and there are certainly no gate keepers - maybe the review actually doesn't matter that much in this context.
- g-b-r 1y agoIf security or bugs don't matter much for your project, sure
- osigurdson 1y agoI don't think "LGTM" helps with either of those. Making someone personally responsible is the real unlock here.
- g-b-r 1y agoPersonally responsible for the review? For sure if you can say LGTM without even looking at anything it doesn't make much sense