3 ms·
It added intrusive- codebase-wide- functionality that more or less could have been done with other (thread-based) approaches. AWSCLI was broken for over a year
by dekhn 1y ago
It added intrusive- codebase-wide- functionality that more or less could have been done with other (thread-based) approaches.
AWSCLI was broken for over a year- we had to do a ton of work to deal with the various packaging issues.
Don't break userspace.
- AtlasBarfed 1y agoWhy was awscli written in python? Bad decision to begin with. Hey! We have a product that we clearly want to release worldwide. Let's build it on something that doesn't have Unicode. Or any real threading. And is slow as hell. You picked a platform that was going to have to break user space. At least it wasn't JavaScript
- fzzzy 1y agoDoesn’t have Unicode? What the heck?
- mdaniel 1y agoI believe they're discussing that awscli was targeting Python 2.x for the longest time, e.g. https://github.com/aws/aws-cli/blob/0.4.1/setup.py#L48 https://github.com/aws/aws-cli/blob/0.4.1/setup.py#L48 up through https://github.com/aws/aws-cli/blob/1.19.112/setup.py#L64 https://github.com/aws/aws-cli/blob/1.19.112/setup.py#L64 from 4 years ago, seemingly cutting over to Py3-only starting with https://github.com/aws/aws-cli/blob/1.20.0/setup.py#L62 https://github.com/aws/aws-cli/blob/1.20.0/setup.py#L62 I didn't go digging into it, but I'd guess they used the ubiquitous "six" library for backporting unicode functionality, but the point is likely "but why start underwater?!"
- mdaniel 1y agoI guess at least they're consistent (or maybe herd mentality) since both azure-cli and gcloud are both in python, too
- mdaniel 1y agobut, hey, at least they get to be ultimately dynamic, leading to horeshit like this https://github.com/aws/aws-cli/blob/2.28.22/awscli/botocore/client.py#L98-L109 https://github.com/aws/aws-cli/blob/2.28.22/awscli/botocore/... What does `create_client` return?! don't you worry your pretty head about it, it'll be whatever you want it to be! flexability!!11