3 ms·
I commend the author for building something. I don't see this project solving a problem I have, but it looks to be an honest, if somewhat rough, effort. A few
by harold 14y ago
I commend the author for building something. I don't see this project solving a problem I have, but it looks to be an honest, if somewhat rough, effort.
A few suggestions:
- review PEP8 [1].
- no need to assign None to a variable before assigning another value
- Try to keep things DRY [2].
- use more descriptive variable names
- as others have stated, spell check your site copy
[1] http://www.python.org/dev/peps/pep-0008/ http://www.python.org/dev/peps/pep-0008/
[2] http://c2.com/cgi/wiki?DontRepeatYourself http://c2.com/cgi/wiki?DontRepeatYourself
* edited for formatting
- pythononwheels 14y agoPep8 => yes, need to review / rewrite Dry => again yes, working currently on it for generate_* did you look at some genrated code, think this is cleaner, though. The generators are the oldest .. Thx, khz