4 ms·
It's a very broad question. Practically, if a PR comes in and it's either a one-shot script or something small, I wouldn't bother too much about anything as lo
by ferguess_k 2y ago
It's a very broad question.
Practically, if a PR comes in and it's either a one-shot script or something small, I wouldn't bother too much about anything as long as it works and doesn't smell really bad (e.g. every variable is of single character).
But it's another story if 1) the code is entangled with business logic, or 2) it's part of a medium-large project. In case of those I'd demand very detailed documentation and passing some linter at least.