5 ms·

Mathesar repo is heavily optimized for commit count. Large number of commits are spelling/padding changes. This should set off alarm bells for anything looking

Mathesar repo is heavily optimized for commit count. Large number of commits are spelling/padding changes. This should set off alarm bells for anything looking to use this.

sophacles 2y ago
Why is lots of little commits a problem? How is that evidence of optimizing for commit count as opposed to lots of people submitting PRs to cover low hanging fruit? What does optimizing for commit count achieve for anyone? In what context does "lots of commits" gain someone enough value to optimize for it?
mpalmer 2y ago
Read the code, not tea leaves
- peppertree 2y ago
  Project activity is indicative of whether it will be supported in the long run. The fact that Mathesar's admin hid the line change count under insights, and padded the commits looks like a feeble attempt to impress investors.
  - kgodey 2y ago
    Well, we're a nonprofit, we don't have investors :) Also, I'm pretty sure any investor who cared about commit counts would be a terrible investor.
    - peppertree 2y ago
      Let’s be transparent and unhide the line change count under your insights tab.
      - gjvc 2y ago
        Let's not pretend to care about how someone uses their tools.
      - kgodey 2y ago
        If you're referring to the line count being omitted here: https://github.com/mathesar-foundation/mathesar/graphs/contributors https://github.com/mathesar-foundation/mathesar/graphs/contr..., please submit your feedback to the GitHub product team, we have no say in their decision. There are some other complaints about that decision here: https://github.com/orgs/community/discussions/135572 https://github.com/orgs/community/discussions/135572
zackdotcat 2y ago
These are bizarre claims. Go look at the commits. It's quite reasonable for a serious software project to have a feature freeze and lots of documentation-related optimizations before a release. If you go back about a week, all of the commits relate to adding and modifying app functionality.
add-sub-mul-div 2y ago
This site, man.

Mathesar repo is heavily optimized for commit count. Large number of commits are spelling/padding changes. This should set off alarm bells for anything looking to use this.

sophacles 2y ago

Why is lots of little commits a problem? How is that evidence of optimizing for commit count as opposed to lots of people submitting PRs to cover low hanging fruit? What does optimizing for commit count achieve for anyone? In what context does "lots of commits" gain someone enough value to optimize for it?

mpalmer 2y ago

Read the code, not tea leaves

peppertree 2y ago
Project activity is indicative of whether it will be supported in the long run. The fact that Mathesar's admin hid the line change count under insights, and padded the commits looks like a feeble attempt to impress investors.
- kgodey 2y ago
  Well, we're a nonprofit, we don't have investors :) Also, I'm pretty sure any investor who cared about commit counts would be a terrible investor.
  - peppertree 2y ago
    Let’s be transparent and unhide the line change count under your insights tab.
    - gjvc 2y ago
      Let's not pretend to care about how someone uses their tools.
    - kgodey 2y ago
      If you're referring to the line count being omitted here: https://github.com/mathesar-foundation/mathesar/graphs/contributors https://github.com/mathesar-foundation/mathesar/graphs/contr..., please submit your feedback to the GitHub product team, we have no say in their decision. There are some other complaints about that decision here: https://github.com/orgs/community/discussions/135572 https://github.com/orgs/community/discussions/135572

zackdotcat 2y ago

These are bizarre claims. Go look at the commits. It's quite reasonable for a serious software project to have a feature freeze and lots of documentation-related optimizations before a release. If you go back about a week, all of the commits relate to adding and modifying app functionality.

add-sub-mul-div 2y ago

This site, man.