3 ms·
That’s why you hook the linter up so it runs on every commit / push. No need to ask, it always runs. And no need to quibble over style. Don’t like it? Change th
by plasticchris 2y ago
That’s why you hook the linter up so it runs on every commit / push. No need to ask, it always runs. And no need to quibble over style. Don’t like it? Change the linter.
- Aeolun 2y agoI very much dislike any process modifying my commit after I submit it. Rebasing becomes hell.
- plasticchris 2y agorun it in a hook that runs before the commit is made
- cempaka 2y agoYeah we just have any linter failures fail the CI build, but it's left up to submitters to decide how to resolve the violations.
- plasticchris 2y agoYeah, that’s what I meant in the first comment :)
- move-on-by 2y agoI agree that it should be hooked up to run as a precommit hook, but unfortunately that doesn’t always solve things. People can- and do- bypass precommit hooks. It happens all the time at my company with certain teams, but I’ve been unable to figure out why. Any precommit hook that should run- needs a correlating required PR action to verify any precommit expectations are met. Otherwise, people reviewing the PRs just assume it ran and the people bypassing it get away with it.
- cced 2y agoCreate a linting step that fails if running the linter creates a git diff delta.