4 ms·
Didn't say MFA, said state of username / password (useState is fine for that). Also said "use hooks", not "don't use hooks" and never said don't re-use functio
by bschmidt1 2y ago
Didn't say MFA, said state of username / password (useState is fine for that).
Also said "use hooks", not "don't use hooks" and never said don't re-use functions.
Would hate to be on that team, I bet those PRs are brutal.
- orwin 2y agoExactly what I meant to say, as soon as you have to add complexity, just adding useState over and over breaks, and that's what I call bad code. It's fine if it's just a get in a component out of the way, we do not use a reducer to print our 'about' page, but typically the login is where a lot of logic has to happen. I think I misunderstood your comment, you talked about a global manager and I thought you talked about our library. And since we pair/mob program often enough (10 hours a week roughly, per affinity or when someone ask for help), our PR meetings are more a way to show off to the whole team a new idea or present library upgrades, but it's true that we are quite brutal, especially when i compare with my previous job where I worked with Indians and north Americans, I think it is cultural though.