2 ms·
> You can only operate in this mode for at best 2-3 months before your entire SDLC grinds to a halt because it's been the wild west in github FB is operating t
by herval 2y ago
> You can only operate in this mode for at best 2-3 months before your entire SDLC grinds to a halt because it's been the wild west in github
FB is operating that way with tens of thousands of engineers. More approval layers don’t necessarily mean more order, but it always means slower processes
- debacle 2y agoFacebook has a very thorough code review process, and their product is heavily data driven. They've even productized their code review process internally, and that product is also data driven.
- herval 2y agoThe code review process is quite literally “you need a stamp from anyone because of some regulations we follow”. Definitely nothing thorough.
- XorNot 2y agoThe seriousness of any code review process can be determined by whether it diffuses liability from the original code author for any bugs. So far in my career this has never been the case.
- Aeolun 2y agoI think we do, to some extend. As the TL, when I’ve reviewed their PR I’m definitely not going to blame them for the bugs I missed during review. They’ll still have to fix them, because that’s just most efficient.
- toast0 2y agoYou can operate anyway you want if you have a printing press for money in the back. It's not a model to follow when you've got constraints.