4 ms·
At my place, I would complain about your code in code review. Because https://youtu.be/9L3M2WC5LPA https://youtu.be/9L3M2WC5LPA And I've trained people who hav
by shrimp_emoji 2y ago
At my place, I would complain about your code in code review. Because https://youtu.be/9L3M2WC5LPA https://youtu.be/9L3M2WC5LPA
And I've trained people who have been writing bad code into writing better code and into delaying all merge requests by also complaining about bad code! >:]
I'd be pretty depressed if I worked somewhere this weren't the case. So it sounds like either your workplace culture is very bad or like mine is very good. (I don't know how common either case is.)
- shittycoder 2y agoI really like to code, as well as being reviewed or doing code reviews. However, when I try to do code reviews, most of the time I receive comments like 'We do not have time' or 'We can fix it later' or 'This task is just a bug fix'. The problems isn't about caring; I care about the code I write, but when you care, it takes time. When you need time to do things right, this isn't reflected in your performance. I experimented with being like others who don't care much and just do the task as needed, no more. Then I realized improvements in my performance :D.