3 ms·
> Though indentation changes are something I prefer to avoid by using autoformatters. Well when you extract a function, add an if, loop, or do any number of ot
by g-b-r 2y ago
> Though indentation changes are something I prefer to avoid by using autoformatters.
Well when you extract a function, add an if, loop, or do any number of other things, you can't avoid changing the indentation (unless you want to leave a mess)
- philwelch 2y agoSure, and if you also change the logic inside that loop, I don’t think the combined diff ends up being “jumbled” or misleading at all. Also you can hide whitespace changes.
- g-b-r 2y agoEven with hiding whitespace changes, the differences often don't get recognized correctly. Rather then misleading, the diffs are much harder to check, instead of showing that only white space changed (or in general, rather than highlighting only the actual thing that was changed). Basically, it's little additional work which guarantees simpler reviews for everyone, I think it's warranted