3 ms·
Nifty, but it seems like this would lose commit message content and history entirely during the course of the review since you have to submit a single patch tha
by EPWN3D 2y ago
Nifty, but it seems like this would lose commit message content and history entirely during the course of the review since you have to submit a single patch that gets applied, rather than publishing commits to a branch that gets merged. Am I understanding correctly?
- beepbooptheory 2y agoGithub also squashes the commits of a PR before it merges/rebases it onto a branch though.
- maxicarlos08 2y agoNot necessarily, there are different ways of merging a PR in github
- qudat 2y agoNot quite. We have adapted the `git format-patch | git send-email` flow to support editing the patchset. You can add, remove, even `--force` replace all patches within a patch request. The goal is to provide the flexibility of a pull request with the simplicity of generating patches. At the end of the day, the maintainer of the repo has to load the patchset locally, apply it, fix it up, then push to upstream. They have full control here.