4 ms·

Apparently it's a workaround until https://bugs.webkit.org/show_bug.cgi?id=275223 https://bugs.webkit.org/show_bug.cgi?id=275223 is understood and fixed. Seems

by jraph 2y ago

Apparently it's a workaround until https://bugs.webkit.org/show_bug.cgi?id=275223 https://bugs.webkit.org/show_bug.cgi?id=275223 is understood and fixed. Seems more reasonable than how it looked at first.

onion2k 2y ago
This is an example of somewhere a comment would actually have been useful.
- nightpool 2y ago
  I mean, it's explained very clearly in the commit message that's linked? Since the page where the bug manifests itself already has responsive CSS styling, we can quirk TextAutoSizing to skip adjusting for it, at least until we figure out why we are calculating RenderBlockFlow width inconsistently: https://bugs.webkit.org/show_bug.cgi?id=275223 That's even better than a comment, because you can git blame for it and get the full context of the issue (from the bug thread that proposed it to all of the documentation of the investigation done for both bugs)
  - freedomben 2y ago
    I very much disagree that it's better than a comment. The git blame log will over time get layered on as changes are made to various lines, meaning you have to dive for the original message, assuming one is even there (many a time I dig for commits, only to see that the commit message doesn't answer the question of motivation very well or at all). A short comment in the code makes it obvious.
alex3305 2y ago
Is this the reason that Chromium based browsers always change font sizes for me on here? Since I'm visually impaired and have set my text sizing pretty large, I have that issue on multiple sites, including Hacker News. It's a bit of a gamble how large text will be when I refresh the page.
- layer8 2y ago
  I have experienced the same on other sites as well, with large text size. It sounds like this bug could fit.
- refulgentis 2y ago
  Interesting Q, I've used it at 140% in stock Chrome, for about a year, and haven't noticed an issue on refresh, but...idk, I feel like I did once a couple weeks ago. Can't trigger it now though

by jraph 2y ago

onion2k 2y ago

This is an example of somewhere a comment would actually have been useful.

nightpool 2y ago
I mean, it's explained very clearly in the commit message that's linked? Since the page where the bug manifests itself already has responsive CSS styling, we can quirk TextAutoSizing to skip adjusting for it, at least until we figure out why we are calculating RenderBlockFlow width inconsistently: https://bugs.webkit.org/show_bug.cgi?id=275223 That's even better than a comment, because you can git blame for it and get the full context of the issue (from the bug thread that proposed it to all of the documentation of the investigation done for both bugs)
- freedomben 2y ago
  I very much disagree that it's better than a comment. The git blame log will over time get layered on as changes are made to various lines, meaning you have to dive for the original message, assuming one is even there (many a time I dig for commits, only to see that the commit message doesn't answer the question of motivation very well or at all). A short comment in the code makes it obvious.

alex3305 2y ago

Is this the reason that Chromium based browsers always change font sizes for me on here? Since I'm visually impaired and have set my text sizing pretty large, I have that issue on multiple sites, including Hacker News. It's a bit of a gamble how large text will be when I refresh the page.

layer8 2y ago
I have experienced the same on other sites as well, with large text size. It sounds like this bug could fit.
refulgentis 2y ago
Interesting Q, I've used it at 140% in stock Chrome, for about a year, and haven't noticed an issue on refresh, but...idk, I feel like I did once a couple weeks ago. Can't trigger it now though