4 ms·

Pyright is the Microsoft provided lsp: does anyone else feel uneasy about using this? Especially given the EEE playbook "that we definitely won't do this time"

Pyright is the Microsoft provided lsp: does anyone else feel uneasy about using this? Especially given the EEE playbook "that we definitely won't do this time" - would love to have a discussion on this if someone could talk me into using it. I just use a combination of black, flake, and mypy. Apparently ruff is quite good as well. For lsp I use Jedi, which actually worked faster on my company's code base than pyright, a year or so ago.

tentacleuno 3y ago
Can the extension be used on VSCodium builds? If memory serves, C# tooling extensions are proprietary and are subject to unfortunate treatment when using open-source builds of VSCode.
- giantzoc 3y ago
  You are correct. It is not supported on vscodium.
  - mdasen 3y ago
    Yea, and if you're a company making more than $1M in revenue or have over 250 PCs, then you need a commercial license. Microsoft definitely seems to be pushing proprietary VSCode extensions where it's free to get users hooked on the product (and kill competitors) and then charge companies lots of money for the tools they got everyone hooked on because they appeared to be free.
    - mastazi 3y ago
      are you talking about Pyright or Pylance?
      - Vuizur 3y ago
        He's talking about the new C# extension, Pyright and Pylance are free for everyone.
- mastazi 3y ago
  Pyright works for me on VSCodium, Pylance doesn't.
ZiiS 3y ago
Pylance is their proprietary LSP; pyright is an opensource (but MS managed) typechecker (which pylance uses).
vosper 3y ago
How do you imagine that EEE could be applied to a type checker?
- IshKebab 3y ago
  Well Pylance is already closed source so basically the plan is: 1. Make a really great type checker. 2. Make it difficult to use in IDEs other than VSCode. 3. Everyone uses VSCode. I don't care though. Pyright is fantastic and giving it away for free is amazing even if it is part of a plan to push people to VSCode.
xaberus 3y ago
A slight correction: Pyright is the Microsoft provided _type checker_. Eric had no intention of ever extending it to a full LSP (though it is usually good enough) in fear of Microsoft abandoning it the moment it started to compete with Pylance [1]. Now that Eric has left Microsoft (but still is somehow the main contributor to Pyright) the situation is even stranger to me. [1] https://github.com/microsoft/pyright/pull/7177#issuecomment-1920682424 https://github.com/microsoft/pyright/pull/7177#issuecomment-... (In case you are wondering, I do not have the time to maintain an independent fork and I am not sure how Microsoft would react to one, now that I have heard Eric's concerns.)
screye 3y ago
This version of Microsoft has learnt from the mistakes of its predecessor, coming up with an even more potent model for making money. "Embrace + extend + embed" makes more money than "embrace + extend + extinguish". As long as Microsft controls the data (your vscode actions), they have no need to explicitly destroy their competitors. The data skew gives them a natural advantage. I don't trust their intentions, but I do trust the well-aligned monetary incentives.

tentacleuno 3y ago

Can the extension be used on VSCodium builds? If memory serves, C# tooling extensions are proprietary and are subject to unfortunate treatment when using open-source builds of VSCode.

giantzoc 3y ago
You are correct. It is not supported on vscodium.
- mdasen 3y ago
  Yea, and if you're a company making more than $1M in revenue or have over 250 PCs, then you need a commercial license. Microsoft definitely seems to be pushing proprietary VSCode extensions where it's free to get users hooked on the product (and kill competitors) and then charge companies lots of money for the tools they got everyone hooked on because they appeared to be free.
  - mastazi 3y ago
    are you talking about Pyright or Pylance?
    - Vuizur 3y ago
      He's talking about the new C# extension, Pyright and Pylance are free for everyone.
mastazi 3y ago
Pyright works for me on VSCodium, Pylance doesn't.

ZiiS 3y ago

Pylance is their proprietary LSP; pyright is an opensource (but MS managed) typechecker (which pylance uses).

vosper 3y ago

How do you imagine that EEE could be applied to a type checker?

IshKebab 3y ago
Well Pylance is already closed source so basically the plan is: 1. Make a really great type checker. 2. Make it difficult to use in IDEs other than VSCode. 3. Everyone uses VSCode. I don't care though. Pyright is fantastic and giving it away for free is amazing even if it is part of a plan to push people to VSCode.

xaberus 3y ago

A slight correction: Pyright is the Microsoft provided _type checker_. Eric had no intention of ever extending it to a full LSP (though it is usually good enough) in fear of Microsoft abandoning it the moment it started to compete with Pylance [1]. Now that Eric has left Microsoft (but still is somehow the main contributor to Pyright) the situation is even stranger to me. [1] https://github.com/microsoft/pyright/pull/7177#issuecomment-1920682424 https://github.com/microsoft/pyright/pull/7177#issuecomment-... (In case you are wondering, I do not have the time to maintain an independent fork and I am not sure how Microsoft would react to one, now that I have heard Eric's concerns.)

screye 3y ago

This version of Microsoft has learnt from the mistakes of its predecessor, coming up with an even more potent model for making money. "Embrace + extend + embed" makes more money than "embrace + extend + extinguish". As long as Microsft controls the data (your vscode actions), they have no need to explicitly destroy their competitors. The data skew gives them a natural advantage. I don't trust their intentions, but I do trust the well-aligned monetary incentives.