4 ms·
# Concern that overrides the Devise methods # to send reset password instructions to any verified user email module RecoverableByAnyEmail So it was a f
by taspeotis 3y ago
# Concern that overrides the Devise methods
# to send reset password instructions to any verified user email
module RecoverableByAnyEmail
So it was a feature??
Anyway, in the fixed version it's still called RecoverableByAnyEmail. Do people not read the code around what they are changing??
- BandButcher 3y agohaha the first thing i would've caught in the initial PR was the file name... and the default setting of `confirmed: true`... seems like a big oversight or possibly an inside job (if im being conspiratorial)
- Rapzid 3y agoIt does say any email doesn't it? Not verified, any.
- zx8080 3y ago> "RecoverableByAnyEmail" Added 8 months ago [1]. And then one month later: > "password_reset_any_verified_email" Was removed. 7 months ago [2], *note* __verified__ word here. No blaming or conspiracy intended in this post, just listing links to relevant commits. 1 - https://gitlab.com/gitlab-org/gitlab/-/commit/94069d38c9cd63202cc21e7febfaaad596052c0d https://gitlab.com/gitlab-org/gitlab/-/commit/94069d38c9cd63... 2 - https://gitlab.com/gitlab-org/gitlab/-/commit/a935d28f3decf8f6873d5b0a6f405f2687d0f99f https://gitlab.com/gitlab-org/gitlab/-/commit/a935d28f3decf8...