4 ms·
No change is minor enough that you don't need to explain what it does. If the commit message is "fix indentation" then I will ignore it and skip over it while
by lexicality 3y ago
No change is minor enough that you don't need to explain what it does.
If the commit message is "fix indentation" then I will ignore it and skip over it while searching the commit history. If it's "minor" or "fix" then I have to open the commit and look to see what it actually is.
These "minor cookies" add up rapidly.
(side note, people that squash important changes together are also on The List)
- cerved 3y agoLet's not forget people that commit trailing whitespace, or different line-endings. Can we put those on a separate List?
- Vinnl 3y agoTo be fair, we've got computers (CI, pre-commit hooks) that can stop that.
- sgarland 3y agoTo be pragmatic, the number of times I’ve had to fix or outright create CI for other teams because they didn’t bother to add these basics is too damn high. For anything with my team (or personal projects), where I can be guaranteed everyone understands exactly what I’ve set up, I add a pre-commit hook to fix minor linting issues and then add the change to the commit. If black, tf fmt, shfmt, etc. can just fix the problem, then do so, and don’t bother asking me if I’m sure.
- Aeolun 3y agoI love the ‘merge commit for my feature branch with 100 commits, but squash for merging release branch to master’ type. It’s as if a thousand commits cried out in anguish and were suddenly silenced.