4 ms·
I feel like this comment could be best structured in the form of a series of commits sent as a combined Merge Request. First, a commit to change the docs to sa
by dekhn 3y ago
I feel like this comment could be best structured in the form of a series of commits sent as a combined Merge Request.
First, a commit to change the docs to say it's a pure C99 (or C11 or C17) implementation.
Second, for each of your points, a single commit fixing each style issue (_dispose -> _destroy, typedefs).
Seperately, another MR with the commit for _select improvements.
Or maybe just send the C99 one first, and if that gets rejected, don't bother with the rest.