3 ms·
sure everyone should be able to change the code, but somebody is immediately refactoring new code to align with their own opinions and making it worse in the pr
by yungporko 3y ago
sure everyone should be able to change the code, but somebody is immediately refactoring new code to align with their own opinions and making it worse in the process is not ok. i would immediately revert the commit if somebody did that to me (and then tell them why of course)
- gardenhedge 3y agoDid that to _you_ or did that to the shared code? I think that is the point being made.
- yungporko 3y agowell obviously both, but it just isn't a very good point. by making changes to the shared code in that specific way, you are undermining and insulting the developer who is supposed to be part of your team. you can't just pretend that the team aren't humans and that social conventions and etiquette don't apply.
- ludovicianul 3y agoContext is very important. If this happens overnight and out of nowhere/excess pro-activity, it's definitely an issue. But the reality is usually more nuanced. Even saying that because of this particular situation clean code is bad, it's an exageration.