3 ms·
You can do that in Github, but for some reason a lot of reviewers are not familiar or bother doing that. Fixing nits that way or giving a suggestion improves tu
by eftychis 3y ago
You can do that in Github, but for some reason a lot of reviewers are not familiar or bother doing that. Fixing nits that way or giving a suggestion improves turnaround speed greatly and builds a relationship between reviewer and proposer and the final product/commit(s).
- bbu 3y agoIt’s not integrated well into the UI and thus a big hassle to use. Much easier to just checkout the branch and create a commit (or just write a comment…)
- yohannparis 3y agoYes, I have been "suggesting" a lot of one liners, typo, rephrasing, or just simple clean up of code with it. Make it a breeze, it's like playing tidy-up without having to branch out or bother much the author.
- froh 3y agoI feel stupid. How do I do this?
- mplanchard 3y agoWhen writing an inline comment, there’s a button to make a suggestion. It inserts a markdown code fence with the existing code on the line(s), which you can edit. When you submit the comment, it shows up with diff highlighting and can be applied by the author with one click. Essentially the same thing exists in both GitHub and GitLab
- froh 3y agoah yes! duh. and thanks. I need better glasses...
- Tempest1981 3y agoA lot of folks didn't know it was there. It's just 1 of many icons, and tbh, I'm not sure when the feature got added.