3 ms·
Say I've decided in my project that shadowing is evil. Why wouldn't I turn on -Werror=shadow? Where is the bad idea? Including downstream. I don't want people
by kazinator 3y ago
Say I've decided in my project that shadowing is evil. Why wouldn't I turn on -Werror=shadow? Where is the bad idea?
Including downstream. I don't want people writing me patches that trigger my pet warnings.
This is entirely compatible with the idea of locally only turning on -Werror, and then disabling certain warnings that you don't intend to fix, without foisting -Werror onto downstream.
You can still have non-negotiable warnings that you turn on rather than off, and those do go downstream too.
- IshKebab 3y ago> I don't want people writing me patches that trigger my pet warnings. They will fail your CI. There's no issue.
- kazinator 3y agoSure, other than that the patch compiles fine on their end, and the diagnostic is not something you are willing to disable, or address with an additional code change on top of their patch. It's better if the deal-breaker diagnostics are on for everyone, so that everyone is working in the same programming language dialect.