3 ms·
I consider it a great first contribution. Dude took initiative at his job to try to make his and his teammates' lives easier, investigated a super technical iss
by camgunz 3y ago
I consider it a great first contribution. Dude took initiative at his job to try to make his and his teammates' lives easier, investigated a super technical issue, found prior art and built on it, sought help on the list, and tried to shepherd it to get it merged. It was significant effort, and he in no way had to do it. He definitely didn't need to upstream it.
The amount of energy wasted in this thread on the meaning of "contributor" could boil me water for tea. Bewildering, honestly.
- yencabulator 3y agoReporting a security issue is not the place for seeking help on the list and shepherding. The idea behind the patch was written simpler by others because the original patch was both technically unacceptable to the maintainer and not cleared for inclusion in the kernel (no Signed-off-by).
- camgunz 3y agoHe posted to security out of an abundance of caution, but it's hard to see how this could be a significant security issue. Feels unfair to punish him for being considerate here. Also kernel workflows are not intuitive. I don't have any idea what signed-off-by is or how to get it. Don't you post to the list? What else would you do? Would it have been better for Miculas to spend time researching kernel workflows while this "security issue" remained unpatched? Feels like there's not really a way for him to win here. > original patch was both technically unacceptable to the maintainer and not cleared for inclusion in the kernel (no Signed-off-by) Crediting as a co-author is a good compromise here, I would say.