4 ms·
> There is nothing wrong with being motivated by getting credit. They did get the credit, just not for the code, and rightly so. If the goal is to fix somethi
by jacquesm 3y ago
> There is nothing wrong with being motivated by getting credit.
They did get the credit, just not for the code, and rightly so.
If the goal is to fix something to be able to put kernel contributor on your resume with a mediocre contribution in order to achieve yet another goal then that's not a good reason to be credited for the code, especially if it isn't your work that makes it into the kernel, more so if it is posted as a security issue which get special treatment and a whole pile of extra review to make sure that the fix doesn't introduce yet another problem.
This is several levels above people that work their way into OSS projects in order to gain visibility by fixing a lot of trivial issues, clearly some work went into this. But the motivation isn't clean and if you care more about the credit than you do about the fix then clearly you have your priorities mixed up, especially if you want to do security work where the details really matter, so props for identifying the issue, but no medal for delivering something that didn't meet the bar for inclusion. And that last bit is where 'kernel contributor' comes in. The whole 'robbed' angle is an interesting one, it appears that there is a much higher perceived value than the one that is normally associated with getting an issue fixed (which is what most people would like to see). Perverse incentives are a thing and it is good to be aware of them.
> The value of FOSS is fixing a problem once for everyone.
No, the value of FOSS is the ability to read and modify the source code.
> Linus Torvalds himself had questionable attitude at times.
Whether Linus has had questionable attitude at times is immaterial: clearly he was a contributor and so is credited. This person did not contribute as of now. You see the same with YC and pretty much anything that people would like to have on their resume: the thing itself is less important than the CV mention.
> have hurt for doing all the analysis, even if the patch itself got completely rewritten?
That there are many more implications for being allowed to call yourself an author. The kernel contributors are doing very important work and their standards for inclusion are high. You don't make it into that circle without adopting their standards.
- disintegore 3y ago> They did get the credit, just not for the code, and rightly so. They received credit for reporting the issue, which is a fraction of what they did. They provided the entire solution, full stop. The maintainer only restated it.
- jacquesm 3y agoThat's because it is a tiny fix. To ask for credit as a contributor makes it seem as though that was the whole goal and that's why the OP feels 'robbed' as though this is a thing of great value that has been taken away from them. That's not how I interpret the contents of the exchange: https://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg221962.html https://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/m... Could the kernel maintainer have handled this better? Probably yes. Was the OP robbed? In my opinion, no, their work was credited and the fix is so small it doesn't warrant elevating the OP to 'Kernel contributor' which is typically reserved for more substantial contributions, not bug fixes of a few lines. Another comment has a nice middle ground in the form of the 'Suggested-by' tag which I think would have been an improvement. I've got a little project on the go and I'm meticulous about crediting people but the context is entirely different there, nobody is going to hold up my project to claim they are a contributor on their CV so I'm fine with the kernel maintainers keeping the list of 'kernel contributors' manageable.
- mfru 3y agoAfter how many lines of someone contributing code to the kernel are they considered to be a >kernel contributor<? How is fixing bugs not a contribution?
- scruple 3y agoThis entire attitude around denying attribution is unreal. I see it in industry all of the time, especially now that I'm in gamesdev. People pull out all of the stops to prevent certain people or even certain disciplines from receiving credit for their efforts. It's abysmal.
- junofan 3y agoWhat’s the incentive here? It seems more likely it just wasn’t a concern to the maintainers. The guy can still call himself a Linux contributor if he wants. He submitted a couple if statements and didn’t get it signed off. Why split hairs over what the commit message says?
- couchand 3y ago> But the motivation isn't clean and if you care more about the credit than you do about the fix then clearly you have your priorities mixed up I'd suggest not opining on the inner motivations of strangers on the internet. It doesn't add value to this conversation, and your guesses are likely wrong due to missing important context and details.
- jacquesm 3y agoIt's there for everybody to read, as well as in comments here, I'm not guessing at anything. You can't be 'robbed' of something you do not already have. And that's before we get into misrepresenting the kernel maintainers words in a way that considerably changes their meaning.
- deleted 3y ago[deleted]
- marktucker 3y agoMaybe you’re not a native English speaker? “Getting robbed” can also mean not getting something you are justly deserved.
- jacquesm 3y ago> can also mean not getting something you are justly deserved. It can, but whether that's the case here or not is debatable and I think what we mostly see here is the OPs unfamiliarity with how LKML deals with tiny patches mailed to the security lists.
- JimDabell 3y ago> It's there for everybody to read Yes, it is. His motivation is very clear: > Around a year and a half ago, I’ve asked my former company for some time to work on an issue that was impacting the debugging capabilities in our project: gdbserver couldn’t debug multithreaded applications running on a PowerPC32 architecture. The connection to the gdbserver was broken and it couldn’t control the debug session anymore. This is an incredibly uncharitable description of his motivation: > If the goal is to fix something to be able to put kernel contributor on your resume
- NBJack 3y ago"That circle"? You make it sound like an exclusive club for the elite. This isn't supposed to be a popularity contest. Linus' attitude is very material. Kernel leadership sets the stage for other contributors to do the same, good or bad.
- jacquesm 3y agoLinus' attitude has nothing to do with it, he wasn't part of this exchange at all. And yes, it's an exclusive club, hence people trying to become a part of it.
- mfru 3y agoOpen source software development is not an exclusive club. If you contribute to open source software you are an open source contributor. Stop gatekeeping.
- jacquesm 3y agoSecurity patches are the last place (especially tiny ones) where you want to make a stand for proper attribution of four line patches, the rest got properly credited. Note that the OP misrepresented the nature of the exchange with the kernel maintainer and that puts their motivation about the whole thing in doubt. Nobody got robbed. OP still has contributed code, the LKML lists are proof of that and if you think that in the future every such patch should carry an automatic 'Suggested-by' or 'Coauthored-by' tag then you could propose that. But for now this is the maintainers call and by sending mail to the LKML you play by their rules. That's not gatekeeping, that's just reality, and yes, kernel maintainers are an in-group whether we like it or not. My take on that is that if I had stuff that gets included that I couldn't care less about the attribution because what they give me is so much more than I'll ever be able to give back. Of course everybody is welcome to their own motivations, but you send unsolicited patches with the hope that they'll be used, if you get credit that's great but then the patch had better be ready to run as is and preferably for something a bit more substantial.
- carapace 3y ago
- f3d46600-b66e 3y agoI will point out that finding and root causing a bug (and perhaps writing a test) is THE contribution. Very often fixing the bug, once all unknowns have been resolved, is trivial. Many times a one line fix takes days off debugging and analysis. Seems like this was the case here, since the original bug was open for 6 years.
- jacquesm 3y agoAnd indeed, they received the proper accreditation for that. As well as the mailing list entries which are there for all to see.
- bitcharmer 3y ago"Reported-by" reads like: "this person mentioned the problem to us". In this case he did all the heavy lifting which is like 95% of the work. How is reported-by a proper accreditation? I feel like many commenters here never had to debug any complex or subtle, hard-to reproduce bugs. Either that or there are many assholes on this site.
- jacquesm 3y agoWell, maybe there should be a 'contributed an improperly signed patch with issues' tag that would cover the situation. But in the case of mailing to a security list your general expectations should be to hope that it will be included, and hopefully speedily.
- deleted 3y ago[deleted]
- DeepSeaTortoise 3y agoThis comment is so far off the charts, even I, a pathological lurker, made an account... Let me see if I get the ranking right: > But the motivation isn't clean > The kernel contributors are doing very important work and their standards for inclusion are high. > security work where the details really matter, so props for identifying the issue > Perverse incentives are a thing and it is good to be aware of them. > with a mediocre contribution >This is several levels above people that work their way into OSS projects in order to gain visibility by fixing a lot of trivial issues I wonder where normal people fit into this mental framework. Contributors with pure thoughts <?> Kernel contributor > Security Contributors > Perverse contributors <?> Mediocre contributors > > People who sneak into OSS projects by fixing minor issues
- haswell 3y ago> If the goal is to fix something to be able to put kernel contributor on your resume with a mediocre contribution in order to achieve yet another goal then that's not a good reason to be credited for the code, especially if it isn't your work that makes it into the kernel Someone's desire to put "kernel contributor" on their resume is immaterial to the appropriateness of receiving that badge. "Mediocre" is a judgement you're projecting here, but we don't have evidence that the code was mediocre. And even if it was mediocre, most software goes through iterations, the first of which is almost always a mess. If the code he wrote was directly responsible for the code the maintainer wrote, there's a case to be made that credit is still due even if not a single line of the original code made it into the codebase. "You didn't type the exact line of characters that made it into GitHub so therefore you did not contribute" is a very limited view of the whole series of interactions and investment of human capital that ultimately led to the fix. > But the motivation isn't clean and if you care more about the credit than you do about the fix then clearly you have your priorities mixed up This is projection again. When you don't receive credit for your work and get upset about it, it does not imply that the only reason you did something was for the recognition. If you get passed up for a promotion at work because a coworker lied and took credit for your work, you're allowed to be pissed about that, and it doesn't mean that you don't deserve a promotion because you worked hard to get a promotion. I don't get the logic here at all. I agree that if the only reason someone contributes is to play a status game, that can lead to some questionable behaviors. But there's no evidence that this is the case here. > No, the value of FOSS is the ability to read and modify the source code. There is no singular attribute that makes up the "value of FOSS". Reading and modifying source code are valuable, but not exclusive to FOSS. The shared value of contributed fixes is also a major benefit of FOSS. FOSS is many things. > This person did not contribute as of now. I cannot imagine how you could conclude that the author did not contribute. If your definition of contribution is limited to "lines of text checked into a repo", perhaps you're correct, but this is an extremely limited view and incomplete picture of the nature of open source contribution. The bug was around for many years. Would the code that did make it into the kernel have been written in the same timeframe if the author had not submitted their own solution? There could have been many very good reasons not to include the author's code, and I'm not arguing against that. But it seems extremely disingenuous to claim that the author did not contribute quite a bit to this fix.
- kaishiro 3y agoIf ever I was considering contributing to a FOSS project, this comment and many others like it within this thread has firmly convinced me that it’s not worth the trouble.
- DeepSeaTortoise 3y agoThat's almost spot on. I've just barely arrived at the conclusion that I could make a change, offering minor suggestions and changes on projects I care about and then have the read someone degrading a contribution that is still "several levels above people that work their way into OSS projects in order to gain visibility by fixing a lot of trivial issues" And when you point this extreme ranking out as inappropriate, your comment gets vaporized. This REALLY bloody hurts
- throw16180339 3y agoYMMV, but here's what happened with my pull requests. 12 - accepted, sometimes additional changes were required 1 - ignored; this was a trivial change and I wouldn't have submitted it now. 1 - rejected; the maintainer didn't understand my proposed fix and closed the pull request. 1 - rejected; the maintainer disagreed with the proposed change.
- DeepSeaTortoise 3y agoMy comment didn't survive long at all, yet I still recommend giving it some serious thought. > This is several levels above people that work their way into OSS projects in order to gain visibility by fixing a lot of trivial issues As someone just getting started with but a tiny OSS footprint and grade care to not step on anyone's toes, this is a deeply unfair statement.
- alexsmarsh 3y ago[flagged]