4 ms·

> Sorry, I like my version better. If you want to be a Linux kernel contributor, here’s an issue you could fix. What a great way to make sure someone will neve

by V__ 3y ago

> Sorry, I like my version better. If you want to be a Linux kernel contributor, here’s an issue you could fix. What a great way to make sure someone will never help you again and disincentivize others from doing the same.

deleted 3y ago
[deleted]
blackkettle 3y ago
Especially after OP notes that the issue had been reported on and subsequently ignored for 6 years. Pretty lame behavior by the maintainer IMO.
mellosouls 3y ago
The actual wording: > I haven't actually reproduced the crash with gdbserver, but I have a > test case which shows the bug, so I've been able to confirm it and > test a fix. > > Thanks for your patch, but I wanted to fix it differently. Can you try > the patch below and make sure it fixes the bug for you? https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/244387.html https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/24... -- Also, not mentioned was another reviewers comment: I can't see the benefit of such macros if they are only for PPC32. : #ifdefs should be avoided as much as possible. : etc : Michael's patch seems easier to understand. https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/244531.html https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/24...
- jzb 3y ago
  This is when I lose all sympathy for the OP. All of it. Misrepresenting the actual statement this way is garbage. There's a world of difference in the two statements. I do understand why people clamor to get a patch into the kernel. It's a big deal. Feeling like you've come close and fallen short has to sting. But, part of having a patch accepted is being able to work with maintainers. Clear fail here. There's a definite air of entitlement in claiming that you're "robbed" of a patch and misrepresenting other people's words and actions.
  - bogwog 3y ago
    > Misrepresenting the actual statement this way is garbage. There's a world of difference in the two statements. That's debatable. What's not debatable is that not giving OP credit for the fix is disrespectful and bordering on plagiarism. Even if OP's patch wasn't as good as the final one (and giving OP feedback + time to improve their patch themselves isn't an option for some reason), not giving him credit is wrong. This bug would have remained were it not for his effort debugging and developing a fix, and his company investing the development time on it.
    - emerongi 3y ago
      I expected the maintainer to be bit of an asshole. Apparently they were totally respectful. They probably figured `Reported-by` is good enough credit, not putting themselves in the author's shoes (we all do this all the time). The author could have e-mailed the maintainer back and ask them to review their attribution practices and that would've been it. Instead they wrote a scathing article.
    - oefrha 3y ago
      It’s not debatable at all. It’s simply malicious to put something someone never said in a block quote to make them look bad, especially when the block quote font size is like twice that of everything else. They also cowardly added a “(paraphrasing)” outside to cover their ass. (Edit: in case it’s not clear, I’m not saying they added that after the post was published.) They achieved their goal: look at how many comments assume that malicious “paraphrasing”. They also made sure those of us who aren’t so quick to jump to conclusions after hearing a one-sided story will never interact with them ever.
      - phendrenad2 3y ago
        Malicious or a mis-remembering?
        oefrha 3y ago
        Conveniently misremembering a quote and making that gross misrepresentation a callout is indistinguishable from malice. I cover my ass by avoiding people who commit deniable acts indistinguishable from malice.
fragmede 3y ago
Except that's not what the maintainer said! OP's putting words in their mouths, and getting mad about that. That's not a winning strategy in life, especially where text communication is concerned.
- toyg 3y ago
  Actions speak louder than words. At the end of the day, the author was not credited for doing most of the work of fixing the bug. I'd be pretty mad too.
  - fragmede 3y ago
    Actions do speak louder than words. The code that ended up getting committed is the only real action here though. Everything else is words. Who wrote the original code, who wrote the commit message, what words were in the commit message. At the end of the day, if we concentrate on the action, and not the words, then we should ignore who said what and look to see if the bug was fixed and if the code works. Don't get me wrong, I'd absolutely be annoyed too, not to get more credit than a "reported-by", but: you are not your code, and the bug got fixed.
    - toyg 3y ago
      The actions include finding the bug, debugging it, and proposing a strategy for the fix that ended up being adopted in practice. All stuff the maintainer did not do but took credit for.
  - jzb 3y ago
    Actions do speak loudly - such as misrepresenting other people's statements so they sound worse than they are. He didn't actually author the patch. He did get a reported by credit. If you look through the thread, he clearly got some mentorship from the maintainers because the first attempts weren't maintainable.
throw_a_grenade 3y ago
Moreover, what is the guarantee the maintainer won't pull another one, will say that he again likes his version better and point to yet another bug?
- jzb 3y ago
  The actual thread shows the maintainer implementing the fix in a way he found better and prepping to do the backports for other stable kernels. The actual response was "Thanks for your patch, but I wanted to fix it differently" and gives him credit for reporting. The suggestion that the maintainer "pulled" something here is quite something. Is there any evidence that the author ever tried to ask for more credit aside from carping about it on their blog in public? If there was evidence that they'd gone to the maintainer and said "um, hey, I feel like I should get more credit than that" I might feel more sympathetic. As it is, they misrepresented the words of the maintainer and played the victim. If there's evidence they have tried to correct this on list then I might feel differently.
  - ariel-miculas 3y ago
    At this point, only Michael Ellerman could have this evidence in his mailbox. I've switched companies since then and unfortunately I don't have the private email exchange which happened between us (I've emailed him from my corporate email address).
jacquesm 3y ago
Except... that's not how it happened at all. OP makes it seem as though the exchange was disrespectful but it really wasn't.

by V__ 3y ago

deleted 3y ago

[deleted]

blackkettle 3y ago

Especially after OP notes that the issue had been reported on and subsequently ignored for 6 years. Pretty lame behavior by the maintainer IMO.

mellosouls 3y ago

The actual wording: > I haven't actually reproduced the crash with gdbserver, but I have a > test case which shows the bug, so I've been able to confirm it and > test a fix. > > Thanks for your patch, but I wanted to fix it differently. Can you try > the patch below and make sure it fixes the bug for you? https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/244387.html https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/24... -- Also, not mentioned was another reviewers comment: I can't see the benefit of such macros if they are only for PPC32. : #ifdefs should be avoided as much as possible. : etc : Michael's patch seems easier to understand. https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/244531.html https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/24...

jzb 3y ago
This is when I lose all sympathy for the OP. All of it. Misrepresenting the actual statement this way is garbage. There's a world of difference in the two statements. I do understand why people clamor to get a patch into the kernel. It's a big deal. Feeling like you've come close and fallen short has to sting. But, part of having a patch accepted is being able to work with maintainers. Clear fail here. There's a definite air of entitlement in claiming that you're "robbed" of a patch and misrepresenting other people's words and actions.
- bogwog 3y ago
  > Misrepresenting the actual statement this way is garbage. There's a world of difference in the two statements. That's debatable. What's not debatable is that not giving OP credit for the fix is disrespectful and bordering on plagiarism. Even if OP's patch wasn't as good as the final one (and giving OP feedback + time to improve their patch themselves isn't an option for some reason), not giving him credit is wrong. This bug would have remained were it not for his effort debugging and developing a fix, and his company investing the development time on it.
  - emerongi 3y ago
    I expected the maintainer to be bit of an asshole. Apparently they were totally respectful. They probably figured `Reported-by` is good enough credit, not putting themselves in the author's shoes (we all do this all the time). The author could have e-mailed the maintainer back and ask them to review their attribution practices and that would've been it. Instead they wrote a scathing article.
  - oefrha 3y ago
    It’s not debatable at all. It’s simply malicious to put something someone never said in a block quote to make them look bad, especially when the block quote font size is like twice that of everything else. They also cowardly added a “(paraphrasing)” outside to cover their ass. (Edit: in case it’s not clear, I’m not saying they added that after the post was published.) They achieved their goal: look at how many comments assume that malicious “paraphrasing”. They also made sure those of us who aren’t so quick to jump to conclusions after hearing a one-sided story will never interact with them ever.
    - phendrenad2 3y ago
      Malicious or a mis-remembering?
      - oefrha 3y ago
        Conveniently misremembering a quote and making that gross misrepresentation a callout is indistinguishable from malice. I cover my ass by avoiding people who commit deniable acts indistinguishable from malice.

fragmede 3y ago

Except that's not what the maintainer said! OP's putting words in their mouths, and getting mad about that. That's not a winning strategy in life, especially where text communication is concerned.

toyg 3y ago
Actions speak louder than words. At the end of the day, the author was not credited for doing most of the work of fixing the bug. I'd be pretty mad too.
- fragmede 3y ago
  Actions do speak louder than words. The code that ended up getting committed is the only real action here though. Everything else is words. Who wrote the original code, who wrote the commit message, what words were in the commit message. At the end of the day, if we concentrate on the action, and not the words, then we should ignore who said what and look to see if the bug was fixed and if the code works. Don't get me wrong, I'd absolutely be annoyed too, not to get more credit than a "reported-by", but: you are not your code, and the bug got fixed.
  - toyg 3y ago
    The actions include finding the bug, debugging it, and proposing a strategy for the fix that ended up being adopted in practice. All stuff the maintainer did not do but took credit for.
- jzb 3y ago
  Actions do speak loudly - such as misrepresenting other people's statements so they sound worse than they are. He didn't actually author the patch. He did get a reported by credit. If you look through the thread, he clearly got some mentorship from the maintainers because the first attempts weren't maintainable.

throw_a_grenade 3y ago

Moreover, what is the guarantee the maintainer won't pull another one, will say that he again likes his version better and point to yet another bug?

jzb 3y ago
The actual thread shows the maintainer implementing the fix in a way he found better and prepping to do the backports for other stable kernels. The actual response was "Thanks for your patch, but I wanted to fix it differently" and gives him credit for reporting. The suggestion that the maintainer "pulled" something here is quite something. Is there any evidence that the author ever tried to ask for more credit aside from carping about it on their blog in public? If there was evidence that they'd gone to the maintainer and said "um, hey, I feel like I should get more credit than that" I might feel more sympathetic. As it is, they misrepresented the words of the maintainer and played the victim. If there's evidence they have tried to correct this on list then I might feel differently.
- ariel-miculas 3y ago
  At this point, only Michael Ellerman could have this evidence in his mailbox. I've switched companies since then and unfortunately I don't have the private email exchange which happened between us (I've emailed him from my corporate email address).

jacquesm 3y ago

Except... that's not how it happened at all. OP makes it seem as though the exchange was disrespectful but it really wasn't.