8 ms·
Indeed you did, 10 years ago. This is the (mega!) commit: https://github.com/WebKit/WebKit/commit/93a48aa964f25ce8ec9f90aeaa142d2a9fb5b678 https://github.com/
by londons_explore 3y ago
Indeed you did, 10 years ago. This is the (mega!) commit:
https://github.com/WebKit/WebKit/commit/93a48aa964f25ce8ec9f90aeaa142d2a9fb5b678 https://github.com/WebKit/WebKit/commit/93a48aa964f25ce8ec9f...
I often wonder how much more productive I could be if I didn't need to split changes like this into 50 small commits, where every intermediate commit is working and has passing tests...
- pizlonator 3y agoYeah sometimes you just have to write a megapatch. I’d be very sad if I had to work on a project that didn’t allow that.
- bpye 3y agoI don't know what my largest commit has been, but I do find that merge conflicts end up being a real pain when you're touching so many files...
- AlotOfReading 3y agoMine was a very memorable ~2900 files changed. We missed an OS update cycle and had to consume all the changes in one giant patch. But upstream had migrated from Python 2 to 3 in-between and rewrote half their build scripts to accommodate. Each of those changes needed to be reviewed manually because we had modified things to support reproducible builds and the resulting merge conflict was monstrous. I contributed maybe 2300 of those before my sanity failed and called for help. Now we have a whole team to do that job more regularly.
- phatskat 3y agoI understand the desire to make larger patches, but how do you effectively manage them in the review process? For super large commits in the past, I’ve had other engineers hop on a screen share to review the diff together and answer questions, but it feels inefficient.
- 8n4vidtmkvmk 3y agoY'all are very thorough. Just make sure the function has tests and won't blow up prod. You needn't waste forever reviewing. It's code. It can be iterated upon.
- londons_explore 3y agoIndeed. I always push my teams into not hunting for spelling mistakes. Instead look for things that will be hard to fix in the future ('did you realise that this bootloader config stops us doing field updates??') or where the overall direction is wrong ('Not sure about os.system('grep') for this XML - why can't we just use the xml.etree here?').
- js2 3y ago> not hunting for spelling mistakes Unless it's the name of an HTTP header?
- ianlevesque 3y agoNot sure what you’re refering to.
- kccqzy 3y agoI find this to be more of a reflection of how well aligned you and the code reviewer are. When both of you know the code base inside out and trust each other, it's fine. But sometimes the author is a noob and the code reviewer has to review every little detail, much like an examiner looking at a student's paper. Or sometimes they might have a personal beef.
- hgsgm 3y agoI don't want a personal review, I want a code reviewer. "Trusting" someone means normalization of deviance, where bugs slip in.
- eru 3y ago> I often wonder how much more productive I could be if I didn't need to split changes like this into 50 small commits, where every intermediate commit is working and has passing tests... This is down to a trade-off between ease of writing and ease of review. Yes, if you didn't have to make your work presentable, you could bang it out faster. But then no one could read it.