2 ms·
I'm specifically talking about small (or reasonable) tasks that get blown up in the PR phase because of perfectionist reviewers. Requesting for example a big a
by the_gipsy 4y ago
I'm specifically talking about small (or reasonable) tasks that get blown up in the PR phase because of perfectionist reviewers.
Requesting for example a big architectural change in a pull request is not a good idea IMO. Ideally it should have happened in the design phase, but overspecifying everything is not the solution. Now, in a company, a request for a bigger change can simply be mentioned in the PR, and the tasks can then be created and assigned as follow ups.
This is usually not possible in OSS; the author of the PR might agree to the necessary changes but later not do them for whatever reason, and there might be no other volunteers to "clean up". Therefore it does makes sense to gatekeep and drag out some PRs in OSS.