7 ms·
Kudos to the engineer who originally not only identified the problem, but also raised the concern about breaking behavior, and about documenting it. Looks like
by neilv 4y ago
Kudos to the engineer who originally not only identified the problem, but also raised the concern about breaking behavior, and about documenting it.
Looks like the ball was first dropped when the issue was deferred without acknowledging the reporter's concise suggestions of how to handle it, engineering-wise. Nor a sign that existing code was reviewed for the same problem.
Then looks like the ball was dropped again, in what I'm guessing might've been: "old version, forget all the old open issues, all the issues that still apply, someone will rediscover the hard way".
This "aCropalypse" event is an example of how making the wrong triage of an issue report can turn out very expensive. All the costs to the world of aCropalypse could've been averted. Some of those costs might eventually come back to the company.
It's easy to guess why the problem happened and the report wasn't handled responsibly. By the time the problem exhibited in a way that couldn't be ignored, the pertinent metrics/KPIs/OKRs about clearing issues, resource allocations, and product shipment schedules were already in the past, bonuses had been paid, promotions for shipping new things earned, etc. And security problems are treated as inevitable, even if there's a constant stream of them, and they're produced faster than they're fixed.
We're going to need software engineers to be accountable for things we've done and signed off on.
(Bonus if accountability changes happen near-term: GPT-powered open source laundering gets a pause, because bridges start falling on everyone foolish enough to sign off on that mangled statistical plagiarism.)
- yjftsjthsd-h 4y ago> We're going to need software engineers to be accountable for things we've done and signed off on. Management first. It's not engineers setting incentives.
- ryandrake 4y agoThis is just passing the buck. If the boss tells you to write credit card stealing software or to DDOS your competitor are you just going to do it? As professionals, we need to push back and refuse when we know our practices are letting critical bugs go to production, just like (I assume) we'd push back if we were asked to build something unethical. And we should be accountable if we don't. If a civil engineer signs off on a bridge and it collapses during rush hour, he doesn't get to just say, "Whelp, boss rushed me, blame him."
- BobbyJo 4y agoYour example is so decoupled from reality that it's misleading. Most catastrophic problems in large systems aren't "I made a thing and it's buggy," or "I made a thing that steals SSNs." Most of them are some variation of "It used to work this way, but this upstream dependency changed in a way that we are ok with, and now it works a different way, and we have no visibility into what that may change for downstream dependencies, so hopefully they are aware of the same things we are and act accordingly." Bugs can come from many different people signing off on changes that are often, in isolation, fine. Imagine if all buildings had to constantly be retrofitted to support a new structures on, below, inside of, around, and next to them, and every retrofit had a different engineer/architect/etc. No civil engineer would ever sign off on anything.
- deleted 4y ago[deleted]
- ryandrake 4y agoYours is a good example! I have in a past life actually used the "you wouldn't bolt a new floor onto a building" argument successfully to push against feature creep. I think even a small amount of accountability would definitely start some much-needed conversations at software companies about things like "do we really need to retrofit this thing onto that working thing?" and "do we fully understand our dependencies and the consequence of merging from them?" and software quality would be better for it. If the consequence of a bug is low, go for it--the accountability should be low, too. EDIT, just to add another example. I remember when I felt rushed and checked in some client code that did not implement exponential backoff for request failures--it just retried. Of course that code made it to production and our customers started DDOSing our server when a brief outage happened. I felt terrible about it and honestly believe I should have been fired for it. Yes, management rushed me, but they're not the ones that wrote the code. They're not the ones that made an amateur-hour error. It was me.
- mangamadaiyan 4y ago> I felt terrible about it and honestly believe I should have been fired for it. > Yes, management rushed me, but they're not the ones that wrote the code If you felt so strongly about it, you could have quit. Why wait on management to fire you? It's fairly easy to blame engineers for everything that goes wrong. Engineering doesn't work in a vacuum, the system and processes have to have guardrails in place that prevent lapses in quality, including security, from reaching the customer. When such guardrails have been systematically dismantled in favour of "improving productivity", the management - which removed the guardrails - becomes the culpable entity.
- lupire 4y agoAt a properly licensed engineering firm, the managers are senior engineers who review and sign off.
- WirelessGigabit 4y agoKeyword being properly. Too many companies push their engineers into people management. Which is weird. Your best people should remain engineers. Have them indeed sign off on these things.
- chii 4y ago> Your best people should remain engineers. Have them indeed sign off on these things. I agree; the problem with an engineer track is that the salary ceiling is too low, and you have to move to management to get higher salary. but then you end up not using your engineering skills, and waste potential. What needs to happen is a way for people management to be done without a hierarchical structure. Aka, the senior engineer sits not under their manager, but that the manager is subservient. Joel spolsky have written about this "problem" already in the last couple of decade: https://www.joelonsoftware.com/2009/03/09/how-to-be-a-program-manager/ https://www.joelonsoftware.com/2009/03/09/how-to-be-a-progra... > To make sure that the debate happens respectfully and on a rational basis of facts, it’s absolutely critical that the program managers and developers be peers. If developers report to the program manager, at some point during the debate the program manager is going to get sick of the whole thing and just say, “OK, enough talking, now we do it my way.”
- ncphil 4y agoThe salary range in a professional track does not _have_ to be too low. That's a choice, a value judgment, by management. Some companies do things differently. In at least one company I know, the professional track runs parallel to the management track: engineers can earn as much or more than senior managers, architects as much as directors. It's all up to whether the organization really values the services it's independent contributors provide. Sadly, many companies are not only indifferent, but hostile to the whole concept: playing at cost reduction theater and outsourcing to satisfy the avarice of simpleton investors. Bottom line is that tech pros need to take charge of their own futures and avoid the latter kinds of companies like the plague, when they have a choice. People need to make a habit of asking questions about professional compensation structures during interviews.
- wilg 4y agoWhat kind of "accountability" do you mean?
- Jtsummers 4y agoPresumably similar to the accountability that applies to PEs. A subset of engineers are granted authority to sign off on parts of the system, they're assuming a legal responsibility and the penalties for malpractice can go all the way to imprisonment. Non-licensed engineer are not liable in the same sense, their employers and PEs are. Same thing could apply in software, but people whine too much and it probably won't happen. Every time the topic comes up, people chime in with "But software is different. It's hard." and expect that lame ass excuse to be sufficiently persuasive. Software is also critical, not all, but a lot. Critical systems warrant additional scrutiny and liability.
- wilg 4y agoWhat aspect of this "acropalypse" bug amounts to malpractice?
- Jtsummers 4y agoAn undocumented change to a core system behavior that fundamentally altered how (likely) most applications behaved in an unanticipated (for the users of the system and programmers targeting the system) way. That's malpractice.
- wilg 4y agoYeah, I don't buy that. Too much Monday-morning quarterbacking. I'm not against some well-thought-through standards for certain safety-critical applications, but it's got to be a lot better than "maybe code would be better if we threatened to throw engineers in jail for contributing to complex and subtle interdependent bugs that caused a privacy bug that didn't have a significant real-world impact".
- potatofrenzy 4y ago> This "aCropalypse" event is an example of how making the wrong triage of an issue report can turn out very expensive. All the costs to the world of aCropalypse could've been averted. Not trying to be facetious, but... what costs? It is unlikely that this cost the company any substantial amount. It probably wasn't even a whole lot of extra work for the PR department, as the bug didn't generate mainstream headlines.
- neilv 4y agoThe unquoted sentence after that was "Some of those costs might eventually come back to the company." Which I distinguish from "costs to the world" in the quoted sentence. By costs to the world I'm thinking all the things that happen because something a user cropped out was revealed because it wasn't really cropped. Hypotheticals to illustrate costs to the world: * A company loses a big business deal because IP/plans leaked to competition in reverted-crop. * A medical provider and personnel get hit by lawsuit and/or HIPPA for patient data de-anonymized due to reverted-crop of an image. * Someone gets harassed at their workplace when a reverted-crop adult photo revealed their identity and gets circulated among colleagues. * Semi-automated extortion rackets, going through troves of images, looking for revertible cropping. * Other businesses caught in the middle of this have to expend resources to mitigate, or even deal with liability for depending on or assuming correctness of third-party tech behavior, etc. Maybe luck is with us, and not a single instance of harm to the world actually happens. Or maybe there are many such instances of harm to the world. Regarding costs to the world eventually coming back to a company -- speaking in general, not of this particular situation -- I think that could come in forms including: brand damage, lost business, lawsuits from those harmed, undesirable turns in legislation, regulatory fines, etc.
- tgv 4y ago> the bug didn't generate mainstream headlines So ... yesterday it turned out that Microsoft had the control over a certain Bing's search results wide open to anyone with an Azure account, and that enabled anyone to get access to and control over the Azure services of everyone that used Bing for these specific searches. There were probably other ways too, but that hasn't been disclosed or investigated. And it is --of course!-- unknown if this attack ever happened in real life: there were no logs. That's quite the problem, wouldn't you say? Well, did you see mainstream articles? There was only an article in The Reg, which attracted a mere 11 replies. It simply doesn't get attention, probably because it was framed as "a misconfiguration", yet the costs could be staggering.
- to11mtm 4y ago> We're going to need software engineers to be accountable for things we've done and signed off on. Only if management is held equally accountable. I've worked at places with dedicated security teams, that acted as a 'buffer' between management and engineers. Those places tended to take security seriously. Places -without- those, I noticed that management has a tendency to sweep security issues 'under the rug' since they impact deadlines.
- FpUser 4y ago>"We're going to need software engineers to be accountable for things we've done and signed off on." And see them evaporate from the companies that would implement something like this. Personally I would neve take a contract where I could be held legally responsible for bugs. And ultimately it is the owner who let the product out in a wild without spending a year testing billions of permutations first. Try holding them responsible and see how far can you get.
- Eisenstein 4y ago'Hard' engineers do this, though. If you want the label you should take the responsibility as well.
- FpUser 4y agoI do not give a shit about a label and have none in a software field. Just MSc in physics. I design and implement products and I have long list of clients happy with my work. This helps me find new contracts. You can call me a shrub if you wish. I still get paid.
- throw_m239339 4y ago[flagged]
- anthk 4y agoIn Europe calling yourself an enginner without having a proper title can send you to jail, because an actual Engineer has civil duties and accountability on civil causalities.
- KennyBlanken 4y agoThis wasn't a matter of the ball being dropped, this is a matter of the epidemic of arrogance in Google. It's going to keep biting them in the ass. The prick who heads up Golang's security has refused to allow people to control what encryption algorithms are enabled to disabled in Golang's TLS 1.3 implementation (he was one of the designers of the TLS 1.3 spec) because, and I wish I were joking - he feels TLS 1.3's implementation is perfect and nobody would have a reason to, and even if they do, why, they can just wait until google releases the patch to fix it, and then deploy that change. Because of course that's how production environments work....you can just deploy a new version of the language you're using, instead of, you know, a config file change or a few lines of code.
- throw_m239339 4y ago> We're going to need software engineers to be accountable for things we've done and signed off on. You start with management and all the way to the top including the CEO and CTO liable for criminal charges. And, no we're not going to need any of that.
- numpad0 4y agoIMO this is another anecdotal proof that so called software “engineering” isn’t, and how uncontrolled over-complexity of modern software is going further out of control. Software is written, like blogs, novels or laws, not engineered. That’s wrong.
- robviren 4y agoI spent 5 years in nuclear power before going into tech and I have sort of joked that the software engineering the goes into AI, IoT, Phones, Cars, etc, is the next Chernobyl waiting to happen. It's all fun and games till these things get connected directly to lives. I actually find the governance of nuclear power a decent model for managing the risk. You mentioned management needs to be held responsible but management will choose short term profit every day until dealing with negative externalities is forced upon them like it is in nuclear. Imagine if the toxic waste that is the mental impact of social media, or forever insecure devices littering the Internet, or any number of things was obligated to the companies to do their best to fix it. Nuclear reactors put huge money away so that when they are done they are bulldozed back into a green field (Other than what was supposed to be a solved problem of spent fuel). Anyways, the likelihood of regulation is nil and a global world means those negative externalities will continue on churning till the world agrees we suck at managing risk. Which is also nil. Mental health crisis and insecure tech just isn't as flashy as nuclear in terms of getting regulated in the interest of public health.
- raverbashing 4y agoI second this Risk management (especially with the js people) seems to be "lol what's that?" Also we have the C cowboys pretending they can manage the complexity of their "simple language" in a complex world
- raverbashing 4y agoAnd to be even more honest, why create a similar API with different behavior? How many use cases prefer not truncating files?
- masklinn 4y agoThe worst part is that the API did originally behave like the one it’d originally emulated, before being modified after years of use.
- HeavyFeather 4y ago> the issue was deferred without acknowledging the reporter's concise suggestions of how to handle it, engineering-wise A day in my life at my last job. Basically a regular occurrence that it was “urgent” after a customer report.
- uf00lme 4y ago> All the costs to the world of aCropalypse could've been averted. Some of those costs might eventually come back to the company. This is the bigger problem, there will be very little real cost to the company or engineers involved. My guess is that the cost for engineering a fix and blogging it about it falls into the buffer PR spend or security engineering time. If anything the company will learn from this mistakes for a short time and it will actually save them money in the long run. The vast majority of software used today has very little legal liability. The industry has perfected the art of legal lip service. There is a massive growth at all costs mentality throughout the industry and engineer’s personal pride only goes so far. If you want to see real change then you need government and the judicial to enforce real legal liability onto software engineers and companies. That would result in real cyber security rather than current wack-a-mole fines or government’s trying to promote or enforce best practices etc.